patches for DPDK stable branches
 help / color / Atom feed
* Re: [dpdk-stable] [PATCH] net/mlx5: fix the blocker for push VLAN in Rx path
       [not found] <1581427206-3434-1-git-send-email-wisamm@mellanox.com>
@ 2020-02-12 12:52 ` Raslan Darawsheh
  0 siblings, 0 replies; only message in thread
From: Raslan Darawsheh @ 2020-02-12 12:52 UTC (permalink / raw)
  To: Wisam Monther, Matan Azrad, Slava Ovsiienko; +Cc: dev, Dekel Peled, stable

Hi,
 
> -----Original Message-----
> From: Wisam Monther <wisamm@mellanox.com>
> Sent: Tuesday, February 11, 2020 3:20 PM
> To: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Raslan Darawsheh <rasland@mellanox.com>
> Cc: dev@dpdk.org; Dekel Peled <dekelp@mellanox.com>
> Subject: [PATCH] net/mlx5: fix the blocker for push VLAN in Rx path
> 
> The blocker should take FDB into consideration, since FDB all directions
> have transfer ingress in it.
> 
> Fixes: 55060e62e4d2 ("net/mlx5: block push VLAN action on Rx")
> Cc: dekelp@mellanox.com
Removed Cc: Dekel, 
Added Cc: stable@dpdk.org

> 
> Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
Acked-by: Raslan Darawsheh <rasland@mellanox.com>

> ---
>  drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c
> index e71b3b5..c986f25 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -1746,7 +1746,7 @@ flow_dv_validate_action_push_vlan(uint64_t
> action_flags,
>  {
>  	const struct rte_flow_action_of_push_vlan *push_vlan = action-
> >conf;
> 
> -	if (attr->ingress)
> +	if (!attr->transfer && attr->ingress)
>  		return rte_flow_error_set(error, ENOTSUP,
> 
> RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,
>  					  NULL,
> --
> 2.7.4


Patch applied to next-net-mlx,

Kindest regards
Raslan Darawsheh

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1581427206-3434-1-git-send-email-wisamm@mellanox.com>
2020-02-12 12:52 ` [dpdk-stable] [PATCH] net/mlx5: fix the blocker for push VLAN in Rx path Raslan Darawsheh

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox