From: Raslan Darawsheh <rasland@mellanox.com>
To: Wisam Monther <wisamm@mellanox.com>, Ori Kam <orika@mellanox.com>,
Matan Azrad <matan@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Slava Ovsiienko <viacheslavo@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] net/mlx5: fix zero value validation for metadata
Date: Sun, 29 Mar 2020 14:06:42 +0000 [thread overview]
Message-ID: <AM0PR05MB67079C46262B3E73F2226A59C2CA0@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20200326102200.15281-1-wisamm@mellanox.com>
Hi,
> -----Original Message-----
> From: Wisam Monther <wisamm@mellanox.com>
> Sent: Thursday, March 26, 2020 12:22 PM
> To: Ori Kam <orika@mellanox.com>; Matan Azrad <matan@mellanox.com>;
> dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; stable@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix zero value validation for metadata
>
> MARK and META items are interrelated with datapath -
> they might move from/to the applications in mbuf.
>
> zero value for these items has the special meaning -
> it means "no metadata are provided", not zero values
> are treated by applications and PMD as valid ones.
>
> Moreover in the flow engine domain the value zero is
> acceptable to match and set, and we should allow to
> specify zero values as rte_flow parameters for the
> META and MARK items and actions. In the same time
> zero mask has no meaning and and should be rejected
> on validation stage.
>
> Fixes: fcc8d2f716fd ("net/mlx5: extend flow metadata support")
> Fixes: e554b672aa05 ("net/mlx5: support flow tag")
> Fixes: 55deee1715f0 ("net/mlx5: extend flow mark support")
> Cc: viacheslavo@mellanox.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
> ---
> Changes in v2
> - Fix commit message
> - Fix documentation
> - Remove extra line
> - Always check for zero mask
> ---
> ---
> doc/guides/nics/mlx5.rst | 12 ++++++++++++
> drivers/net/mlx5/mlx5_flow_dv.c | 19 +++++++++++++++----
> 2 files changed, 27 insertions(+), 4 deletions(-)
>
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> index e8f9984df0..e13c07d9ab 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -1275,6 +1275,18 @@ Supported hardware offloads
> | | | ConnectX-5 | | ConnectX-5 |
> +-----------------------+-----------------+-----------------+
>
> +Notes for metadata
> +------------------
> +MARK and META items are interrelated with datapath - they might move
> from/to
> +the applications in mbuf fields. Hence, zero value for these items has the
> +special meaning - it means "no metadata are provided", not zero values are
> +treated by applications and PMD as valid ones.
> +
> +Moreover in the flow engine domain the value zero is acceptable to match
> and
> +set, and we should allow to specify zero values as rte_flow parameters for
> the
> +META and MARK items and actions. In the same time zero mask has no
> meaning and
> +should be rejected on validation stage.
> +
> Notes for testpmd
> -----------------
>
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c
> index 809833b7ee..da4a925404 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -1406,6 +1406,11 @@ flow_dv_validate_item_mark(struct rte_eth_dev
> *dev,
> "mark id exceeds the limit");
> if (!mask)
> mask = &nic_mask;
> + if (!mask->id)
> + return rte_flow_error_set(error, EINVAL,
> +
> RTE_FLOW_ERROR_TYPE_ITEM_SPEC, NULL,
> + "mask cannot be zero");
> +
> ret = mlx5_flow_item_acceptable(item, (const uint8_t *)mask,
> (const uint8_t *)&nic_mask,
> sizeof(struct rte_flow_item_mark),
> @@ -1451,10 +1456,6 @@ flow_dv_validate_item_meta(struct rte_eth_dev
> *dev __rte_unused,
>
> RTE_FLOW_ERROR_TYPE_ITEM_SPEC,
> item->spec,
> "data cannot be empty");
> - if (!spec->data)
> - return rte_flow_error_set(error, EINVAL,
> -
> RTE_FLOW_ERROR_TYPE_ITEM_SPEC, NULL,
> - "data cannot be zero");
> if (config->dv_xmeta_en != MLX5_XMETA_MODE_LEGACY) {
> if (!mlx5_flow_ext_mreg_supported(dev))
> return rte_flow_error_set(error, ENOTSUP,
> @@ -1474,6 +1475,11 @@ flow_dv_validate_item_meta(struct rte_eth_dev
> *dev __rte_unused,
> }
> if (!mask)
> mask = &rte_flow_item_meta_mask;
> + if (!mask->data)
> + return rte_flow_error_set(error, EINVAL,
> +
> RTE_FLOW_ERROR_TYPE_ITEM_SPEC, NULL,
> + "mask cannot be zero");
> +
> ret = mlx5_flow_item_acceptable(item, (const uint8_t *)mask,
> (const uint8_t *)&nic_mask,
> sizeof(struct rte_flow_item_meta),
> @@ -1522,6 +1528,11 @@ flow_dv_validate_item_tag(struct rte_eth_dev
> *dev,
> "data cannot be empty");
> if (!mask)
> mask = &rte_flow_item_tag_mask;
> + if (!mask->data)
> + return rte_flow_error_set(error, EINVAL,
> +
> RTE_FLOW_ERROR_TYPE_ITEM_SPEC, NULL,
> + "mask cannot be zero");
> +
> ret = mlx5_flow_item_acceptable(item, (const uint8_t *)mask,
> (const uint8_t *)&nic_mask,
> sizeof(struct rte_flow_item_tag),
> --
> 2.17.1
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-03-29 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 9:02 [dpdk-stable] [PATCH] " Wisam Jaddo
2020-03-26 10:22 ` [dpdk-stable] [PATCH v2] " Wisam Jaddo
2020-03-26 10:24 ` Slava Ovsiienko
2020-03-29 14:06 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB67079C46262B3E73F2226A59C2CA0@AM0PR05MB6707.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=orika@mellanox.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@mellanox.com \
--cc=wisamm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).