From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28019A0564 for ; Tue, 24 Mar 2020 10:23:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 11E961C0CB; Tue, 24 Mar 2020 10:23:08 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60078.outbound.protection.outlook.com [40.107.6.78]) by dpdk.org (Postfix) with ESMTP id 784361C0AB; Tue, 24 Mar 2020 10:23:04 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a/JGn0vFzVpbqvvQQEboG94IQxqjE2tCiKfIPGMycRb4JnLebTSf1d7R7exCji6HzbEDYFFwBl9A3tVSsIyvrgtj8KO6rbDlb1Ug/LKF/r7claK8qx1D5e62gEvhc3YTtcYJJLukYwCJcGom5ahpAGVC5JS8YkEomwZEvQHOP2Vxt8ntaoLteNqjJY+/CHivL18W37nwatVsYG3BMOeVhomJ9wxlqoBxPHqYmeer6u4pCvYfKAP5BQSRUCN69kzYOH4YZLgX4KlZ8mIXTJntPHbEsbQLpB8wSe5b4HqaB7bpfw6MCMghFT7Ngw7A+e8nbLCB2BAWTlAuFt9UoaTVaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W7BArtiHUGXMmrFXJwE0nzfVSWuybWFrPBHxxOa37Is=; b=YDY8+HAQEfNpCR0sHhUlKof2Kkz9/5pAkn+j9WWJCkgw8voB0xG8/mJduq+L1C5WFrc2dS21P1APEuqMB4IuWyY60Hc4DlgGgupX5NIK2Shv2xpODuHWzuOLLrtTranFhbF0JOUjUzMS3yQuiDFNVPMCTJJtOhw6SYOE186Uw3uvPAr+Gh6yAn82u6teCsBxVq6HYZZOK/aXNcoSW4YES1TlwWdzVb86oEZ7nbnQSunf+8ZkHuxCXYWwTYPvAxdgH8bk7zGtS4DfWX/i3BEJ4M14N0AIb2wznN+tcgtnzom0CckOwzq3DDT1an0M316ch2gmJKX+YWKBMvZGQfxZ0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W7BArtiHUGXMmrFXJwE0nzfVSWuybWFrPBHxxOa37Is=; b=UAVVhsqkb9egViN8c1kFsGCA2u4dDH58Wuq8jJ8jkGzg40U8X5P6IwdmYzwToiXiQ118Qr60qT/pU6vUpA/m82fTJhpiOm+CwQgj87NJeogaLxuzEBOFgYn0DrPJoO3DHBHQteSLbr14/WAxuG5MiKtjzq8oFVhD7G8+7S63CcM= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (10.186.174.145) by AM0PR05MB4562.eurprd05.prod.outlook.com (52.133.56.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20; Tue, 24 Mar 2020 09:23:02 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::adbd:45ca:54:bba9]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::adbd:45ca:54:bba9%7]) with mapi id 15.20.2835.023; Tue, 24 Mar 2020 09:23:02 +0000 From: Raslan Darawsheh To: Raslan Darawsheh , Matan Azrad , Slava Ovsiienko CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix validation of VXLAN/VXLAN-GPE specs Thread-Index: AQHWAR5f+hpc9raUjk6R8bdH7WULR6hXeWNQ Date: Tue, 24 Mar 2020 09:23:02 +0000 Message-ID: References: <1584973293-186-1-git-send-email-rasland@mellanox.com> In-Reply-To: <1584973293-186-1-git-send-email-rasland@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [188.161.229.72] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 98aa5d58-6b4c-4998-5472-08d7cfd4f38a x-ms-traffictypediagnostic: AM0PR05MB4562:|AM0PR05MB4562: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 03524FBD26 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(346002)(39850400004)(396003)(376002)(53546011)(2906002)(6506007)(186003)(71200400001)(54906003)(110136005)(316002)(66476007)(76116006)(64756008)(52536014)(66446008)(66946007)(7696005)(66556008)(26005)(86362001)(4326008)(450100002)(55016002)(5660300002)(6636002)(9686003)(8936002)(478600001)(81156014)(81166006)(8676002)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB4562; H:AM0PR05MB6707.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O6/35Cu7sVc15WLEkGLqLHmhzuusDe3wIGsAcXnL+8YsnZCPC7O2gxSpiYWTuOm3meAQdeHfIc0Z8sXKscaFePYR2MRs5zyvfAsIelxocoQWrxZKqWQLDzg0evcHF7kffotahFLy5LTmX725Bq2gv+bl8NUfG7OA3zWWJCnMUp3dh2NR+LtTiN9Iv9fh776X75OpuATY9mjYR7KZPKzyMGFrWt5l6OQNi3QhLK6hlEuavae4U08jRhoFZqOH2jY9xUtggtDKIuWlCaSnJkoy73nQhTFGaOmE87lEwp5APaqTSGmDp9jaDqFfh3ID5C/TaEhBxDx4n9PGYMk57xlnHWuvAl5gQDVPetq7YoT8GxUdqK3gMxk7XfN1X87V3UhJ+UuHr/rPPVDz4vjxR3H87sT0NfBzGvTnpzVzIHHYGR8vGv1CqIJfKtJ7+0qbhhZL x-ms-exchange-antispam-messagedata: OgzhYJygrYzT906+q1z8yUGM8LS5UHKFEH26yaMgaF3zDm3j8J4GdCFgJrGVaRSF1f91weofMAG9IAudId4lwqr/RHHyVLP+iNKfll2PiWN9+4ObayQxhJpI/42USCgBpyUVCD2/Pd+h1aiW74j2xA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98aa5d58-6b4c-4998-5472-08d7cfd4f38a X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2020 09:23:02.0825 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w/HxfsXhR/TtJybEvZQSjcP8fFGIQSAQaGvUr5e3pjuyduaU8JGgb95LpmKnkaMs2iBir/ikQ6BVKo/DlxoTEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4562 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix validation of VXLAN/VXLAN-GPE specs X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of Raslan Darawsheh > Sent: Monday, March 23, 2020 4:22 PM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix validation of VXLAN/VXLAN-GPE > specs >=20 > Trying to create zero spec for vni wasn't allowed, to > avoid matching all packets from previous layer (udp). > This behavior is incorrect, since VXLAN is being identified > through the outer UDP destination port. >=20 > Currently, if the user didn't specify outer UDP destination > port the PMD will automatically match only on outer > UDP port of 4798, and if the user want to match on some none > standard port he need to specify it explicitly in the rule. >=20 > This removes the limitation of vni spec to be able to match any > vni. >=20 > Fixes: 23c1d42c ("net/mlx5: split flow validation to dedicated function") > Cc: stable@dpdk.org >=20 > Signed-off-by: Raslan Darawsheh > --- > drivers/net/mlx5/mlx5_flow.c | 31 ------------------------------- > 1 file changed, 31 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 41072da..2ef6558 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -1836,7 +1836,6 @@ mlx5_flow_validate_item_vxlan(const struct > rte_flow_item *item, > uint32_t vlan_id; > uint8_t vni[4]; > } id =3D { .vlan_id =3D 0, }; > - uint32_t vlan_id =3D 0; >=20 >=20 > if (item_flags & MLX5_FLOW_LAYER_TUNNEL) > @@ -1863,23 +1862,8 @@ mlx5_flow_validate_item_vxlan(const struct > rte_flow_item *item, > return ret; > if (spec) { > memcpy(&id.vni[1], spec->vni, 3); > - vlan_id =3D id.vlan_id; > memcpy(&id.vni[1], mask->vni, 3); > - vlan_id &=3D id.vlan_id; > } > - /* > - * Tunnel id 0 is equivalent as not adding a VXLAN layer, if > - * only this layer is defined in the Verbs specification it is > - * interpreted as wildcard and all packets will match this > - * rule, if it follows a full stack layer (ex: eth / ipv4 / > - * udp), all packets matching the layers before will also > - * match this rule. To avoid such situation, VNI 0 is > - * currently refused. > - */ > - if (!vlan_id) > - return rte_flow_error_set(error, ENOTSUP, > - RTE_FLOW_ERROR_TYPE_ITEM, > item, > - "VXLAN vni cannot be 0"); > if (!(item_flags & MLX5_FLOW_LAYER_OUTER)) > return rte_flow_error_set(error, ENOTSUP, > RTE_FLOW_ERROR_TYPE_ITEM, > item, > @@ -1918,7 +1902,6 @@ mlx5_flow_validate_item_vxlan_gpe(const struct > rte_flow_item *item, > uint32_t vlan_id; > uint8_t vni[4]; > } id =3D { .vlan_id =3D 0, }; > - uint32_t vlan_id =3D 0; >=20 > if (!priv->config.l3_vxlan_en) > return rte_flow_error_set(error, ENOTSUP, > @@ -1956,22 +1939,8 @@ mlx5_flow_validate_item_vxlan_gpe(const struct > rte_flow_item *item, > "VxLAN-GPE protocol" > " not supported"); > memcpy(&id.vni[1], spec->vni, 3); > - vlan_id =3D id.vlan_id; > memcpy(&id.vni[1], mask->vni, 3); > - vlan_id &=3D id.vlan_id; > } > - /* > - * Tunnel id 0 is equivalent as not adding a VXLAN layer, if only this > - * layer is defined in the Verbs specification it is interpreted as > - * wildcard and all packets will match this rule, if it follows a full > - * stack layer (ex: eth / ipv4 / udp), all packets matching the layers > - * before will also match this rule. To avoid such situation, VNI 0 > - * is currently refused. > - */ > - if (!vlan_id) > - return rte_flow_error_set(error, ENOTSUP, > - RTE_FLOW_ERROR_TYPE_ITEM, > item, > - "VXLAN-GPE vni cannot be 0"); > if (!(item_flags & MLX5_FLOW_LAYER_OUTER)) > return rte_flow_error_set(error, ENOTSUP, > RTE_FLOW_ERROR_TYPE_ITEM, > item, > -- > 2.7.4 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh