From: Raslan Darawsheh <rasland@mellanox.com>
To: Bill Zhou <dongz@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>, Matan Azrad <matan@mellanox.com>
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix LRO checksum completence
Date: Tue, 16 Jun 2020 08:02:39 +0000 [thread overview]
Message-ID: <AM0PR05MB6707C5E25FB89610ED1DCB40C29D0@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20200612085746.21139-1-dongz@mellanox.com>
Hi,
> -----Original Message-----
> From: Bill Zhou <dongz@mellanox.com>
> Sent: Friday, June 12, 2020 11:58 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Raslan Darawsheh <rasland@mellanox.com>; Matan
> Azrad <matan@mellanox.com>
> Subject: [PATCH] net/mlx5: fix LRO checksum completence
>
> The TCP checksum includes IPV4 pseudo-header checksum and L3
> payload checksum which include TCP header and TCP payload.
> When mlx5 LRO is enabled, HW will calculate the TCP payload
> checksum, PMD need complete the IPV4 pseudo-header checksum
> and the TCP header checksum.
>
> The mlx5_lro_update_tcp_hdr function completes the TCP header
> checksum, but this function using lower 4 bits of data-offset
> field in TCP header to get the whole TCP header length, this
> will cause TCP header checksum wrong calculation.
>
> Update the code using higher 4 bits of data-offset field
> instead of lower 4 bits.
>
> Fixes: e4c2a16eb1de ("net/mlx5: handle LRO packets in Rx queue")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bill Zhou <dongz@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index 6a17a9a5d0..e4c1c95b0e 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -1529,7 +1529,7 @@ mlx5_lro_update_tcp_hdr(struct rte_tcp_hdr
> *restrict tcp,
> if (cqe->lro_tcppsh_abort_dupack & MLX5_CQE_LRO_PUSH_MASK)
> tcp->tcp_flags |= RTE_TCP_PSH_FLAG;
> tcp->cksum = 0;
> - csum += rte_raw_cksum(tcp, (tcp->data_off & 0xF) * 4);
> + csum += rte_raw_cksum(tcp, (tcp->data_off >> 4) * 4);
> csum = ((csum & 0xffff0000) >> 16) + (csum & 0xffff);
> csum = (~csum) & 0xffff;
> if (csum == 0)
> --
> 2.21.0
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-06-16 8:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 8:57 Bill Zhou
2020-06-16 8:02 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB6707C5E25FB89610ED1DCB40C29D0@AM0PR05MB6707.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=dev@dpdk.org \
--cc=dongz@mellanox.com \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).