From: Raslan Darawsheh <rasland@mellanox.com>
To: Wisam Monther <wisamm@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@mellanox.com>
Cc: Slava Ovsiienko <viacheslavo@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix validate set meta action for zero value
Date: Sun, 15 Mar 2020 11:29:52 +0000 [thread overview]
Message-ID: <AM0PR05MB6707E6B7D9202CC08C2FDC2DC2F80@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1584005080-32321-1-git-send-email-wisamm@mellanox.com>
Hi,
> -----Original Message-----
> From: Wisam Monther <wisamm@mellanox.com>
> Sent: Thursday, March 12, 2020 11:25 AM
> To: dev@dpdk.org; Raslan Darawsheh <rasland@mellanox.com>; Matan
> Azrad <matan@mellanox.com>
> Cc: Slava Ovsiienko <viacheslavo@mellanox.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix validate set meta action for zero value
>
> There is no reason to prevent the user from using zero metadata,
> it indeed means no metadata, but sometimes the user may need to
> report to datapath that there is no metadata anymore, which is
> valid case.
>
> Fixes: fcc8d2f716fd ("net/mlx5: extend flow metadata support")
> Cc: viacheslavo@mellanox.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_flow_dv.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c
> index e7278f0..e2d6690 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -2109,10 +2109,6 @@ flow_dv_validate_action_set_meta(struct
> rte_eth_dev *dev,
> return rte_flow_error_set(error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ACTION,
> action,
> "meta data must be within reg C0");
> - if (!(conf->data & conf->mask))
> - return rte_flow_error_set(error, EINVAL,
> - RTE_FLOW_ERROR_TYPE_ACTION,
> action,
> - "zero value has no effect");
> return 0;
> }
>
> --
> 2.7.4
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-03-15 11:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 9:24 Wisam Jaddo
2020-03-15 11:29 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB6707E6B7D9202CC08C2FDC2DC2F80@AM0PR05MB6707.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@mellanox.com \
--cc=wisamm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).