* [dpdk-stable] [PATCH v2 5/6] test/lpm: reset total time
[not found] ` <20190906094534.36060-1-ruifeng.wang@arm.com>
@ 2019-09-06 9:45 ` Ruifeng Wang
2019-09-18 16:17 ` Medvedkin, Vladimir
0 siblings, 1 reply; 3+ messages in thread
From: Ruifeng Wang @ 2019-09-06 9:45 UTC (permalink / raw)
To: bruce.richardson, vladimir.medvedkin, olivier.matz
Cc: dev, stephen, konstantin.ananyev, gavin.hu, honnappa.nagarahalli,
dharmik.thakkar, nd, stable
From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
total_time needs to be reset to measure the cycles for delete API.
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
app/test/test_lpm_perf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c
index 77eea66ad..a2578fe90 100644
--- a/app/test/test_lpm_perf.c
+++ b/app/test/test_lpm_perf.c
@@ -460,7 +460,7 @@ test_lpm_perf(void)
(double)total_time / ((double)ITERATIONS * BATCH_SIZE),
(count * 100.0) / (double)(ITERATIONS * BATCH_SIZE));
- /* Delete */
+ /* Measure Delete */
status = 0;
begin = rte_rdtsc();
@@ -470,7 +470,7 @@ test_lpm_perf(void)
large_route_table[i].depth);
}
- total_time += rte_rdtsc() - begin;
+ total_time = rte_rdtsc() - begin;
printf("Average LPM Delete: %g cycles\n",
(double)total_time / NUM_ROUTE_ENTRIES);
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH v2 5/6] test/lpm: reset total time
2019-09-06 9:45 ` [dpdk-stable] [PATCH v2 5/6] test/lpm: reset total time Ruifeng Wang
@ 2019-09-18 16:17 ` Medvedkin, Vladimir
2019-09-19 6:22 ` Ruifeng Wang (Arm Technology China)
0 siblings, 1 reply; 3+ messages in thread
From: Medvedkin, Vladimir @ 2019-09-18 16:17 UTC (permalink / raw)
To: Ruifeng Wang, bruce.richardson, olivier.matz
Cc: dev, stephen, konstantin.ananyev, gavin.hu, honnappa.nagarahalli,
dharmik.thakkar, nd, stable
Hi Ruifeng,
Thanks for this bug fix.
I think it should be sent separately from this RCU related patch series.
On 06/09/2019 10:45, Ruifeng Wang wrote:
> From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>
> total_time needs to be reset to measure the cycles for delete API.
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> app/test/test_lpm_perf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c
> index 77eea66ad..a2578fe90 100644
> --- a/app/test/test_lpm_perf.c
> +++ b/app/test/test_lpm_perf.c
> @@ -460,7 +460,7 @@ test_lpm_perf(void)
> (double)total_time / ((double)ITERATIONS * BATCH_SIZE),
> (count * 100.0) / (double)(ITERATIONS * BATCH_SIZE));
>
> - /* Delete */
> + /* Measure Delete */
> status = 0;
> begin = rte_rdtsc();
>
> @@ -470,7 +470,7 @@ test_lpm_perf(void)
> large_route_table[i].depth);
> }
>
> - total_time += rte_rdtsc() - begin;
> + total_time = rte_rdtsc() - begin;
>
> printf("Average LPM Delete: %g cycles\n",
> (double)total_time / NUM_ROUTE_ENTRIES);
--
Regards,
Vladimir
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH v2 5/6] test/lpm: reset total time
2019-09-18 16:17 ` Medvedkin, Vladimir
@ 2019-09-19 6:22 ` Ruifeng Wang (Arm Technology China)
0 siblings, 0 replies; 3+ messages in thread
From: Ruifeng Wang (Arm Technology China) @ 2019-09-19 6:22 UTC (permalink / raw)
To: Medvedkin, Vladimir, bruce.richardson, olivier.matz
Cc: dev, stephen, konstantin.ananyev, Gavin Hu (Arm Technology China),
Honnappa Nagarahalli, Dharmik Thakkar, nd, stable, nd
Hi Vladimir,
> -----Original Message-----
> From: Medvedkin, Vladimir <vladimir.medvedkin@intel.com>
> Sent: Thursday, September 19, 2019 00:18
> To: Ruifeng Wang (Arm Technology China) <Ruifeng.Wang@arm.com>;
> bruce.richardson@intel.com; olivier.matz@6wind.com
> Cc: dev@dpdk.org; stephen@networkplumber.org;
> konstantin.ananyev@intel.com; Gavin Hu (Arm Technology China)
> <Gavin.Hu@arm.com>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Dharmik Thakkar
> <Dharmik.Thakkar@arm.com>; nd <nd@arm.com>; stable@dpdk.org
> Subject: Re: [PATCH v2 5/6] test/lpm: reset total time
>
> Hi Ruifeng,
>
> Thanks for this bug fix.
>
> I think it should be sent separately from this RCU related patch series.
Agree. It will be sent out separately.
>
> On 06/09/2019 10:45, Ruifeng Wang wrote:
> > From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> >
> > total_time needs to be reset to measure the cycles for delete API.
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > ---
> > app/test/test_lpm_perf.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c index
> > 77eea66ad..a2578fe90 100644
> > --- a/app/test/test_lpm_perf.c
> > +++ b/app/test/test_lpm_perf.c
> > @@ -460,7 +460,7 @@ test_lpm_perf(void)
> > (double)total_time / ((double)ITERATIONS *
> BATCH_SIZE),
> > (count * 100.0) / (double)(ITERATIONS *
> BATCH_SIZE));
> >
> > - /* Delete */
> > + /* Measure Delete */
> > status = 0;
> > begin = rte_rdtsc();
> >
> > @@ -470,7 +470,7 @@ test_lpm_perf(void)
> > large_route_table[i].depth);
> > }
> >
> > - total_time += rte_rdtsc() - begin;
> > + total_time = rte_rdtsc() - begin;
> >
> > printf("Average LPM Delete: %g cycles\n",
> > (double)total_time / NUM_ROUTE_ENTRIES);
>
> --
> Regards,
> Vladimir
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-19 6:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190822063457.41596-1-ruifeng.wang@arm.com>
[not found] ` <20190906094534.36060-1-ruifeng.wang@arm.com>
2019-09-06 9:45 ` [dpdk-stable] [PATCH v2 5/6] test/lpm: reset total time Ruifeng Wang
2019-09-18 16:17 ` Medvedkin, Vladimir
2019-09-19 6:22 ` Ruifeng Wang (Arm Technology China)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).