[dpdk-stable] [PATCH] net/mlx5: fix send for multi segment packet

[dpdk-stable] [PATCH] net/mlx5: fix send for multi segment packet

[shahafs]

Fixes: 2a66cf378954 ("net/mlx5: support inline send")

CC: stable@dpdk.org
Signed-off-by: shahafs <shahafs@mellanox.com>
---
 drivers/net/mlx5/mlx5_rxtx.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index b542e76..8b54651 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -477,7 +477,7 @@
 				assert(addr <= addr_end);
 			}
 			/*
-			 * 2 DWORDs consumed by the WQE header + 1 DSEG +
+			 * 2 DWORDs consumed by the WQE header + ETH segment +
 			 * the size of the inline part of the packet.
 			 */
 			ds = 2 + MLX5_WQE_DS(pkt_inline_sz - 2);
@@ -492,6 +492,10 @@
 			} else if (!segs_n) {
 				goto next_pkt;
 			} else {
+				/* dseg will be advance as part of next_seg*/
+				dseg = (volatile rte_v128u32_t *)
+					((uintptr_t)wqe +
+					 ((ds-1) * MLX5_WQE_DWORD_SIZE));
 				goto next_seg;
 			}
 		} else {
-- 
1.8.3.1

Re: [dpdk-stable] [PATCH] net/mlx5: fix send for multi segment packet

[Yuanhan Liu]

On Wed, Dec 21, 2016 at 10:51:11AM +0200, shahafs wrote:
> Fixes: 2a66cf378954 ("net/mlx5: support inline send")
> 
> CC: stable@dpdk.org
> Signed-off-by: shahafs <shahafs@mellanox.com>

I didn't see you cc dev@dpdk.org. Is it a patch only for stable branch
(v16.11 specifically)? And it will not apply to the current master?

	--yliu

> ---
>  drivers/net/mlx5/mlx5_rxtx.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index b542e76..8b54651 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -477,7 +477,7 @@
>  				assert(addr <= addr_end);
>  			}
>  			/*
> -			 * 2 DWORDs consumed by the WQE header + 1 DSEG +
> +			 * 2 DWORDs consumed by the WQE header + ETH segment +
>  			 * the size of the inline part of the packet.
>  			 */
>  			ds = 2 + MLX5_WQE_DS(pkt_inline_sz - 2);
> @@ -492,6 +492,10 @@
>  			} else if (!segs_n) {
>  				goto next_pkt;
>  			} else {
> +				/* dseg will be advance as part of next_seg*/
> +				dseg = (volatile rte_v128u32_t *)
> +					((uintptr_t)wqe +
> +					 ((ds-1) * MLX5_WQE_DWORD_SIZE));
>  				goto next_seg;
>  			}
>  		} else {
> -- 
> 1.8.3.1

Re: [dpdk-stable] [PATCH] net/mlx5: fix send for multi segment packet

[Shahaf Shuler]

This commit was sent early by a mistake
the correct patch will be submitted at dev@dpdk.org with a copy for stable@dpdk.org

--Shahaf


-----Original Message-----
From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] 
Sent: Wednesday, December 21, 2016 11:59 AM
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix send for multi segment packet

On Wed, Dec 21, 2016 at 10:51:11AM +0200, shahafs wrote:
> Fixes: 2a66cf378954 ("net/mlx5: support inline send")
> 
> CC: stable@dpdk.org
> Signed-off-by: shahafs <shahafs@mellanox.com>

I didn't see you cc dev@dpdk.org. Is it a patch only for stable branch
(v16.11 specifically)? And it will not apply to the current master?

	--yliu

> ---
>  drivers/net/mlx5/mlx5_rxtx.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c 
> b/drivers/net/mlx5/mlx5_rxtx.c index b542e76..8b54651 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -477,7 +477,7 @@
>  				assert(addr <= addr_end);
>  			}
>  			/*
> -			 * 2 DWORDs consumed by the WQE header + 1 DSEG +
> +			 * 2 DWORDs consumed by the WQE header + ETH segment +
>  			 * the size of the inline part of the packet.
>  			 */
>  			ds = 2 + MLX5_WQE_DS(pkt_inline_sz - 2); @@ -492,6 +492,10 @@
>  			} else if (!segs_n) {
>  				goto next_pkt;
>  			} else {
> +				/* dseg will be advance as part of next_seg*/
> +				dseg = (volatile rte_v128u32_t *)
> +					((uintptr_t)wqe +
> +					 ((ds-1) * MLX5_WQE_DWORD_SIZE));
>  				goto next_seg;
>  			}
>  		} else {
> --
> 1.8.3.1