From: Slava Ovsiienko <viacheslavo@mellanox.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>,
"bernard.iremonger@intel.com" <bernard.iremonger@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix txonly flow generation entropy
Date: Tue, 11 Feb 2020 19:57:54 +0000 [thread overview]
Message-ID: <AM4PR05MB3265D7815D0FDFDB7AD4EAD6D2180@AM4PR05MB3265.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <15cb05eb-1d32-4d81-320b-36e4e8e76ab5@intel.com>
Hi, Ferruh
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, February 10, 2020 16:02
> To: Slava Ovsiienko <viacheslavo@mellanox.com>; dev@dpdk.org
> Cc: Thomas Monjalon <thomas@monjalon.net>;
> bernard.iremonger@intel.com; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix txonly flow generation
> entropy
>
> On 2/9/2020 5:02 PM, Viacheslav Ovsiienko wrote:
> > The testpmd application in txonly forwarding mode has an option to
> > generate the packet flows by varying the destination IP address.
> > The patch increments the IP for each packet sent, this improves the
> > entropy and RSS distibution on the peer receiving size is getting more
> > uniform.
>
> The IP address already incremented for each packet sent [1], I can't see what
> this patch adds.
Not exactly, that commit increments the ip_var local variable only.
On the next call ip_var is assigned from thread local storage variable
ip_var = RTE_PER_LCORE(_ip_var) - and increment is lost, it is supposed to be a bug.
We have the bursts of packets with the same IPs.
My patch stores the incremented value in the local storage variable. It is double checked,
after applying the patch we see the more fair RSS distribution on receiving peer.
With best regards, Slava
>
> [1]
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Flxr.dpdk.
> org%2Fdpdk%2Fv19.11%2Fsource%2Fapp%2Ftest-
> pmd%2Ftxonly.c%23L208&data=02%7C01%7Cviacheslavo%40mellanox.co
> m%7C6a5be2d6ecdd4c487e7908d7ae31dc95%7Ca652971c7d2e4d9ba6a4d149
> 256f461b%7C0%7C0%7C637169401491712071&sdata=QMXvKlSVy3vAUMz
> Fzj%2ByRKKWUcVToR3hlX8S3a7V21I%3D&reserved=0
>
>
> btw, for reference the option mentioned is "--txonly-multi-flow" and it has
> been added with:
> commit: 82010ef55e7c ("app/testpmd: make txonly mode generate multiple
> flows")
>
Mmm, yes. My patch refers exactly to the this. Sorry, I do not understand your comment,
could you, please, clarify what do you mean?
With best regards, Slava
next prev parent reply other threads:[~2020-02-11 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 17:02 Viacheslav Ovsiienko
2020-02-10 14:02 ` Ferruh Yigit
2020-02-11 19:57 ` Slava Ovsiienko [this message]
2020-02-12 8:59 ` Ferruh Yigit
2020-02-12 17:26 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR05MB3265D7815D0FDFDB7AD4EAD6D2180@AM4PR05MB3265.eurprd05.prod.outlook.com \
--to=viacheslavo@mellanox.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).