patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Nipun Gupta <nipun.gupta@nxp.com>
To: wangyunjian <wangyunjian@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "jerry.lilijun@huawei.com" <jerry.lilijun@huawei.com>,
	"xudingke@huawei.com" <xudingke@huawei.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses
Date: Wed, 7 Oct 2020 05:35:07 +0000	[thread overview]
Message-ID: <AM5PR0401MB2593340A9990E6B10B93FC79E60A0@AM5PR0401MB2593.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1599613906-19420-1-git-send-email-wangyunjian@huawei.com>

Acked by: Nipun Gupta <nipun.gupta@nxp.com>

> -----Original Message-----
> From: wangyunjian <wangyunjian@huawei.com>
> Sent: Wednesday, September 9, 2020 6:42 AM
> To: dev@dpdk.org
> Cc: Nipun Gupta <nipun.gupta@nxp.com>; jerry.lilijun@huawei.com;
> xudingke@huawei.com; Yunjian Wang <wangyunjian@huawei.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses
> 
> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> This issue detected by coverity, CID#279443(Structurally dead code).
> 
> Coverity issue: 279443
> Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> v2: fix spelling in commit log
> ---
>  drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> index 0b9c4e3d7..4b8474951 100644
> --- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> +++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> @@ -452,9 +452,10 @@ rte_qdma_reset(void)
>  	/* In case there are pending jobs on any VQ, return -EBUSY */
>  	for (i = 0; i < qdma_dev.max_vqs; i++) {
>  		if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues !=
> -		    qdma_vqs[i].num_dequeues))
> +		    qdma_vqs[i].num_dequeues)) {
>  			DPAA2_QDMA_ERR("Jobs are still pending on VQ: %d",
> i);
>  			return -EBUSY;
> +		}
>  	}
> 
>  	/* Reset HW queues */
> --
> 2.18.1
> 


  parent reply	other threads:[~2020-10-07  5:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07 13:41 [dpdk-stable] [dpdk-dev] [PATCH] " wangyunjian
2020-09-09  1:11 ` [dpdk-stable] [dpdk-dev] [PATCH v2] " wangyunjian
2020-10-06 21:33   ` Thomas Monjalon
2020-10-07  5:35   ` Nipun Gupta [this message]
2020-10-11 20:06     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM5PR0401MB2593340A9990E6B10B93FC79E60A0@AM5PR0401MB2593.eurprd04.prod.outlook.com \
    --to=nipun.gupta@nxp.com \
    --cc=dev@dpdk.org \
    --cc=jerry.lilijun@huawei.com \
    --cc=stable@dpdk.org \
    --cc=wangyunjian@huawei.com \
    --cc=xudingke@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).