From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50065.outbound.protection.outlook.com [40.107.5.65]) by dpdk.org (Postfix) with ESMTP id D20545942 for ; Mon, 3 Sep 2018 10:25:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HF0jVL2g2KmnG1N3KVWFh/4jeV5MDHAME2xSdJ1SlgU=; b=inzVhu5L12jI0wIh3vlcL7YxrT1kSn0nLdXQcOmESTapA0E/sDVTGZmGB1r8ldensA/w05GWKOOa4n54uAwlAJ3LJujj3vLh4Gz8aghctCz4RqKe/yvcgUOFhQ0vq9vcVM2U6DIZrsTXG/tFhR1V7r5dXqrY/d5ExTa0fSLcGWQ= Received: from AM6PR08MB3672.eurprd08.prod.outlook.com (20.177.115.29) by AM6PR08MB2967.eurprd08.prod.outlook.com (52.135.163.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1101.14; Mon, 3 Sep 2018 08:25:48 +0000 Received: from AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::649b:b10d:ef69:7fd2]) by AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::649b:b10d:ef69:7fd2%4]) with mapi id 15.20.1080.015; Mon, 3 Sep 2018 08:25:48 +0000 From: Honnappa Nagarahalli To: Yongseok Koh CC: "stable@dpdk.org" , nd Thread-Topic: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined Thread-Index: AQHUQutHksvtrTRwPEy6+Zaj0UhVC6TdYOGAgAAHzUCAAENzgIAAjS9Q Date: Mon, 3 Sep 2018 08:25:48 +0000 Message-ID: References: <1535913120-22426-1-git-send-email-honnappa.nagarahalli@arm.com> <8BD04EEF-AF53-4990-9273-A0F737EF8F4D@mellanox.com> In-Reply-To: <8BD04EEF-AF53-4990-9273-A0F737EF8F4D@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.106.50] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR08MB2967; 6:fcg17OgBoOPK1tNWVx0QD9RDh8CfGVFPRYvpp2lapKvhAWMxCsWj57qNYyiUC9KGB4icDjgI9ozzzB9ukCYR2ub8KUJ09T07sxSxWVdgyrqwKi6Ek9oFWZxzpHJjgB7lvfUn6OxPZ/3wZMBtc5Z9lyzDjse3k9ytEvlFdBX91kD19zK5y5V+CdUGbpA+BKrbX1y16Z0QptZHOdgkRHurIMcR+2G/0vEO02Hj4/oFhxkx0cBBYMs+aSPw/riJwezTGmlTHyJLTeucdRER5mb0H+jIIyjASvbak37zq3KTxKlGaAMZ+BRMKbXxfyWgqNstqlNLt/7jytLvZzJtXIAApDOqr/3Z/5X2n0zN56FamqSEryNdcVSQESdKfZC8nFqLutPfqQ2pk/UHUDP5DBuadixMPkJ9fPKxchYR04cCaAcOaVZumL+hBtvKSFtPO3Uxb1WV8SQ7i4o3QKRxOisc2w==; 5:9aWXRtYlYXhTxUOhbJU68Pi/T4dM//HbpzkZcH/4yyXh2dttT+wnpNnS/ZAbnO0Ox4Ll8iggpkhkOcSC1s9JHhRnHTGAO8L903nk6FkFVph0Fi+0iljQbESq9fiB118Qx4T+ybNMK6ng10oKoZ0907XpmFCrWxeFR3B85HUyOjI=; 7:qOObCHzV/t694ncYLPklYQxI0HpmJ3u1fV9sIerlJ/Y9mr9EhLPP4D+C4IKpQOtbHVTtSD22W9T1lDF3oSfu2LlhynXzR/Nf7KpmPvgKQV8xnYBBmYqeGyVb8980EIE7tT1CMg+Rw/dN3eoTmxolnMCy+kRHnvLCGmnZbRndNTYER9lnZKwTI9U6FsWRueA/SxZaBOp44q7o1q1JQmBX499IgvGQdUGXX71i+r3aQqYiDAD6gnnWvLT34gn9t2GJ x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 96c2281b-5789-4085-1887-08d61176da67 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB2967; x-ms-traffictypediagnostic: AM6PR08MB2967: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(823301075)(93006095)(93001095)(3231311)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(201708071742011)(7699016); SRVR:AM6PR08MB2967; BCL:0; PCL:0; RULEID:; SRVR:AM6PR08MB2967; x-forefront-prvs: 0784C803FD x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(39850400004)(396003)(346002)(376002)(13464003)(189003)(199004)(305945005)(446003)(66066001)(11346002)(8936002)(486006)(7736002)(6506007)(53546011)(72206003)(105586002)(74316002)(93886005)(106356001)(26005)(33656002)(25786009)(186003)(14454004)(476003)(102836004)(55016002)(4326008)(99286004)(256004)(6916009)(54906003)(9686003)(53936002)(76176011)(5250100002)(478600001)(2906002)(316002)(97736004)(6246003)(6436002)(14444005)(86362001)(6116002)(81156014)(81166006)(3846002)(68736007)(5660300001)(229853002)(7696005)(2900100001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB2967; H:AM6PR08MB3672.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: KiQqvhkRiACMycE4r6y3bsGAfqMjllzGVyln9pE6o009Fw9cGE+nX7DocGhFAh8LhjVgtRKJ89I5wEWOzaF1jgAIxItUjtPS7szqM18+y728lUi+7iWlUgca8F92xEPptND4KdUjUddw8/eaWIwsx0mrWTKrX+xpTvUwXlYQ4TyU+oaVYJ601PTNIosTW0ziE7HtPxJuCxwU24xuPDRRCGaOLzjU0vRB1+p64I+hVPGmISTM3KFL+ZTrJfUwKP1iH5Cjos7Xx7Oe2lTz8+OTxrf+2EyTFJidZGd3cpuxR0jF188Hah+hdQr3L1sNuhPQl3VWtYoEkJNo9Bbw3XDnLNq+Otoz+xkJTm8DCFWOFWM= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96c2281b-5789-4085-1887-08d61176da67 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Sep 2018 08:25:48.6105 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB2967 Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Sep 2018 08:25:50 -0000 -----Original Message----- From: Yongseok Koh =20 Sent: Sunday, September 2, 2018 7:00 PM To: Honnappa Nagarahalli Cc: stable@dpdk.org; nd Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __a= arch64__ is defined > On Sep 2, 2018, at 12:59 PM, Honnappa Nagarahalli wrote: >=20 > -----Original Message----- > From: Yongseok Koh > Sent: Sunday, September 2, 2018 2:30 PM > To: Honnappa Nagarahalli > Cc: stable@dpdk.org > Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags=20 > when __aarch64__ is defined >=20 >> On Sep 2, 2018, at 11:32 AM, Honnappa Nagarahalli wrote: >>=20 >> GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not=20 >> optional for ArmV8. Hence NEON related code can be enabled when=20 >> __aarch64__ is defined. >>=20 >> Bugzilla ID: 82 >> Cc: stable@dpdk.org >>=20 >> Reported-by: Raslan Darawsheh >> Reported-by: Thomas F Herbert >> Signed-off-by: Honnappa Nagarahalli >> Reviewed-by: Phil Yang >> Reviewed-by: Gavin Hu >> Acked-by: Gavin Hu >> Acked-by: Jerin Jacob >> --- >> V2: >> * Corrected the order of contribution tags >> * Added Jerin's Ack >=20 > I didn't check out the details yet but a quick question. > Do you want me to include this patch in 17.11.4? >=20 > Yes, please include. I didn't realized that this is fixing the meson build. 17.11 doesn't have that. Thanks, Yongseok It has a fix for the make build as well. Does it mean, it needs to be a dif= ferent patch? >> config/arm/meson.build | 3 ++- >> mk/rte.cpuflags.mk | 2 +- >> 2 files changed, 3 insertions(+), 2 deletions(-) >>=20 >> diff --git a/config/arm/meson.build b/config/arm/meson.build index >> 40dbc87..94cca49 100644 >> --- a/config/arm/meson.build >> +++ b/config/arm/meson.build >> @@ -157,7 +157,8 @@ else >> endif >> message(machine_args) >>=20 >> -if cc.get_define('__ARM_NEON', args: machine_args) !=3D '' >> +if (cc.get_define('__ARM_NEON', args: machine_args) !=3D '' or >> + cc.get_define('__aarch64__', args: machine_args) !=3D '') >> dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1) >> compile_time_cpuflags +=3D ['RTE_CPUFLAG_NEON'] endif diff --git=20 >> a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index 6071313..43ed841 >> 100644 >> --- a/mk/rte.cpuflags.mk >> +++ b/mk/rte.cpuflags.mk >> @@ -89,7 +89,7 @@ CPUFLAGS +=3D VSX >> endif >>=20 >> # ARM flags >> -ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),) >> +ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),) >> CPUFLAGS +=3D NEON >> endif >>=20 >> -- >> 2.7.4 >>=20 >=20