From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60069.outbound.protection.outlook.com [40.107.6.69]) by dpdk.org (Postfix) with ESMTP id DA7884CBD for ; Sun, 2 Sep 2018 21:59:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4/awNI7mHve35lU/uTA4ga8XYPHWHmMdL+voxeO4UZA=; b=ljEU5FuPcppL4asdKISGt+9RZ/bi1mb42ekD0n68hP2ODL+V1UHoF8FPerOxpeimYZP3YMN5W+PTEh9p1GOse6TK5HbDe0W5nXAxFslxCozGimXc6vlwkkhnuf64wiWmtEzBHbg9racipdZlr+lfi79TQftevkg7R57LNu2+Qy8= Received: from AM6PR08MB3672.eurprd08.prod.outlook.com (20.177.115.29) by AM6PR08MB3317.eurprd08.prod.outlook.com (52.135.165.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1101.18; Sun, 2 Sep 2018 19:59:35 +0000 Received: from AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::649b:b10d:ef69:7fd2]) by AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::649b:b10d:ef69:7fd2%4]) with mapi id 15.20.1080.015; Sun, 2 Sep 2018 19:59:35 +0000 From: Honnappa Nagarahalli To: Yongseok Koh CC: "stable@dpdk.org" , nd Thread-Topic: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined Thread-Index: AQHUQutHksvtrTRwPEy6+Zaj0UhVC6TdYOGAgAAHzUA= Date: Sun, 2 Sep 2018 19:59:35 +0000 Message-ID: References: <1535913120-22426-1-git-send-email-honnappa.nagarahalli@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR08MB3317; 6:frFMuTUsRIjuRnnY6C4QeH4K9/E9uExOku/vWLVHs5MMyxcifF798wzwY8hTxwc/ud7oAbiZ/BJuQHM/6TR83Yr/b/QB0c/c+IfVe9DIEaT723+DD6vm7JDxW2x0yNs7IOCqe/Nu5HbqMUKhzRh+hMdccziEjiBhw97Lf0BZbfecNfgXjl20a45sq11U4HSsFW8aB+idLonOSuXA6DuJnEcyM1LiICbh6FakjoKO7Nu00iRVOoGt9PWYRXcWCrwzXrJhy4tSl0hBhzljtc2mACbuWrIQzDVeFBkuSA6RXwB7H88kQsxaQo7n1aN7iD3AkMemaVPkkc1qjhpmnuKEAPt2e6wol91TCqccExbcIRYCnIcTWKYJYAC07C55f4dD3oRd5+9bTIA2jpkAxQjTEVCOT8NvogLSxAbhFoIaEEYj/NokoDTv88718kwv4+YLSs6Sr59AhqmRIRVurCPBrA==; 5:KDQATNVy+hn8Kh8wlValXkVQXaP+93M5VxpHCsMN7uiH/l5162Sz/ASkygcBkc+/8bXiQfDr1dQ9lL4aPBng19m2q7RMCb4QTT5YtFYBNY8zEUIIqDMaQrLDiBAq34nVa7d4M4fGsR5Y8E1hChsLvCwuILy3aCLPi9b4Veem6FQ=; 7:XveXthSXVUaqc802dQvDsVWzusnzuqShSkG4HmElPWZIjw2vKjHUwk2VGrdCZC/PxKDN+iOmsPL4GNm8zmbdjsWbt+ZHNIordh6mhicyiLOiI8s2w02cMWcn47Fkp1S84oHQC9lG3zbiYaeNwQ5Oa/N/FAlO0KRpfMBXATyfQW52rg+TTpGYQR5afUazSf3YMsguLpu5tR/fywrup4JaOmW4u9BLVqmFGLqlUdvU2eDzeeT7DlStFylbnJpU4XV7 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: ab5cf14f-ee0d-4554-7262-08d6110e9b81 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB3317; x-ms-traffictypediagnostic: AM6PR08MB3317: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301075)(93006095)(93001095)(10201501046)(3002001)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(20161123558120)(201708071742011)(7699016); SRVR:AM6PR08MB3317; BCL:0; PCL:0; RULEID:; SRVR:AM6PR08MB3317; x-forefront-prvs: 078310077C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(366004)(39850400004)(376002)(346002)(189003)(199004)(13464003)(81156014)(66066001)(7736002)(76176011)(55016002)(74316002)(9686003)(86362001)(186003)(446003)(53936002)(6436002)(14454004)(256004)(11346002)(26005)(53546011)(6506007)(305945005)(3846002)(6116002)(102836004)(2900100001)(2906002)(14444005)(476003)(229853002)(106356001)(25786009)(68736007)(105586002)(33656002)(6246003)(6916009)(81166006)(97736004)(8936002)(486006)(4326008)(54906003)(316002)(99286004)(7696005)(478600001)(72206003)(5660300001)(5250100002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3317; H:AM6PR08MB3672.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: IZqlNGZGcOJUGOKgYaxM2QSLo+ap4MtK3KcKheLYY+kjKYrXpvsXaPKRMH31Brubpz6i2YV7YOmQ7G4MsCdOspHuMUvXPcZFWBPomY4Msabs4EWwAP0gcDp1GfIbbAvtudHnb3S6goD5CrFnRqv3syK6c4I/F6VpR0F1uDRoEc9RDBOhRqsrE0NEpk3XiJgH4We667DKxfPyATMRS87b4Ckjx1tgPBETvhUugdGtcgZLnRtmjlbc7u4grd4qPEaaomU2+tP61z7vhH/lbTXP5YujWsOuuT+1ipzKPWnlTRfb+1UdhiMsD4cYbNp/FVzG2OpZG72RCAcJYtTdObIOdd+y2IfAIFK9e0NpH2StjNI= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab5cf14f-ee0d-4554-7262-08d6110e9b81 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2018 19:59:35.4279 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3317 Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Sep 2018 19:59:37 -0000 -----Original Message----- From: Yongseok Koh =20 Sent: Sunday, September 2, 2018 2:30 PM To: Honnappa Nagarahalli Cc: stable@dpdk.org Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __a= arch64__ is defined Hi, Thanks, Yongseok > On Sep 2, 2018, at 11:32 AM, Honnappa Nagarahalli wrote: >=20 > GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not optional=20 > for ArmV8. Hence NEON related code can be enabled when __aarch64__ is=20 > defined. >=20 > Bugzilla ID: 82 > Cc: stable@dpdk.org >=20 > Reported-by: Raslan Darawsheh > Reported-by: Thomas F Herbert > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Phil Yang > Reviewed-by: Gavin Hu > Acked-by: Gavin Hu > Acked-by: Jerin Jacob > --- > V2: > * Corrected the order of contribution tags > * Added Jerin's Ack I didn't check out the details yet but a quick question. Do you want me to include this patch in 17.11.4? Yes, please include. Thanks, Yongseok > config/arm/meson.build | 3 ++- > mk/rte.cpuflags.mk | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/config/arm/meson.build b/config/arm/meson.build index=20 > 40dbc87..94cca49 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -157,7 +157,8 @@ else > endif > message(machine_args) >=20 > -if cc.get_define('__ARM_NEON', args: machine_args) !=3D '' > +if (cc.get_define('__ARM_NEON', args: machine_args) !=3D '' or > + cc.get_define('__aarch64__', args: machine_args) !=3D '') > dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1) > compile_time_cpuflags +=3D ['RTE_CPUFLAG_NEON'] endif diff --git=20 > a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index 6071313..43ed841=20 > 100644 > --- a/mk/rte.cpuflags.mk > +++ b/mk/rte.cpuflags.mk > @@ -89,7 +89,7 @@ CPUFLAGS +=3D VSX > endif >=20 > # ARM flags > -ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),) > +ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),) > CPUFLAGS +=3D NEON > endif >=20 > -- > 2.7.4 >=20