From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91E86A0093 for ; Thu, 21 Apr 2022 14:05:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6AA1D40040; Thu, 21 Apr 2022 14:05:14 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2075.outbound.protection.outlook.com [40.107.22.75]) by mails.dpdk.org (Postfix) with ESMTP id 7A8DC40040 for ; Thu, 21 Apr 2022 14:05:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZSHm6jLwPgHP/2bwnE5ac1b82PFyIMs/1/FmoLnaGduY8IHit6ha7IRYQ+FEbD2LbdmsBsGBhyWjBcGcf0KrUojSAmW8qsL2l9qDILS8MNfUFk2dJLkcUmdbZudkU8IPs0WcmkmAV4Iw1uED6WV9qTfnh2tNg02fqys1ciTywNoR5Z/NZMHpkjx/CLc2ZRXUctZWbHjouLmEkYsfPUahiaQQkTYFlNce42NHl3XxpLTtjEvKIiYK1ZKs4Z+iZ4fNuOgqp5l5xW/H/SGqs1JC9clh+boGubVtgkdUb4ZN92/62XI/GvZFNDumE/Le+D6AHg/46l0SZjziAh2rP327bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sxVzHLnN9lNDMPqCddhaKyMg9ZY6R1lzaFG6W4cQvJM=; b=E9JeM01UYH8EbxbeBO6cgkpvrLQ/UEI7JiGq6qD1opkDZSLTNJQtQZxe0EoihRb2dQSHBruSlcrc1VlgtQwM8vEtH93cpX3k5gSw4bnklnHlToFYxrkItZpUeNch2Wc+pm6FtBKjzCyyOEdjR602iRbiJKTBUXJZ8fanNI2hpIUEirdx0YfKzZC1GAr2VKK1KoD8gmPVwet09fare7mg0Kz4exiRSqV6Uptlf57NFXBvGxtYgTOihNeXMme8KH7zzDA7olRgsoTA2oHdaYnF4i5JuP7C4ce3JfgU6Nh9vM7wM/ecOEmd0C9hCFMEGM927tszGkuQyneDHis88w6A/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sxVzHLnN9lNDMPqCddhaKyMg9ZY6R1lzaFG6W4cQvJM=; b=pP3cyYDvYZo5PxCbVt+PlZRx/+VyG3qBw16E9F3UZ6xOpfUsuLlKhlrEZAMWzlmkfysmqNgwNQFcHtwMeGCf/Ppc2P/V3bsZ6+7r68R3XR3Yq4d6edlL0uRAp9JvBWvNnYB56pxqeOWMnc62w+8NSzPeEKbKTiSSi4CqNE7zSn0= Received: from AS8PR04MB9064.eurprd04.prod.outlook.com (2603:10a6:20b:447::17) by AM9PR04MB7569.eurprd04.prod.outlook.com (2603:10a6:20b:2d8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr 2022 12:05:12 +0000 Received: from AS8PR04MB9064.eurprd04.prod.outlook.com ([fe80::a822:649e:d64f:5e80]) by AS8PR04MB9064.eurprd04.prod.outlook.com ([fe80::a822:649e:d64f:5e80%5]) with mapi id 15.20.5164.026; Thu, 21 Apr 2022 12:05:12 +0000 From: Hemant Agrawal To: Gagandeep Singh , dpdk-up CC: "Akhil Goyal (OSS)" , "stable@dpdk.org" Subject: RE: [PATCH 11/15] crypto/dpaa2_sec: fix crypto op pointer for atomic and ordered queues Thread-Topic: [PATCH 11/15] crypto/dpaa2_sec: fix crypto op pointer for atomic and ordered queues Thread-Index: AQHYVXeBMVIIkn494kGuzcc0vbSubKz6RQ5g Date: Thu, 21 Apr 2022 12:05:12 +0000 Message-ID: References: <20220421120043.2565227-1-g.singh@nxp.com> <20220421120043.2565227-11-g.singh@nxp.com> In-Reply-To: <20220421120043.2565227-11-g.singh@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c9154818-c5ff-4f0b-74bc-08da238f3024 x-ms-traffictypediagnostic: AM9PR04MB7569:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: z/GuLmCgxv4Hi4SqvNGndV911LHiOB2G/fxrCCaONileCaei97PA5arYsC7MtxBDEUHPIXKqkPjbeevAoX6vNy7dyMcO2rg7JNwMSfbh3sS6tIl+MJwFkIcvqF1GQeNMlhuksWZuwoWi+dK23fi5CDEtNPYu7PJXuoUYQjfoEUXSsNtPB3x2yC18U/1DqNdJX7Srzl9IzmzZirsuZG7AvgDhNUM5ec+juHmfB+zZLOaMEY1Q1juZPvBQU+OnlbV6ZIq1BjgC8s2LbgyUSA+Gk9e0iqhg9VmwtVkzUQLOilm8ExAU7LV5JvpOR4iQWJoj00JG83ovZS/vy5IACk1U236JxtHLuCBCw1JP+OCAgbLEAdaCVVeq2uAgnnjMao3hsAKJ/tXUNoQLqLK8siG2m83Hu2FKHEvBJ0cExZLfPuSglFf/67Sy5o3Pj7qgGyvRUKgrM2miKnR40Zo6soBXf3zcKWCMq5aMy08SPmZaxWhcjC6XnZrw85aLCItYHn6BF4mso76ToyeE2E6LLWXlfH62ivsAF+wrSVnLJBDu0CIw7NgOHVNqwV7t44EZuUxokaCLuzfT1bBiLOZ7vac5rufHr3JvErbRCofBTaznCUGu6KDJ5ouCuJBwm0mS4YR9kWyehRiJ07iIF3VqJTR3mjaecJkAC0qXG3Kt3ZbfZkzW0wWpH/ZBwG3bmDR+hyohGIP7XIqZeyoph5gMnnjsLg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB9064.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(52536014)(8936002)(8676002)(66476007)(66446008)(64756008)(66556008)(66946007)(5660300002)(54906003)(44832011)(110136005)(316002)(53546011)(6506007)(7696005)(71200400001)(508600001)(4326008)(33656002)(83380400001)(76116006)(86362001)(55016003)(122000001)(2906002)(9686003)(38100700002)(38070700005)(26005)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yrN6pAVUCkPJHDekE03nh+muIz0O346kIjggHeHLPcYKyEVvQScYb9Edo9cq?= =?us-ascii?Q?5unUhNRElzKM//1NIfd/QIJOc0+O5yrezfVcp2h0IDPaVrFwc6S2EswG0XAO?= =?us-ascii?Q?EA2yZv/T7MBtGKhgIR/QTnf/8rOIAWBShdnh8/80d+o4VsgPcvkIhF+wfvox?= =?us-ascii?Q?rHakZJrxW6pnim/VSBI2qpgqXRWZ7jQ/Ri+4GRvNb3XtCIVYyv0bLCj4HkRo?= =?us-ascii?Q?c2WRUiBtwKhf7iCVXUbA71uXOBlPiUXR655mwLQgDnoi7iCw+0fEz0jTSoX4?= =?us-ascii?Q?F5D90raTU00IUt+uLD8QHmqfgcca2iYe2TpGKSCeA2cs3xcmV6+J0Crbyzr+?= =?us-ascii?Q?iP1c7BAVDteYmw5N9tUDK9rQXfiNSErG8RQnxMxGJUakK/1O7IcyDv2Jr6X8?= =?us-ascii?Q?R8J0UPEs7SwUMenYsGCWSS39waU0Ufdd9uipxQ/aClQH+n7exaDxFAnMEJWY?= =?us-ascii?Q?6o+EOD2Ucwx9Q+M3BHv4GwRzW5mrnFCCstCmS/SzmmV3Qm08l2mn5mZrPSfY?= =?us-ascii?Q?Inr+22/9VjpUnD1fXliJome3A9kqTwxUaey9pAZdKgVUvlRHW+KkXepyb7rI?= =?us-ascii?Q?DIPzIO9WKp0JRr8maIjrZ1Z+vYNMazfjT5yGGW07B1jWCq3mAtGHQ9CGDoX+?= =?us-ascii?Q?8awTuuXiuuvqNdL0kONBaOn3OVGY//UJs+su/xERefjIgvvBm1mId1L7BqBQ?= =?us-ascii?Q?eTKBKmUPHRziC4WRkAiwZXRtJ+pprQfbOwuKM7I0bud9cGu5WDopUCeQN2M+?= =?us-ascii?Q?CddLDPiOBJCOUwMHm7noyDq9l3wqvvC3uDeRKUojKYNxR8C+Y0logoGy1m4m?= =?us-ascii?Q?+EsW8kxsgJJOuQI8Ng/yJfNkFxBlMbDSrHe4CRX/x7nC/Ky6e9Oml9P5xBru?= =?us-ascii?Q?JX+/h4oPOFUH8bzojNqiv5uTytA0EwOV3laPvlVKCLWkjU9QW5BOBbz+wsoz?= =?us-ascii?Q?8itLqoQ/gN3aATUBINLOijKP8s7xUv2EbjOrGk0ZgNHrZp4YegYUosUJ1JG2?= =?us-ascii?Q?FCvz0Cm/sM3W7gIAh1M/apOEBNZ51/dHwQzvWFJS12cqZUi/D6fZbI0BkfHh?= =?us-ascii?Q?FOqNB0dvqu41aFfmC512BHjRfHbU89mzObmRDUd53m7HNh6VeyA1F7vfaY5a?= =?us-ascii?Q?w6RXxvbsWfgel1BpIFn5nEwCofKEUvc0iQtiYBuS0MUKj8+pzHA+uUcQO6SR?= =?us-ascii?Q?a/MJvjqwZqPHud5yQIq9FswsaoII3VdoVGgc97IrKnfxT5R2wYGql5ZUNejY?= =?us-ascii?Q?gXDJvxinQhDWK2SyTr3ohF2YAobmVhAYhhb25OKx7M3BvymBTtdPOl3/kUzS?= =?us-ascii?Q?nxqQwzGpYDwoj92GxF3ViIQDvjDVsYxkOe6rUMCGmYfl39HcxM6QXiuwli64?= =?us-ascii?Q?X1sFJ9JURhzMBlANjEYRE3skTuIzvNcWe2lEI2r+l1ZC+YOiL6QsGT944EPR?= =?us-ascii?Q?cQTs6LXz7HJdaSxO9xxL1t9QEmVsr0/2f+1toYp+MdsX7cQ/Y65Yv9OdoVwv?= =?us-ascii?Q?XzzHHLFayx7HQz94MKD3WgshvmVvLqSawbHgVOui6YLTEhXtDZ2gqXhh4o9k?= =?us-ascii?Q?Skeow24HxLPSV4Rn0dk7LGURNdlxMF3sfJSM+JMIAq2LVAmslC1iV9Ex6U7r?= =?us-ascii?Q?2Aa5QBfPZ2HHFWJ3LOcd1uhm+VSQoDIB9g9zy2EGj/UV7Z8juPA26m46w6nv?= =?us-ascii?Q?+zX0aMSv9n22mi5luCimaMeUb/ew9fuuDmEqaC6/AZbIlXL15y2k/x1+JRYW?= =?us-ascii?Q?63mmReagFw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9064.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9154818-c5ff-4f0b-74bc-08da238f3024 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2022 12:05:12.0409 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kyhK3ECLl0dtlFLxv6iHoaYDAL4byxI5A8UoF2BauS7tqHwhHRJXibxRQZHeaNerc25PJGspfyhLd/qVfXuUyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7569 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Replace Akhil with your name.=20 > -----Original Message----- > From: Gagandeep Singh > Sent: Thursday, April 21, 2022 5:31 PM > To: dpdk-up > Cc: Akhil Goyal (OSS) ; stable@dpdk.org; > Gagandeep Singh > Subject: [PATCH 11/15] crypto/dpaa2_sec: fix crypto op pointer for atomic > and ordered queues >=20 > From: Akhil Goyal >=20 > Driver is filling the crypto_op variable with an invalid value which can = results > into segmentation fault. >=20 > This patch assigning the correct crypto_op and event buffer pointers by > extracting from FD. >=20 > Fixes: a77db24643b7 ("crypto/dpaa2_sec: support atomic queues") > Fixes: 4562de326d30 ("crypto/dpaa2_sec: support ordered queue") > Cc: stable@dpdk.org >=20 > Signed-off-by: Akhil Goyal > Signed-off-by: Gagandeep Singh > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > index 86c8df241b..9f2b384af9 100644 > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > @@ -4019,7 +4019,7 @@ dpaa2_sec_process_atomic_event(struct > qbman_swp *swp __rte_unused, { > uint8_t dqrr_index; > struct dpaa2_sec_qp *qp; > - struct rte_crypto_op *crypto_op =3D (struct rte_crypto_op *)ev- > >event_ptr; > + struct rte_crypto_op *crypto_op; > /* Prefetching mbuf */ > rte_prefetch0((void *)(size_t)(DPAA2_GET_FD_ADDR(fd)- >=20 > rte_dpaa2_bpid_info[DPAA2_GET_FD_BPID(fd)].meta_data_size)); > @@ -4036,12 +4036,13 @@ dpaa2_sec_process_atomic_event(struct > qbman_swp *swp __rte_unused, > ev->queue_id =3D rxq->ev.queue_id; > ev->priority =3D rxq->ev.priority; >=20 > - ev->event_ptr =3D sec_fd_to_mbuf(fd, qp); > + crypto_op =3D sec_fd_to_mbuf(fd, qp); > dqrr_index =3D qbman_get_dqrr_idx(dq); > *dpaa2_seqn(crypto_op->sym->m_src) =3D > QBMAN_ENQUEUE_FLAG_DCA | dqrr_index; > DPAA2_PER_LCORE_DQRR_SIZE++; > DPAA2_PER_LCORE_DQRR_HELD |=3D 1 << dqrr_index; > DPAA2_PER_LCORE_DQRR_MBUF(dqrr_index) =3D crypto_op->sym- > >m_src; > + ev->event_ptr =3D crypto_op; > } >=20 > static void __rte_hot > @@ -4051,7 +4052,7 @@ dpaa2_sec_process_ordered_event(struct > qbman_swp *swp, > struct dpaa2_queue *rxq, > struct rte_event *ev) > { > - struct rte_crypto_op *crypto_op =3D (struct rte_crypto_op *)ev- > >event_ptr; > + struct rte_crypto_op *crypto_op; > struct dpaa2_sec_qp *qp; >=20 > /* Prefetching mbuf */ > @@ -4069,7 +4070,7 @@ dpaa2_sec_process_ordered_event(struct > qbman_swp *swp, > ev->sched_type =3D rxq->ev.sched_type; > ev->queue_id =3D rxq->ev.queue_id; > ev->priority =3D rxq->ev.priority; > - ev->event_ptr =3D sec_fd_to_mbuf(fd, qp); > + crypto_op =3D sec_fd_to_mbuf(fd, qp); >=20 > *dpaa2_seqn(crypto_op->sym->m_src) =3D > DPAA2_ENQUEUE_FLAG_ORP; > *dpaa2_seqn(crypto_op->sym->m_src) |=3D > qbman_result_DQ_odpid(dq) << @@ -4078,6 +4079,7 @@ > dpaa2_sec_process_ordered_event(struct qbman_swp *swp, > DPAA2_EQCR_SEQNUM_SHIFT; >=20 > qbman_swp_dqrr_consume(swp, dq); > + ev->event_ptr =3D crypto_op; > } >=20 > int > -- > 2.25.1