From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6076EA04A5 for ; Wed, 19 Jan 2022 10:44:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4ADC5410FB; Wed, 19 Jan 2022 10:44:55 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2075.outbound.protection.outlook.com [40.107.20.75]) by mails.dpdk.org (Postfix) with ESMTP id E4B6F4013F; Wed, 19 Jan 2022 10:44:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yKjWOT91ELZ3AFMlzAN48gGYvtxVbHCyhlCmK41G5Nk=; b=c6lp8iPMGVcnHHXn0lmu3VRNBa7qtJ3se/zNbKQOsqXLG5pw4m+hThFHwy4OSlRsXrXh0ECRfgPF5qW2eGDJH0J0v76mAZeLNz9uNdYury95eL+VO4epNwqmwUsJ1ysU2/mDNoNNQQlKrq2SSxDTRfwpPeyelZPxb2NT7yCQcIE= Received: from DB6P193CA0016.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::26) by AM9PR08MB7199.eurprd08.prod.outlook.com (2603:10a6:20b:3de::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Wed, 19 Jan 2022 09:44:45 +0000 Received: from DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:29:cafe::d) by DB6P193CA0016.outlook.office365.com (2603:10a6:6:29::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.10 via Frontend Transport; Wed, 19 Jan 2022 09:44:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT005.mail.protection.outlook.com (10.152.20.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9 via Frontend Transport; Wed, 19 Jan 2022 09:44:45 +0000 Received: ("Tessian outbound 741ca6c82739:v113"); Wed, 19 Jan 2022 09:44:45 +0000 X-CR-MTA-TID: 64aa7808 Received: from 88cc0ba7dc40.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CCDB3387-7643-4233-8D67-F15A93A3AB27.1; Wed, 19 Jan 2022 09:44:37 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 88cc0ba7dc40.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 19 Jan 2022 09:44:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UPiDtVxutUf8hF0/4TAb8ZDFoE23A0eEiA6Jf64oRMQVMWk/RfdkHirNwS0tmA+a2Am4kmzISW7Pz8AxwD/BpX4Ryw0RQycqEQmj4I4pJg7dspz1N0MbOU5PZ/cCj2jyxba4qTe5/NrQqdwhZ/lD7oJ8ha8sxNUtmKFC+SxaTGzjUWWbw4Mo3DEiNPiJWqXFwxZ103vl2QeJceqNyjoNFay8z9GeG+/Di/5qbT0uPsLIeGmjHmURnPy2YI42xeRChQBnXuTzPRv28By2lEO2uG8cG/w8G8+j9HFB20b8Dg0BGOaDtggrjpDe+bTKBGFRmWQGCqsYiIYluwSh1yyJFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yKjWOT91ELZ3AFMlzAN48gGYvtxVbHCyhlCmK41G5Nk=; b=UHNWILChrV+KmoZabuR329Ss/XMTMNVpT/XKFKFar3dAmA0KVzUrlnMRv14oxqHdahp1tpA1x9t1SqVlzlaCEt56CFy1ZM3xLXDuHUEqD6gm7xd4tVyb23nD2OftCYfBl2bQUxPjRX6ovnb5M/gxiADgce48HqzUFPDWDwjBX6M69Cpm/qON5iFwr6j7panps8LxhBq04wR3O8f9hUKS0KKqsZmzloJP23SlqmjaDfddI7UXf1xvhA1xz2EPc3WOvHAI+uP1LVtKk2HVt6N9jl2LZGHbqT+FIF2qftU8VQMd139i/uf+be6qH6BEU6JwFlCLV3gmnEVTZSPa84JUUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yKjWOT91ELZ3AFMlzAN48gGYvtxVbHCyhlCmK41G5Nk=; b=c6lp8iPMGVcnHHXn0lmu3VRNBa7qtJ3se/zNbKQOsqXLG5pw4m+hThFHwy4OSlRsXrXh0ECRfgPF5qW2eGDJH0J0v76mAZeLNz9uNdYury95eL+VO4epNwqmwUsJ1ysU2/mDNoNNQQlKrq2SSxDTRfwpPeyelZPxb2NT7yCQcIE= Received: from AS8PR08MB7080.eurprd08.prod.outlook.com (2603:10a6:20b:401::19) by VI1PR08MB3584.eurprd08.prod.outlook.com (2603:10a6:803:88::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Wed, 19 Jan 2022 09:44:33 +0000 Received: from AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::f9ab:bc8d:4319:666d]) by AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::f9ab:bc8d:4319:666d%8]) with mapi id 15.20.4888.014; Wed, 19 Jan 2022 09:44:33 +0000 From: Ruifeng Wang To: =?iso-8859-2?Q?Juraj_Linke=B9?= , "thomas@monjalon.net" CC: "dev@dpdk.org" , "stable@dpdk.org" , "viktorin@rehivetech.com" , "bruce.richardson@intel.com" , "stephen@networkplumber.org" , Honnappa Nagarahalli , nd , nd , nd Subject: RE: [PATCH] build: add missing arch define for Arm Thread-Topic: [PATCH] build: add missing arch define for Arm Thread-Index: AQHX8yPV6Qp377XxYkqvBUJxGOM/aKxhYOcAgAD6cLCABQYAAIAC50YA Date: Wed, 19 Jan 2022 09:44:33 +0000 Message-ID: References: <20211217085430.820773-1-ruifeng.wang@arm.com> <10596176.5MRjnR8RnV@thomas> <794237e109494b63b45ba2ceb1f4b8f0@pantheon.tech> In-Reply-To: <794237e109494b63b45ba2ceb1f4b8f0@pantheon.tech> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: AB91BD4B1754F547BB2A261D589EBFFA.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: f1e39398-d59e-4778-7230-08d9db30538d x-ms-traffictypediagnostic: VI1PR08MB3584:EE_|DB5EUR03FT005:EE_|AM9PR08MB7199:EE_ x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /DNZEW1BiR4LDBFwbaV8S3BTckzdNL2jxoOrVCyZh4CX7ErEk9Z5o7kOH9Bc5BeSi7Vv5n5QytKRRHyLYMQ4lvMD2Wik0ZDSXk1i56PXvFyQf8LtNauwte4sAwAFH4+joZE2hTPkfeUiT/tsOeKyCYrC2uuXuWD3a4eZOd7WAWbzIsg2Z5FDWpyRVEHGiJa/dx/iJ3cVmCG0HhMYCza4S2Kif9CHCzV4S0lRcdpJmejQgfpQDYsyT19lAbbe/51HhVD+zv43hP+WTVXz5L8FMTX1VoRZfjXDDrVKhclin5MjIZLuNerHmpo0Suz3bVjE8cPHyHhWZWlhMrSM9iAZbFGhyrd7a7QSPFMXE6OqiKYRmdhbG/BDfYUeMVmzRZ2ANL9rqBSb8T1ZTE+58ycwLolEc5nm9PmKOIVtAmIzMJR/48GAVjP6m3nN3P0BOx1UgtFo8iB4vqpyN8dSWYSCJUcjE4JHxVbMFQDtCAyVJa2CUGGZz+dneUrbFS6Bab2UDTTZXIEVzVoGQQtIflUQD4L4goyfSljprz9M0/TL31Qg2IuKkBsqL5TXH+2FRuRsbYZ+vZ4z8d+el+bFopjVUTb9kkzuOg7HE53jLgFVUjeFgTJVz+QB90YZHpo46Lut/TTDZlZuVHptJbL3PR2cXm9sU0CGdefCGfXVtnk3vJrJO80qEsEYUjdF5hco3JLA+3ejjtm3Q/44FLKvH+hq6A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB7080.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(9686003)(66946007)(316002)(83380400001)(52536014)(8936002)(8676002)(6506007)(4326008)(33656002)(7696005)(76116006)(186003)(66446008)(66556008)(64756008)(86362001)(66476007)(26005)(53546011)(122000001)(38070700005)(71200400001)(38100700002)(55016003)(2906002)(5660300002)(110136005)(508600001)(54906003); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3584 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e023bda4-7309-4a57-0005-08d9db304c77 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ef88ZglMlp7JorRoME1gwc3BW3+4Z0ujlBy1xGJbmqW7KStJQInC18ekVw2bzBFZD1ulHlwWQyNvXcPMBHF6XHg/TwHxapM8tiWbKWnCHyvvBnobXQaB1JZn9elI9cIOKbdYSWEF6Knd9obIIeMKxTyevFabsEJXvoJ8UPxH7QOuU+WAAedOFRBX62QAQGS/J3snV3lFRWp9fZOVrUkVO0QCpNV+6qJ2BEVzz2tgYtqk3gWfnpA+a20G44gWC1b9ejPt2uNPBNuUTzV3bHnGBLgFpG0TtLHsES4PJC1ix3tOLA+I5MktVu36r7DfuR0gCCr34+bpB+TD3BSGCPe4r+5y1BufzHGrNU5AkL7uEwt7UbHDTqjwq+gqNM7wwHte0J/ymk0CkgxWS1NLl2gaLg96v6ljt5Z8OTe+Nz/37hHshpaFuV09D/0xEzRZq9hy86hoKJtjP89/OIJiqJGAbMtW/mAFk2WcCzTVrZzkqRb7vsLuMCQhKlk691L/m1qgHq938mdEYIThMKOwNWA9bgFTy2HhXrwLgNvkwv4sYLQNxt6W4LPitpM2J006vQtE6h7S5f24RFBfIhpMy90ezziaogcvEejxSa/7i9vw+EotXHAqbJ7GFRciIDn9YLPzYI91zC/Z/TRO3pu62M2Vx2dGeYUIURqnddPUj51egqz291DtKM6gjMyt0ilHNrYGX7DIglFNDqESg8TQ33j0HNkvOZDb9Lr/YnpkRwdJ2gAeu+YN9iqur6wgrB1THE7NX06NKN/UpmnB5BGDEu/VwQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(40470700002)(52536014)(26005)(356005)(7696005)(336012)(81166007)(82310400004)(186003)(70586007)(4326008)(55016003)(5660300002)(40460700001)(8676002)(9686003)(6506007)(53546011)(8936002)(110136005)(36860700001)(54906003)(508600001)(33656002)(316002)(86362001)(2906002)(450100002)(47076005)(70206006)(83380400001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2022 09:44:45.6192 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f1e39398-d59e-4778-7230-08d9db30538d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7199 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Juraj Linke=B9 > Sent: Monday, January 17, 2022 9:12 PM > To: Ruifeng Wang ; thomas@monjalon.net > Cc: dev@dpdk.org; stable@dpdk.org; viktorin@rehivetech.com; > bruce.richardson@intel.com; stephen@networkplumber.org; Honnappa > Nagarahalli ; nd ; nd > > Subject: RE: [PATCH] build: add missing arch define for Arm >=20 >=20 >=20 > > -----Original Message----- > > From: Ruifeng Wang > > Sent: Friday, January 14, 2022 10:05 AM > > To: thomas@monjalon.net > > Cc: dev@dpdk.org; stable@dpdk.org; viktorin@rehivetech.com; > > bruce.richardson@intel.com; stephen@networkplumber.org; Juraj Linke=B9 > > ; Honnappa Nagarahalli > > ; nd ; nd > > Subject: RE: [PATCH] build: add missing arch define for Arm > > > > > -----Original Message----- > > > From: Thomas Monjalon > > > Sent: Friday, January 14, 2022 1:33 AM > > > To: Ruifeng Wang > > > Cc: dev@dpdk.org; stable@dpdk.org; viktorin@rehivetech.com; > > > bruce.richardson@intel.com; stephen@networkplumber.org; > > > juraj.linkes@pantheon.tech; Honnappa Nagarahalli > > > ; nd > > > Subject: Re: [PATCH] build: add missing arch define for Arm > > > > > > 17/12/2021 09:54, Ruifeng Wang: > > > > As per design document, RTE_ARCH is the name of the architecture. > > > > However, the definition was missing on Arm with meson build. > > > > It impacts applications that refers to this string. > > > > > > > > Added for Arm builds. > > > > > > > > Fixes: b1d48c41189a ("build: support ARM with meson") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Ruifeng Wang > > > > --- > > > > ['RTE_ARCH_ARMv8_AARCH32', true], > > > > + ['RTE_ARCH', 'arm64_aarch32'], > > > > > > Why not armv8_aarch32? > > > > Thanks for the comments. > > Agreed. armv8_aarch32 is consistent with the RTE_ARCH_xx macro above. > > > > > > > > [...] > > > > dpdk_conf.set('RTE_ARCH_ARMv7', true) > > > > + dpdk_conf.set('RTE_ARCH', 'armv7') > > > [...] > > > > # armv8 build > > > > + dpdk_conf.set('RTE_ARCH', 'arm64') > > > > > > Why not armv8? > > > > > > What I prefer the most in silicon industry is the naming craziness > > > :) > > > > While armv8 usually refers to one generation of the Arm architecture, > > arm64 is more generic for 64-bit architectures. > > And what defined for armv8 build is RTE_ARCH_ARM64. So for > > consistency, > > arm64 is better? > > >=20 > Using armv8_aarch32 along with arm64 doesn't seem right. We should unite Thanks for providing your thoughts. I have no strong opinion on this. armv8 indeed is better aligned with armv8= _aarch32. I will change in next version. > these and I think armv8 makes sense. As you mentioned arvm8 is an arm64 > architecture and using the more precise identification is better in my op= inion > (as that gives more information). As for the consistency with > RTE_ARCH_ARM64, I think the problem is that we don't have the > RTE_ARCH_ARMv8 flag (which would provide the consistency, but won't be > used): > The current code is, accurately, written for 64bit arm architectures (all= of > them). > There is currently no need to differentiate between 64bit arm architectur= es > which is why RTE_ARCH_ARMv8 doesn't exist. > However, armv8 exists and we know how to identify it which is why I think > setting RTE_ARCH to armv8 is the way to go. >=20 > So my thinking is RTE_ARCH should be set to armv8, which implies > RTE_ARCH_ARMv8 which in turn implies RTE_ARCH_ARM64. We're just > missing the middle part since there's no use for it now. >=20 > And to be fully consistent, we could add RTE_ARCH_ARM32 to armv7 (as a > superset of RTE_ARCH_ARMv7, but that likely won't be of much use).