From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0086.outbound.protection.outlook.com [104.47.2.86]) by dpdk.org (Postfix) with ESMTP id 547CA231E for ; Thu, 30 Aug 2018 02:28:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jS6OSxS2qbxG4JZCPP8ze931+hNZAKRhfaoPhI6RFPw=; b=SdabJD0RQzcD+zVEsraAkoI6cd9ur1/vTqULyWsQD4eHg71L+LfoICOCzt4EYFsgSw3bTftdgpTpXgT1DeLXbP+prHYSBzdBrDjxxv2OGhbK38CXQXuVZDZaYe9oprq6g39Tot4YLu5b5Kv2h8o5DvMwKAKHb4miUVHu+E0HmO4= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.17; Thu, 30 Aug 2018 00:28:34 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d45:8e84:6d63:c57c]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d45:8e84:6d63:c57c%2]) with mapi id 15.20.1080.015; Thu, 30 Aug 2018 00:28:34 +0000 From: Yongseok Koh To: Christian Ehrhardt CC: dpdk stable Thread-Topic: [PATCH 18.05] net/mlx5: fix GRE flow rule Thread-Index: AQHUCCWS7Jxs0iCtokqZeybJmbWG3KTX4HcA Date: Thu, 30 Aug 2018 00:28:33 +0000 Message-ID: References: <20180619233024.13553-1-yskoh@mellanox.com> In-Reply-To: <20180619233024.13553-1-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB3980; 6:JvCUoc0PfZivEgxfDJkPk2I3mq37fkND5eanFtqK7kHtQ19sEb3SHyBm/McH/hJg66cZQaUqJGJ43Py6v2mWyon72wW47EP0VIxiwDaemGXtmtcp63a4NhgNKgO9EaPaCTTs7nr85glRBchovv0EN9N6YWxXVhv6gqpVc7Mfr8enx9PPJAu756IOimvyrXA9QVyxsweiwz1cJufVR5fctExqr7O7mWX6pYj1ioJcyQyTxEde5hM2c8kFCDLV/psC6r2/Chw8Axf4SPjGHadxVtvd2GTZaOZENly5o9hAd1anu3Yr8DUpXc6mqLmqzM7+Sb/XHAyy9uqIv27np510JeiYtpLkcb5Npsr0OJyj68YvpG8uli9wIt9XYUZMe1ItmoXtTNLRJfmo0mgGmhXk1Ww+ozHIsD+pnLIY8KOYFb3ytSWKaQJFF9K05b4/xYf1oH5Md7AgflF90femIxEyXg==; 5:5qQo5Mq4s6Iv16mpgFZYFwudLzs24rIiHa6LgTG0UelRJHiLDtdxcUyTkIhIUj/3dgNc2yaBJw71QphVnogP2eAsczj39Fovm5RrxBXt48/oFmq12ahLbSGfHzEbons3KENbJ21Unk7HOE9wAn7IIxvfDfS9HS6rA2M82LgAbfI=; 7:N4DP71Iu56Q4CdlgwpIXT+o5V41rBzHbEJOHyeryJwxGZD+WO1RbUuccGpbrSUz0e6w9dpT4wf2UuJnieYlSY9xnrUpUJD50YdNA6QrOMznGvewwlQuA2K9BnMGaj+wgNnfxRR/YNE/Bi9bzq5Sw4AwXII0qknrrW9qEE72oToEroXbJDnoOYyINcrHA7UrAdAYCBAr3i3OO/DAqYSihVHmBOkMMerQYyMVoMw/8BXAA+ysHHIZzdpTIqI9t8lih x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 1821abbd-d89b-419f-b52f-08d60e0f851d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3980; x-ms-traffictypediagnostic: DB3PR0502MB3980: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201708071742011)(7699016); SRVR:DB3PR0502MB3980; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB3980; x-forefront-prvs: 07807C55DC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(136003)(396003)(39860400002)(376002)(366004)(199004)(189003)(82746002)(5660300001)(3846002)(53936002)(478600001)(6116002)(76176011)(33656002)(6512007)(229853002)(68736007)(8936002)(6916009)(99286004)(66066001)(2900100001)(97736004)(4326008)(6246003)(6436002)(25786009)(6506007)(105586002)(316002)(2906002)(5250100002)(476003)(2616005)(186003)(102836004)(6486002)(36756003)(81166006)(8676002)(446003)(256004)(11346002)(7736002)(486006)(575784001)(81156014)(305945005)(53546011)(14454004)(83716003)(106356001)(86362001)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3980; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: xbvMynObv4Gm7/uuFcT5GocN4YEMsQF07orH0waPBpiX8amJEzHuxfTXytRPO8Uc1clgMyv/dupbaOw70KO3/vaFJQpUdSsCmEzT5eovoi5eHhNX5qrHHPKa0R2OS4K/GM2my8j1qCdtxEK5UIOjIfgecke26eT+jPtO2qD/uQa8Hy3+fQxiqaIEnf1GP9rREFn9kZ2AXP6EP2jrAiS7c04IFqr98Nt0xcDio+/7DMqXHij9EhIJHCEipOEvkje34l+Zk5a7KO7uYuj6nKW5RVWN1KwnLGcZDRkcXFIGeRyvzuAm0xKm9ByqfAlfY2J3fBr8ANVlcaOWWWBtAuLxMYLejvEx3Z8lICIPUJfOHkg= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <321749425E830841A00B7ACC91750960@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1821abbd-d89b-419f-b52f-08d60e0f851d X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2018 00:28:33.8667 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3980 Subject: Re: [dpdk-stable] [PATCH 18.05] net/mlx5: fix GRE flow rule X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2018 00:28:35 -0000 Hi, Christian Can you please also include this patch? You might have missed it because it had been sent a while ago. Thanks, Yongseok > On Jun 19, 2018, at 4:30 PM, Yongseok Koh wrote: >=20 > Creating a flow having pattern from the middle of a packet is allowed. Fo= r > example, >=20 > testpmd> flow create 0 ingress pattern vxlan vni is 20 / end actions ... >=20 > Device can parse GRE protocol number in outer IP header but specifying fr= om > GRE header can't differentiate it from VxLAN tunnel. As a result, the > following rule will be interpreted as a wildcard rule, which always match= es > any packet. >=20 > testpmd> flow create 0 ingress pattern gre / end actions ... >=20 > Fixes: 96c6c65a10d2 ("net/mlx5: support GRE tunnel flow") > Fixes: 1f106da2bf7b ("net/mlx5: support MPLS-in-GRE and MPLS-in-UDP") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5_flow.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 994be05be..adb995f0d 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -331,8 +331,7 @@ static const struct mlx5_flow_items mlx5_flow_items[]= =3D { > [RTE_FLOW_ITEM_TYPE_END] =3D { > .items =3D ITEMS(RTE_FLOW_ITEM_TYPE_ETH, > RTE_FLOW_ITEM_TYPE_VXLAN, > - RTE_FLOW_ITEM_TYPE_VXLAN_GPE, > - RTE_FLOW_ITEM_TYPE_GRE), > + RTE_FLOW_ITEM_TYPE_VXLAN_GPE), > }, > [RTE_FLOW_ITEM_TYPE_ETH] =3D { > .items =3D ITEMS(RTE_FLOW_ITEM_TYPE_VLAN, > --=20 > 2.11.0 >=20