From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBFBBA04F6 for ; Fri, 6 Dec 2019 02:22:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 94A1B1BF88; Fri, 6 Dec 2019 02:22:05 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id ABC171BF78; Fri, 6 Dec 2019 02:22:01 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2019 17:22:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,282,1571727600"; d="scan'208";a="209323068" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga007.fm.intel.com with ESMTP; 05 Dec 2019 17:21:59 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 5 Dec 2019 17:21:59 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 5 Dec 2019 17:21:59 -0800 Received: from shsmsx106.ccr.corp.intel.com ([169.254.10.236]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.214]) with mapi id 14.03.0439.000; Fri, 6 Dec 2019 09:21:56 +0800 From: "Wang, Xiao W" To: Lu Qiuwen , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Shaw, Jeffrey B" , "stable@dpdk.org" Thread-Topic: [PATCH] net/fm10k: fix descriptor vlan field filling in Tx Thread-Index: AQHVq3A2WbmwKjM3bUWxfPqTUBK2D6esT+mQ Date: Fri, 6 Dec 2019 01:21:55 +0000 Message-ID: References: <20191205133008.4464-1-luqiuwen@iie.ac.cn> In-Reply-To: <20191205133008.4464-1-luqiuwen@iie.ac.cn> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzVmODI4NzYtYTRhZi00YzViLWIyMGMtZGQ2ZmUxODJhZDlhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSHN2eUtYbktRMEJ0TTNSNnVWYm9EcmlHNStmRW5zZVFtN21BbzdMMTlBUDd3SEhOandtUlo5UGtLSlJoS2p6dCJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] net/fm10k: fix descriptor vlan field filling in Tx X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Lu Qiuwen > Sent: Thursday, December 5, 2019 9:30 PM > To: Zhang, Qi Z ; Wang, Xiao W > > Cc: dev@dpdk.org; Shaw, Jeffrey B ; > stable@dpdk.org > Subject: [PATCH] net/fm10k: fix descriptor vlan field filling in Tx >=20 > The VLAN field in the descriptor is not filled when ol_flags has > no VLAN flag. When the caller sends some packets with VLAN tags, > but other packets do not have VLAN tags, the behavior of the program > cannot be determined. >=20 > Fixes: 4b61d3bfa941 ("fm10k: add receive and tranmit") > Cc: jeffrey.b.shaw@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Lu Qiuwen > --- > drivers/net/fm10k/fm10k_rxtx.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/fm10k/fm10k_rxtx.c b/drivers/net/fm10k/fm10k_rxt= x.c > index 5c3112183..4accaa2cd 100644 > --- a/drivers/net/fm10k/fm10k_rxtx.c > +++ b/drivers/net/fm10k/fm10k_rxtx.c > @@ -611,6 +611,8 @@ static inline void tx_xmit_pkt(struct fm10k_tx_queue = *q, > struct rte_mbuf *mb) > /* set vlan if requested */ > if (mb->ol_flags & PKT_TX_VLAN_PKT) > q->hw_ring[q->next_free].vlan =3D mb->vlan_tci; > + else > + q->hw_ring[q->next_free].vlan =3D 0; >=20 > q->sw_ring[q->next_free] =3D mb; > q->hw_ring[q->next_free].buffer_addr =3D > -- > 2.20.1.windows.1 Acked-by: Xiao Wang