From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C18CC199A9; Thu, 7 Sep 2017 11:31:21 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 07 Sep 2017 02:31:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,357,1500966000"; d="scan'208";a="149171458" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 07 Sep 2017 02:31:20 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 7 Sep 2017 02:31:20 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 7 Sep 2017 02:31:20 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.168]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Thu, 7 Sep 2017 17:31:18 +0800 From: "Li, Xiaoyun" To: "Richardson, Bruce" CC: "dev@dpdk.org" , "Zhang, Helin" , "stable@dpdk.org" Thread-Topic: [PATCH] mk: fix compiling error for atom target Thread-Index: AQHTJ7Ro9qUlKh8bRkes3279h/jBE6KomOsAgACN1CA= Date: Thu, 7 Sep 2017 09:31:17 +0000 Message-ID: References: <1504773317-2042-1-git-send-email-xiaoyun.li@intel.com> <20170907085640.GA24764@bricha3-MOBL3.ger.corp.intel.com> In-Reply-To: <20170907085640.GA24764@bricha3-MOBL3.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] mk: fix compiling error for atom target X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2017 09:31:22 -0000 Hi So I should delete the mk/machine/atm folder and add a new mk/machine/silve= rmont folder, right? And in silvermont/rte.vars.mk, there is sentence " MACHINE_CFLAGS =3D -marc= h=3Dsilvermont ". The annotation just adds the copy of others like original atm? Another thing, we don't need to create the config file (defconfig_x86_64-si= lvermont-linuxapp-gcc), right? Best Regards Xiaoyun Li -----Original Message----- From: Richardson, Bruce=20 Sent: Thursday, September 7, 2017 16:57 To: Li, Xiaoyun Cc: dev@dpdk.org; Zhang, Helin ; stable@dpdk.org Subject: Re: [PATCH] mk: fix compiling error for atom target On Thu, Sep 07, 2017 at 04:35:17PM +0800, Xiaoyun Li wrote: > GCC thinks target atom doesn't support SSE4.2 and SSE4 is now part of=20 > minimum requirements for DPDK on x86. So there are compiling errors=20 > when cross-compiling for target atom. And in fact, the atom supports SSE4= now. > This patch fixes this issue. >=20 > Fixes: 5ea4d4688dce ("net/ixgbe: remove fallback code for x86=20 > non-SSE4") > Cc: stable@dpdk.org >=20 > Signed-off-by: Xiaoyun Li The -march=3Datom flag is for older atom CPUs, and is no longer advertised = by gcc, since all -march flags now correspond to the actual core microarchi= tecture used. [man gcc on Fedora 26, no longer lists atom as a valid march = value, though it's probably still accepted for backward compatibility]. The= direct replacement for atom is "bonnell", which does not have SSE4.2 suppo= rt, so we should not use. What we do support is later atoms, so the archite= cture targets for atom should be "-march=3Dsilvermont". This automatically = includes sse4 support so no additional flags needed. Note: I previously had this discussion with Neil on-list, but forgot to do = the follow-up work agreed on. See:=20 https://www.mail-archive.com/dev@dpdk.org/msg72629.html The agreed plan was to remove atom as a target for DPDK builds and add a "s= ilvermont" replacement instead. If you have time, perhaps you could look at= doing that instead of this fix? /Bruce > --- > mk/machine/atm/rte.vars.mk | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/mk/machine/atm/rte.vars.mk b/mk/machine/atm/rte.vars.mk=20 > index cfed110..a6899d9 100644 > --- a/mk/machine/atm/rte.vars.mk > +++ b/mk/machine/atm/rte.vars.mk > @@ -56,3 +56,5 @@ > # CPU_ASFLAGS =3D > =20 > MACHINE_CFLAGS =3D -march=3Datom > + > +MACHINE_CFLAGS +=3D -msse4.2 > -- > 2.7.4 >=20