From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8A029A00E6 for ; Fri, 17 May 2019 07:49:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 42C922BB8; Fri, 17 May 2019 07:49:55 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 96B072BB8 for ; Fri, 17 May 2019 07:49:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 May 2019 22:49:52 -0700 X-ExtLoop1: 1 Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga006.jf.intel.com with ESMTP; 16 May 2019 22:49:52 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 16 May 2019 22:49:51 -0700 Received: from cdsmsx103.ccr.corp.intel.com (172.17.3.37) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 16 May 2019 22:49:51 -0700 Received: from cdsmsx104.ccr.corp.intel.com ([169.254.4.124]) by CDSMSX103.ccr.corp.intel.com ([169.254.5.59]) with mapi id 14.03.0415.000; Fri, 17 May 2019 13:49:49 +0800 From: "Zhang, Tianfei" To: "Xu, Rosen" CC: "Pei, Andy" , "stable@dpdk.org" Thread-Topic: [PATCH] raw/ifpga: fix logically dead code Thread-Index: AQHVDGIV9Q2WF1Axs0CeIj2GQkS4R6ZuN0EAgACX9OA= Date: Fri, 17 May 2019 05:49:48 +0000 Message-ID: References: <20190517112516.28667-1-tianfei.zhang@intel.com> <0E78D399C70DA940A335608C6ED296D73A753123@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <0E78D399C70DA940A335608C6ED296D73A753123@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDQ5MDQ4ODYtNDI1ZS00MGQwLTkyNTgtOGQ2OGRhNTAzMzVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJQZmh3STZhTjI5ZlpXclQ5VmFOUUxodld2QUp4ZWdUZzlrQm9WTlo3TEY4RlVseG5uM1p6YUNsVkFFYjIzWEJYIn0= x-ctpclassification: CTP_NT x-originating-ip: [172.17.6.105] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] raw/ifpga: fix logically dead code X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Xu, Rosen > Sent: Friday, May 17, 2019 12:43 PM > To: Zhang, Tianfei > Cc: Pei, Andy ; stable@dpdk.org > Subject: RE: [PATCH] raw/ifpga: fix logically dead code >=20 > Hi Tianfei, >=20 > > -----Original Message----- > > From: Zhang, Tianfei > > Sent: Friday, May 17, 2019 19:25 > > To: Xu, Rosen > > Cc: Pei, Andy ; Zhang, Tianfei > > ; stable@dpdk.org; Zhang > > Subject: [PATCH] raw/ifpga: fix logically dead code > > > > add temporary variable in max10_reg_write(). > > > > Coverity issue: 337927 > > Cc: stable@dpdk.org > > > > Signed-off-by: Zhang, Tianfei > > --- > > drivers/raw/ifpga_rawdev/base/opae_intel_max10.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c > > b/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c > > index f354ee4b6..3ff6575d7 100644 > > --- a/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c > > +++ b/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c > > @@ -17,11 +17,13 @@ int max10_reg_read(unsigned int reg, unsigned int > > *val) > > > > int max10_reg_write(unsigned int reg, unsigned int val) { >=20 > If you don't need to modify val, why use const? I don't think it is necessary to use const for val, val is quiet simple and= no one will modify it. >=20 > > + unsigned int tmp =3D val; > > + > > if (!g_max10) > > return -ENODEV; > > > > return spi_transaction_write(g_max10->spi_tran_dev, > > - reg, 4, (unsigned char *)&val); > > + reg, 4, (unsigned char *)&tmp); > > } > > > > struct intel_max10_device * > > @@ -57,7 +59,7 @@ intel_max10_device_probe(struct altera_spi_device > > *spi, > > > > /* set PKVL Polling manually in BBS */ > > ret =3D max10_reg_write(PKVL_POLLING_CTRL, 0x3); > > - if (ret) { > > + if (ret !=3D 0) { > > dev_err(dev, "%s set PKVL polling fail\n", __func__); > > goto spi_tran_fail; > > } > > -- > > 2.17.1