From: "Fischetti, Antonio" <antonio.fischetti@intel.com>
To: "Fischetti, Antonio" <antonio.fischetti@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
"Bie, Tiwei" <tiwei.bie@intel.com>,
"yliu@fridaylinux.org" <yliu@fridaylinux.org>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 1/5] net/virtio: fix vector Rx break caused by rxq flushing
Date: Thu, 7 Dec 2017 18:10:24 +0000 [thread overview]
Message-ID: <BCFD2BB875535045A5368D9ADBF296993506285E@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <BCFD2BB875535045A5368D9ADBF2969935062284@IRSMSX101.ger.corp.intel.com>
Hi Tiwei,
I've tested this patch on my 2 test cases described
in the previous threads
http://www.dpdk.org/ml/archives/dev/2017-November/081839.html
http://www.dpdk.org/ml/archives/dev/2017-December/082801.html
1. testpmd on the host and testpmd in the guest
2. OvS-DPDK on the host and testpmd in the guest
and it works fine.
I'm using DPDK v17.11 + this patch and I see traffic is now
flowing through the VM.
Tested-by: Antonio Fischetti <antonio.fischetti@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fischetti, Antonio
> Sent: Thursday, December 7, 2017 9:30 AM
> To: Maxime Coquelin <maxime.coquelin@redhat.com>; Bie, Tiwei
> <tiwei.bie@intel.com>; yliu@fridaylinux.org; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/5] net/virtio: fix vector Rx break
> caused by rxq flushing
>
> Thanks Tiwei for working on this, I'll give it a try soon.
>
> Antonio
>
> > -----Original Message-----
> > From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> > Sent: Thursday, December 7, 2017 9:15 AM
> > To: Bie, Tiwei <tiwei.bie@intel.com>; yliu@fridaylinux.org;
> dev@dpdk.org
> > Cc: Fischetti, Antonio <antonio.fischetti@intel.com>; stable@dpdk.org
> > Subject: Re: [PATCH 1/5] net/virtio: fix vector Rx break caused by rxq
> > flushing
> >
> >
> >
> > On 12/07/2017 06:30 AM, Tiwei Bie wrote:
> > > The vector Rx will be broken if backend has consumed all
> > > the descs in the avail ring before the device is started.
> > > Because in current implementation, vector Rx will return
> > > immediately without refilling the avail ring if the used
> > > ring is empty. So we have to refill the avail ring after
> > > flushing the elements in the used ring for vector Rx.
> > >
> > > Besides, vector Rx has a different ring layout assumption
> > > and mbuf management. So we need to handle it differently.
> > >
> > > Fixes: d8227497ec5c ("net/virtio: flush Rx queues on start")
> > > Cc: stable@dpdk.org
> > >
> > > Reported-by: Antonio Fischetti <antonio.fischetti@intel.com>
> > > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > > ---
> > > drivers/net/virtio/virtio_ethdev.c | 2 +-
> > > drivers/net/virtio/virtqueue.c | 31 ++++++++++++++++++++++++--
> --
> > ---
> > > drivers/net/virtio/virtqueue.h | 2 +-
> > > 3 files changed, 26 insertions(+), 9 deletions(-)
> >
> > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> >
> > Thanks,
> > Maxime
next prev parent reply other threads:[~2017-12-07 18:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171207053059.19487-1-tiwei.bie@intel.com>
2017-12-07 5:30 ` Tiwei Bie
2017-12-07 9:14 ` Maxime Coquelin
2017-12-07 9:30 ` Fischetti, Antonio
2017-12-07 18:10 ` Fischetti, Antonio [this message]
2017-12-07 16:00 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor
2017-12-08 2:30 ` Tiwei Bie
2017-12-08 10:17 ` Kevin Traynor
2017-12-07 5:30 ` [dpdk-stable] [PATCH 2/5] net/virtio: fix typo in LRO support Tiwei Bie
2017-12-07 9:15 ` Maxime Coquelin
[not found] ` <20171211051332.31888-1-tiwei.bie@intel.com>
2017-12-11 5:13 ` [dpdk-stable] [PATCH v2 1/4] net/virtio: fix vector Rx break caused by rxq flushing Tiwei Bie
2017-12-11 5:13 ` [dpdk-stable] [PATCH v2 2/4] net/virtio: fix typo in LRO support Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BCFD2BB875535045A5368D9ADBF296993506285E@IRSMSX101.ger.corp.intel.com \
--to=antonio.fischetti@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).