From: Yongseok Koh <yskoh@mellanox.com>
To: Shahed Shaikh <shshaikh@marvell.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"rmody@marvell.com" <rmody@marvell.com>,
"GR-Everest-DPDK-Dev@marvell.com"
<GR-Everest-DPDK-Dev@marvell.com>
Subject: Re: [dpdk-stable] [PATCH 17.11] net/qede: fix Tx packet prepare for tunnel packets
Date: Mon, 12 Aug 2019 18:47:06 +0000 [thread overview]
Message-ID: <BF2582C3-3258-4268-8A14-5BCD5001699F@mellanox.com> (raw)
In-Reply-To: <20190809083402.28603-1-shshaikh@marvell.com>
> On Aug 9, 2019, at 1:34 AM, Shahed Shaikh <shshaikh@marvell.com> wrote:
>
> [ backported from upstream commit 60f9a634578320e344d25be789afc7b462450201 ]
> This patch fixes a regression introduced by
> commit 49d3978d5723 ("net/qede: fix Tx tunnel offload support mask")
> in which qede_xmit_prep_pkts() breaks the loop for successful
> check of Tunneling offload flags instead of continuing, resulting
> in tx_pkt_prepare return a failure.
>
> Fixes: 49d3978d5723 ("net/qede: fix Tx tunnel offload support mask")
>
> Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
> ---
applied to stable/17.11
thanks,
Yongseok
> drivers/net/qede/qede_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c
> index 3a2b304..358a8ef 100644
> --- a/drivers/net/qede/qede_rxtx.c
> +++ b/drivers/net/qede/qede_rxtx.c
> @@ -1821,7 +1821,7 @@ qede_xmit_prep_pkts(__rte_unused void *p_txq, struct rte_mbuf **tx_pkts,
> temp = ol_flags & PKT_TX_TUNNEL_MASK;
> if (temp == PKT_TX_TUNNEL_VXLAN ||
> temp == PKT_TX_TUNNEL_MPLSINUDP)
> - break;
> + continue;
> }
>
> rte_errno = -ENOTSUP;
> --
> 2.7.4
prev parent reply other threads:[~2019-08-12 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 8:34 Shahed Shaikh
2019-08-12 18:47 ` Yongseok Koh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BF2582C3-3258-4268-8A14-5BCD5001699F@mellanox.com \
--to=yskoh@mellanox.com \
--cc=GR-Everest-DPDK-Dev@marvell.com \
--cc=rmody@marvell.com \
--cc=shshaikh@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).