patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH 17.11] net/qede: fix Tx packet prepare for tunnel packets
@ 2019-08-09  8:34 Shahed Shaikh
  2019-08-12 18:47 ` Yongseok Koh
  0 siblings, 1 reply; 2+ messages in thread
From: Shahed Shaikh @ 2019-08-09  8:34 UTC (permalink / raw)
  To: stable; +Cc: rmody, GR-Everest-DPDK-Dev

[ backported from upstream commit 60f9a634578320e344d25be789afc7b462450201 ]
This patch fixes a regression introduced by
commit 49d3978d5723 ("net/qede: fix Tx tunnel offload support mask")
in which qede_xmit_prep_pkts() breaks the loop for successful
check of Tunneling offload flags instead of continuing, resulting
in tx_pkt_prepare return a failure.

Fixes: 49d3978d5723 ("net/qede: fix Tx tunnel offload support mask")

Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
---
 drivers/net/qede/qede_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c
index 3a2b304..358a8ef 100644
--- a/drivers/net/qede/qede_rxtx.c
+++ b/drivers/net/qede/qede_rxtx.c
@@ -1821,7 +1821,7 @@ qede_xmit_prep_pkts(__rte_unused void *p_txq, struct rte_mbuf **tx_pkts,
 				temp = ol_flags & PKT_TX_TUNNEL_MASK;
 				if (temp == PKT_TX_TUNNEL_VXLAN ||
 				    temp == PKT_TX_TUNNEL_MPLSINUDP)
-					break;
+					continue;
 			}
 
 			rte_errno = -ENOTSUP;
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [PATCH 17.11] net/qede: fix Tx packet prepare for tunnel packets
  2019-08-09  8:34 [dpdk-stable] [PATCH 17.11] net/qede: fix Tx packet prepare for tunnel packets Shahed Shaikh
@ 2019-08-12 18:47 ` Yongseok Koh
  0 siblings, 0 replies; 2+ messages in thread
From: Yongseok Koh @ 2019-08-12 18:47 UTC (permalink / raw)
  To: Shahed Shaikh; +Cc: stable, rmody, GR-Everest-DPDK-Dev


> On Aug 9, 2019, at 1:34 AM, Shahed Shaikh <shshaikh@marvell.com> wrote:
> 
> [ backported from upstream commit 60f9a634578320e344d25be789afc7b462450201 ]
> This patch fixes a regression introduced by
> commit 49d3978d5723 ("net/qede: fix Tx tunnel offload support mask")
> in which qede_xmit_prep_pkts() breaks the loop for successful
> check of Tunneling offload flags instead of continuing, resulting
> in tx_pkt_prepare return a failure.
> 
> Fixes: 49d3978d5723 ("net/qede: fix Tx tunnel offload support mask")
> 
> Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
> ---

applied to stable/17.11

thanks,
Yongseok

> drivers/net/qede/qede_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c
> index 3a2b304..358a8ef 100644
> --- a/drivers/net/qede/qede_rxtx.c
> +++ b/drivers/net/qede/qede_rxtx.c
> @@ -1821,7 +1821,7 @@ qede_xmit_prep_pkts(__rte_unused void *p_txq, struct rte_mbuf **tx_pkts,
> 				temp = ol_flags & PKT_TX_TUNNEL_MASK;
> 				if (temp == PKT_TX_TUNNEL_VXLAN ||
> 				    temp == PKT_TX_TUNNEL_MPLSINUDP)
> -					break;
> +					continue;
> 			}
> 
> 			rte_errno = -ENOTSUP;
> -- 
> 2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-09  8:34 [dpdk-stable] [PATCH 17.11] net/qede: fix Tx packet prepare for tunnel packets Shahed Shaikh
2019-08-12 18:47 ` Yongseok Koh

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox