From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBC8EA0C43 for ; Mon, 16 Aug 2021 17:21:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD1344114C; Mon, 16 Aug 2021 17:21:54 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id EE3074003C; Mon, 16 Aug 2021 17:21:51 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10078"; a="301463097" X-IronPort-AV: E=Sophos;i="5.84,326,1620716400"; d="scan'208";a="301463097" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2021 08:21:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,326,1620716400"; d="scan'208";a="675624086" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 16 Aug 2021 08:21:50 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 16 Aug 2021 08:21:50 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 16 Aug 2021 08:21:49 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 16 Aug 2021 08:21:49 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 16 Aug 2021 08:21:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T+EboI/Wq0l35e0znGzx3sjIajP8LPqeHFUw987th4g3cDQCov7L1Q5UNkbkN7ToCqeKjv7NmF/8cHwtV3NiGeywd5CoW/tdQbWRzUaFJD1/G7hcze3cJlMHDzJgeK/um5ZEtPc0Un3QMc2ZoNDDYfo+lz39eM5UEM/KVKslLK29fO8SK+BH9sBMW+k1xEt1RH9VUtvN7HxeOVfVahxvgO1PszNKLpwyMwp+h/1HLYjsgPwKhfhY433Fr3O014tQnxTIwJRF/2SLzJf9JpD5zIfCPN/29HT5z8ESg5ZncS4zilHccAGVCZm1TI2Ahmom8Hb/nBguufe6Yy2VrqQQfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PSQDuiSIWHOUFfoEdQFEX8q7Kqht3GVxqx6d/B+WXYQ=; b=kT8JJlugY5KUqf95OAtMcrCxCk+xzvil3ekD/A0zp2qdWrqGmAehvTSl9dvKqRzT6XuAnygy/vny5QRLjis0Z3eUd8ysHFo9mnBps1v0xFdmU2C0Q7cfvFdQ9VRFPsCvr72Y6IV2ihnzmgzcAEfl7Dj6sr7p0Nop6dexaHNGCv+J1kATusmzHsoeDDuNeE/mrLcha8uShoswsXEKhEVBXtON1coYpj6VSKBVLAAoUXC0QvKk+pI+E4Awm04Bto0FXmBpGy3txexJfksArWYMF7Y0n14C9GUK4y205JvcnNSa+al+y3LXS8I0ihuwQM/BXnx031h3RMILrMNbNI3LrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PSQDuiSIWHOUFfoEdQFEX8q7Kqht3GVxqx6d/B+WXYQ=; b=osZWlCxba/2wu2eVXG21NRIlnjKhFXhK9JoIq7jwchbpfO7TJ68MI0O59XxB6Hd5UH+ok6Tc53IdOqMd4Ot83UmF5AKWIeMdFMOWJPfEtw5fNVFNzHfzjP1gcUuxKGt9HsgNFyVEhW//N2yPSG+Yt5Z/+27+VYQ7/3nb+0Jy8A0= Received: from BL0PR11MB3043.namprd11.prod.outlook.com (2603:10b6:208:33::19) by MN2PR11MB4760.namprd11.prod.outlook.com (2603:10b6:208:266::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.17; Mon, 16 Aug 2021 15:21:47 +0000 Received: from BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::3048:2055:b488:129f]) by BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::3048:2055:b488:129f%5]) with mapi id 15.20.4415.023; Mon, 16 Aug 2021 15:21:47 +0000 From: "Zhang, Roy Fan" To: "Power, Ciara" , "dev@dpdk.org" CC: "stable@dpdk.org" , "damianx.nowak@intel.com" , "Kovacevic, Marko" Thread-Topic: [PATCH v1 1/2] examples/fips_validation: fix unused malloc Thread-Index: AQHXj4XPCyBTkTxBtU6s5CIvIo3sU6t2RbBA Date: Mon, 16 Aug 2021 15:21:46 +0000 Message-ID: References: <20210812142436.108053-1-ciara.power@intel.com> <20210812142436.108053-2-ciara.power@intel.com> In-Reply-To: <20210812142436.108053-2-ciara.power@intel.com> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.0.76 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 64086829-196f-44b1-2f2b-08d960c98fff x-ms-traffictypediagnostic: MN2PR11MB4760: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wgcSDnF+YvvkOGVhaOr/cndAcWMKLf8F9OtE1/us+mp++yoq8pPP0umGqx4vNOqf/YojOyQighko8T/L2divpxZN+cS3/FYbHjs3AtwVdlFj3i0XV7H/KmD5+Y8RFJrz6vvAWiIWEuwF6B70SznSx/3NudePFD0+InmFgpX5RKMmCETc0MOogQfIkKlwiT9ZrrrQQg+vL/qKu2rK/2DPAnowHHXUbxQ8Vwz8D81Eqyxc9hfpnJSnrJTYfzrD+emgmHIVOAFzT+DEhC8yPOncr07DtPYJ9kGzQfh3p1G6Vwa/LUh0ZA0hqyl15KL+eu3+Se2/nsKruM/aVlfoywvIYofR+DcIypPGGI00nl/4d+Qp9NlgwsNGMj+ZOQa+51PAP8veNPAEsgcCaMk0V1PbSoq1axFajaEk4f8zQdTB72IDJgYumyUytVYFh6bW2GeMdGyI5SrGE24C3EeH6kszxDMkKrqbkyD7ukppLfHqxMyineCVE8H1MHQS1dGjSQFrjFDJCOE3nqx+dGYnup81KJA5pH1pfgvi0AvU5VpQKmDELThN13MPthsxNxngVJ+HlD5JjzEyabrVcElbvWLcVT3cd4z6d/yoDgoZDVfqteCTqOo2TVqYoHt1IkB9G+S4ZqoDG4HazWx02ypd/r5swQToTOMKTYVKhYgMAFIdZh3foU5jusMVGoUz2lemKZ7lfWJmfjCWXfmUlU/d10/k0w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3043.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(366004)(346002)(376002)(136003)(53546011)(5660300002)(52536014)(6506007)(26005)(186003)(55016002)(478600001)(38070700005)(7696005)(122000001)(64756008)(9686003)(66476007)(66946007)(66556008)(76116006)(316002)(110136005)(54906003)(66446008)(86362001)(4326008)(450100002)(107886003)(83380400001)(2906002)(8676002)(8936002)(33656002)(38100700002)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?0WkpuGACNxzEIGI7l2vNGBRQaUenm5vxYj/woUugPwrruhYYJWuMqNba?= =?Windows-1252?Q?e6+FthnpSdCuO4MPaZzyC2g40BJkU2XNrfr48WKQFdhVu5qUiIZayu5r?= =?Windows-1252?Q?uKq9W02hIfGKTA61mhNislJO/T3jOCntoLmMYO6QtpmUx1yGhhZjg7BE?= =?Windows-1252?Q?aOrVtMAxRNLsVx3/dS2qbd8rPfhP+8DuyLpL+wf2C8dXB6UDxQ3SYlTj?= =?Windows-1252?Q?gUyAAH4BclYX9OpIHyg/MgKUUpYLBeIzpGZa/hSxZUDRNAvVUtURidoS?= =?Windows-1252?Q?/K+vmMJXDur8IZmToAxA/MfOybImPifdriFwRfP3jKSKSkchrd+6YDRm?= =?Windows-1252?Q?xz6jYVt4x5qDnjzicOKJ5Ml2XJ/A91r5wGU34Wr76nb+CDh5iGDpWzQK?= =?Windows-1252?Q?Pkobs9x3hLVhHRab7IvPrvvWki9LbDLnDUArE7jXWHjPCKcJBuAmorqx?= =?Windows-1252?Q?mOKirnO8PxQ7ak4xNhdWnQdSDuqJ7ApJMZXZr+RiXr3qhm3ihwLKfCRU?= =?Windows-1252?Q?KMvdSAVjA3Zx6UiAPcNZ4EInbiCrkTTQNK9oNKMOr/Gr4fQRL1zYpCvP?= =?Windows-1252?Q?LlCbvAftbnDphzr7dMBfKvFbL4VB1RtqhuGY8/qYu9ymQxzt6My7nDj/?= =?Windows-1252?Q?J7X7g5WwLRbW4A/QiW1PI9LHPjXp5r2U1LEkbypbxIjCkjCHlHnPGONN?= =?Windows-1252?Q?oUgvVf69Cu3gVwEGf5yW8vd9R4HZMn5UvFoTWYl/viIlUJEKS7Imiwf6?= =?Windows-1252?Q?iJy/4/C1GUE7gTjz0jgRrZjiaAS542lMrKm2hlPMzClfy6R41AldRBjf?= =?Windows-1252?Q?aT8+vUywHE7d1D9nyDyKyu7gKsdvHUM5FoViYKZ1IOsaZFiAaGG1pCvs?= =?Windows-1252?Q?J3UoBX9dYVR6XvWJRX3o0YzRh89eQIiFVeXCKBcAB/q+J5Hj9QGk5xML?= =?Windows-1252?Q?/GTta4SK9olTIbk51SHHfFAOM/KSKZAl5PuwPFGs3jLPH57PA1OQWpZR?= =?Windows-1252?Q?8ZDIsSBXndYxqFvuDs7zibWVU7sVVWe1nbLvWa7EPGdOjxB2Uhqk2Vmx?= =?Windows-1252?Q?1FyrGMCP2ZUl5lH0BWjeQu0ePQNe1D6LKJsBOTk+Bx70D/eHFjvFEuqe?= =?Windows-1252?Q?qa4gZGE8QkIK9FN6nByvfZOpG1fRBG4XAWkb4xDv14CZLbMSIFOtgLfz?= =?Windows-1252?Q?YR/cwT6xT7YXO6a4io6XGpyg+hbcqvm+lq0/8F2FFOFO81cEFE7Ylc7+?= =?Windows-1252?Q?TzJ9FjZeloHcKOgXI7LQu1xr3hc8h77TcrL/yeX9PCUO66KC1qNOnxZB?= =?Windows-1252?Q?hzv4aAXUtvOkGbVYQRqql8/kZLObp0xTMgHtz250SAYP8++D2RDc9/bL?= =?Windows-1252?Q?72rme0hOHKeN+8n9x6VAiHOcUtx3FGg8GwA=3D?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3043.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64086829-196f-44b1-2f2b-08d960c98fff X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2021 15:21:46.9804 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B4baNey0dii8d/SK4KN7kvYdocYS0TJT8IYHcvXnLbCB0V9aWSzcR0akuMptFzgenbVU5r7u6ImJymUrH2hOAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4760 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v1 1/2] examples/fips_validation: fix unused malloc X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Power, Ciara > Sent: Thursday, August 12, 2021 3:25 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Zhang, Roy Fan ; Power, > Ciara ; damianx.nowak@intel.com; Kovacevic, > Marko > Subject: [PATCH v1 1/2] examples/fips_validation: fix unused malloc >=20 > The val.val pointer is allocated memory, however this memory is then > freed in get_writeback_data() without being used beforehand. > The pointer is then allocated memory again before use, > so the very first allocation is removed as it was unnecessary. >=20 > Fixes: f4797bae0050 ("examples/fips_validation: support plain SHA") > Cc: damianx.nowak@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Ciara Power > --- > examples/fips_validation/main.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/examples/fips_validation/main.c > b/examples/fips_validation/main.c > index c175fe6ac2..2db00620ce 100644 > --- a/examples/fips_validation/main.c > +++ b/examples/fips_validation/main.c > @@ -1635,7 +1635,6 @@ fips_mct_sha_test(void) > int ret; > uint32_t i, j; >=20 > - val.val =3D rte_malloc(NULL, (MAX_DIGEST_SIZE*SHA_MD_BLOCK), 0); > for (i =3D 0; i < SHA_MD_BLOCK; i++) > md[i].val =3D rte_malloc(NULL, (MAX_DIGEST_SIZE*2), 0); >=20 > -- > 2.25.1 Acked-by: Fan Zhang