From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEAB4A00C5 for ; Sun, 3 Jul 2022 11:46:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E723F40685; Sun, 3 Jul 2022 11:46:39 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2071.outbound.protection.outlook.com [40.107.96.71]) by mails.dpdk.org (Postfix) with ESMTP id A1E0E40685; Sun, 3 Jul 2022 11:46:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MkY6+iHupljVLUWd84ilctO+lfbT5+w+rY7aGEquH0GxSOqBbG6lZzHefVGdxHMqWaOGA4g3FbgG5R1rSAPy/5DVay5jIvnizgkeWEnTVWgP32rsrooQmwKG7aIHbrSHWbpMpzhJgMg5PubNgFdujq5O/hB1X4n9BRisCMwwMMQ2GXgxV1TimWnNgAKj/AJOP2AR4p7r+uKTgFX5XoYl5g7q0haYspMdJdMSE72m3M+gr7XXthdVPYpxJkqL0UdE7g0j2sG7QLOYOyTse2oqP2qJiJGgdwNixQlgREEsBSItXfo/QXW5FSi5BH1uD6QQ7ITxau5GcDUrPrTeIiuRsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3bATvFD2m7dD5NXozmh+D8bYv4Kw9KihFRjA5Rh59MI=; b=GoPeqglOFuLSj7a+WJAIETIFLsM8JJJWg4266aSGUIbJS1qlK7UUB9vDOn5PJFTASzCy0YaBEwwnyYZlSqqukdKe16sLsL2sT4aICGcx3H9phzXZyq9kdHOMlIX+RBobMKYSdEw7tLY9pevEXxDsAo+b7zXuN2cLsaBg09r9jzpTc4pNUa9kePjftOjz9sHsBMNYf6M1eXxugleOEjX0ctVK9CqDw60TBVOSABFTjIbV2f96P/rUDu24c6ke7TbDublBMkqJ5wMT6Rgo4M9bNBK9mWfqbriTBkFWLpKnBd25JF3zmYxJrKjgNJAOMcBrO7FP9iIRuiH3XgxCa3bmjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3bATvFD2m7dD5NXozmh+D8bYv4Kw9KihFRjA5Rh59MI=; b=T99U5HfzzbcuM3fJLrDDHSHdz6u6zNovoyAU5VyIlohcLePSv5wq3xXK/kPQekDLVqjCdzzTNAVif773Jtlgg5v8oES1ayJGpWz3PRqw2EQREa7uRdDOdpeq1m4UzP4oivawIeFCbwp76gj6RJnkR+6+6VG4yuFXioSwmXbzpkWuXKg7SylJXnDuCiIpHPEmcwBEBIC4bvlAkpHghUMUV36ntN4Av6fKdnhLTo6BkS+46Q1ap5TbZcFsrHcybTgAGWu5KTfVDV5QWpmqwB8V26Ed0jw/iF4vWPmzsxxhp9ILnMGkwEsKg1FTIb1fdMPeW74mckobbpR+p+ntWMd/jQ== Received: from BL1PR12MB5380.namprd12.prod.outlook.com (2603:10b6:208:314::7) by DM4PR12MB5328.namprd12.prod.outlook.com (2603:10b6:5:39f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Sun, 3 Jul 2022 09:46:36 +0000 Received: from BL1PR12MB5380.namprd12.prod.outlook.com ([fe80::d9c2:e478:3314:2ab4]) by BL1PR12MB5380.namprd12.prod.outlook.com ([fe80::d9c2:e478:3314:2ab4%3]) with mapi id 15.20.5395.019; Sun, 3 Jul 2022 09:46:36 +0000 From: Matan Azrad To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , Slava Ovsiienko , "Xueming(Steven) Li" , Maxime Coquelin Subject: RE: [PATCH] vdpa/mlx5: fix leak on event thread creation Thread-Topic: [PATCH] vdpa/mlx5: fix leak on event thread creation Thread-Index: AQHYhKcveW+kfQY4VUSZl4Tc7ksWhK1segYw Date: Sun, 3 Jul 2022 09:46:35 +0000 Message-ID: References: <20220620131044.1858049-1-david.marchand@redhat.com> In-Reply-To: <20220620131044.1858049-1-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c8567793-da5b-4b2e-5cfb-08da5cd8eb86 x-ms-traffictypediagnostic: DM4PR12MB5328:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4oXXGHMxRwQjkhAc6IpwpokDWYiMZ/Vp8sHSZMSA0S9JB3AHStiYGkSZDLYY4MAVJTO06Fme6+/++jefbJNke5G9D6xmrny44EPj6W9YYcuP5xgugcnvVJSmZhLYeyTPWhypf81puWhGsT8yU8HYWwom7NXP53Ru62USOItUT/DMvqkCQWn0zlFX22jiDYspCDYxQThEjJyXtJ8ex+qoUh1s55URiKo7I5w8zJK1duFoa0Jv2lSRdXsc3OLGdETqLyOIHP/10qxLC1hsmYcVL9U3+0YiM9qpb3rmoiDylomEvj4Uyo37d/BB/8dPmk66gFW/c/iGRnFmN1+yjjkoLYqok+UCmEfqX5xKPuuxhYPkcyCjwFZGpbIQYh/xjvP1GKay6VBpHwN20OXN4hoAgeetfyEgBvLQ+e0MWzzvV/q5KkVpPHXynoTLa6cu9NNEmSpqz3mb+s6EEwN7wa733ES74oX6frMMkaPGPQotnKdjohXMVdRkfToZ60eQv9U0OVDVDk3uhwioxboggYLe/lBkl6nZEWBXsAv7ig9/ZpTwYejqTVtGiRZHQgjTJyo8Cc4Tx6i2HofRPfQl90EuxI7EntryGwkHi8CQW/7PtHRqW6piJSxF9cwKGDaqeZaoUb3QoahXn4vgS/YI7oJWqvfGByfsumM/kT4uSQKTOA0K1Tr4aGiCGBTHyke8dGEjy6HsTuffy15OXQ8Vp0YRdUhoejR0g4YpuUJNYBUfUEpFEHpvZgfBPhqE5CvCuLxQ5DzPYQVkwRsBwELg99cIWfwFBX6EbWDlur/0CN4C04HQstbXQkpXnY6TDRGJ8Mak x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL1PR12MB5380.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(136003)(396003)(376002)(39860400002)(346002)(7696005)(6506007)(52536014)(4326008)(8676002)(86362001)(8936002)(478600001)(4744005)(186003)(5660300002)(41300700001)(110136005)(54906003)(38070700005)(122000001)(2906002)(38100700002)(33656002)(66556008)(66476007)(64756008)(66446008)(55016003)(71200400001)(66946007)(9686003)(76116006)(26005)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NTZunw+B11RKM2DRqrjf2NRJttXdXqrS7oc+TFjr5SOMLK6GVEcod494+sld?= =?us-ascii?Q?Z5Xpl2VTBVWsfQNdFOCBm2BJESXvD247AsF3KpCzPAXN541PYMkGbr5oA7n+?= =?us-ascii?Q?ugD6eMvNic0dHu0OI5+lEE7AdiWKEU5AoV4PdjwIDSocrMFchj/iNUS9N2tn?= =?us-ascii?Q?NgaKYBPTiYT/5j+8CMIm74n7qIt+g8+pyzy7Evxm7e1ybbX2NYx/AL5rPwik?= =?us-ascii?Q?fwfgwI2o/KQShx3UDXQtUDmGBS0syX7OnWX1H6kD6ota9/nE7jCSTEPGwjYb?= =?us-ascii?Q?M6u9OXPS0tZYIm/XRpqjm4Ut+GamumaeLvs3iJVcp5vmahsxIE+ffcX52Wtw?= =?us-ascii?Q?HVnQ6C0aMrsHMqFWSB1jzH1IWQPaO9qWxnr5MrNVIsM8vmHvyBxXwA+FqxOi?= =?us-ascii?Q?TPGvKHgo9G3bOhMnh9lFxNPO0EEevLgQUlISwRenFQ7Yd9BJKOBp/W02/q6g?= =?us-ascii?Q?ZNu3dWEubVP/1JmuWPX0KCi7sno0NqQX2EkpEkj3WZqsMR3MffCX0FjbHN6U?= =?us-ascii?Q?BD5oHsGlsQV9k7PoKMd7bj3FDlWWGbJ14VDeiNyHAL0l+8fzzBX7GW3XsTbY?= =?us-ascii?Q?p5FejU/OUrlJ5eLMTTtJ7bsdfY9ZmReJXDBLk1hzAZpuSxRWImE3Ol2X7Ifc?= =?us-ascii?Q?+DwJC2QAyje5u05WkIYh7FL5Ra/KflUNG9eoYlmT686c3Flb18AObUkjU/2z?= =?us-ascii?Q?pIxQrY2ReIzs6U6LINnzgiMKIFHG2h4RW2eJ7Zt7uDYouoAp6VJmKws58IIW?= =?us-ascii?Q?xcSlvHmw15/fJ2cPT5qhZS4+fx3WIEHhRuGee3LnI2FDu7QvqnH3umtumaKT?= =?us-ascii?Q?lUuN2B3YiPUrnKEpSgTzmn6VEaZrNGfifE0meTviHK4wnDFId4X5ZIqb7Q/t?= =?us-ascii?Q?4vkGGxXPG724/uPllD2VKql+eot3unx7eaADutsLnisB5OCa6k9wTjD2OgQd?= =?us-ascii?Q?xJ9EiUaN97zb9p2pHqRDPgxGghAG9U2q5MH/zFzNLAo474e/d6lCtg1KM9qV?= =?us-ascii?Q?eNaqnc03wBJkRhVv/kotIu6CK5PateBIsK2HdowH8JvelqqbzchCGINRz8kW?= =?us-ascii?Q?ePcV4NzMEzio/XpRByYcOYzxZXB/iSI2ObyuD3QOUXvcKoZJN/dNJerwJ83s?= =?us-ascii?Q?XjaQ40H5U55VISRbskWG06BREHyOpoeM8P6qkK24k9CQbtJP/84MGBa/JbGI?= =?us-ascii?Q?04wReMdwLLUYUCtjD1XkUBwUvsg/x1Gqv2NitCtq37VGsPlSbgQRrLrk+Gh1?= =?us-ascii?Q?yhn/exMSMp+Au0+QQxRA1x+B96qOZszIaEqtZwfZckqnpZRdFKGoOrOKniuo?= =?us-ascii?Q?m2ZKxC6aAOS2A+IXgGxuw869AeiuF/T9gPPU/hYN6nHd0Ns9IWyg6/LwKKwC?= =?us-ascii?Q?IzG+gl8R+W0yKiOITocgGE1+K21L9aNwqGJzt2vW8onmi9yhIviojXfY8C70?= =?us-ascii?Q?O8kHVFgJcXzj6wZ+BDxKLMYB3EhtGqanpUuaU51sY/WJi2677TCkx5WTz0i1?= =?us-ascii?Q?JGf2kg93DYya28OzVMMotBaSYLE7bYiAT36Rt752vsNUmP5dTtqj2XcEv9n9?= =?us-ascii?Q?4hBi/864ySuO5DvEePs=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5380.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8567793-da5b-4b2e-5cfb-08da5cd8eb86 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2022 09:46:35.9850 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: orXzKX8kNUVO9MeMrP/4hkjSRgv96pcejw9JREyWqxJsrgNjg8Y2Ysq+b7mT7Dfcd+VB02dO7Lbv3WfyRbMuWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5328 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org From: David Marchand > As stated in the manual, pthread_attr_init return value should be checked= . > Besides, a pthread_attr_t should be destroyed once unused. >=20 > In practice, we may have no leak (from what I read in glibc current code)= , but > this may change in the future. > Stick to a correct use of the API. >=20 > Fixes: 5cf3fd3af4df ("vdpa/mlx5: add CPU core parameter to bind polling > thread") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand Acked-by: Matan Azrad Thanks David!