From: "Guo, Junfeng" <junfeng.guo@intel.com>
To: Joshua Washington <joshwash@google.com>,
"Li, Xiaoyun" <xiaoyun.li@intel.com>,
Rushil Gupta <rushilg@google.com>,
Jeroen de Borst <jeroendb@google.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>, Xueming Li <xuemingl@nvidia.com>
Subject: RE: [PATCH 22.11] net/gve: fix RX buffer size alignment
Date: Wed, 13 Dec 2023 02:07:25 +0000 [thread overview]
Message-ID: <BL3PR11MB6482D4B16DD0D192D5894747E78DA@BL3PR11MB6482.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20231212200647.320716-1-joshwash@google.com>
> -----Original Message-----
> From: Joshua Washington <joshwash@google.com>
> Sent: Wednesday, December 13, 2023 04:07
> To: Guo, Junfeng <junfeng.guo@intel.com>; Li, Xiaoyun
> <xiaoyun.li@intel.com>; Rushil Gupta <rushilg@google.com>; Joshua
> Washington <joshwash@google.com>; Jeroen de Borst
> <jeroendb@google.com>
> Cc: stable@dpdk.org; Xueming Li <xuemingl@nvidia.com>
> Subject: [PATCH 22.11] net/gve: fix RX buffer size alignment
>
> The GVE driver has RX buffer size alignment requirements which will
> not always be respected when a user specifies an mbuf size. Assuming
> that an mbuf size is greater than the DPDK recommended default
> (2048 + 128), if the buffer size is not properly aligned with what the
> device expects, the device will silently fail to create any transmit or
> receive queues.
>
> Because no queues are created, there is no network traffic for the DPDK
> program, and errors like the following are returned when attempting to
> destroy queues:
>
> gve_adminq_parse_err(): AQ command failed with status -11
> gve_stop_tx_queues(): failed to destroy txqs
> gve_adminq_parse_err(): AQ command failed with status -11
> gve_stop_rx_queues(): failed to destroy rxqs
>
> This change aims to remedy this by restricting the RX receive buffer
> sizes to valid sizes for the GQ queue format, including both alignment
> and minimum and maximum supported buffer sizes.
>
> Fixes: 4bec2d0b5572 ("net/gve: support queue operations")
> Fixes: 1dc00f4fc74b ("net/gve: add Rx queue setup for DQO")
> Cc: junfeng.guo@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Joshua Washington <joshwash@google.com>
> Reviewed-by: Rushil Gupta <rushilg@google.com>
> ---
> drivers/net/gve/gve_ethdev.c | 2 +-
> drivers/net/gve/gve_ethdev.h | 4 +++-
> drivers/net/gve/gve_rx.c | 7 ++++++-
> 3 files changed, 10 insertions(+), 3 deletions(-)
>
> --
> 2.43.0.472.g3155946c3a-goog
Acked-by: Junfeng Guo <junfeng.guo@intel.com>
Regards,
Junfeng Guo
next prev parent reply other threads:[~2023-12-13 2:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 20:06 Joshua Washington
2023-12-13 2:07 ` Guo, Junfeng [this message]
2023-12-16 0:59 ` Xueming(Steven) Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL3PR11MB6482D4B16DD0D192D5894747E78DA@BL3PR11MB6482.namprd11.prod.outlook.com \
--to=junfeng.guo@intel.com \
--cc=jeroendb@google.com \
--cc=joshwash@google.com \
--cc=rushilg@google.com \
--cc=stable@dpdk.org \
--cc=xiaoyun.li@intel.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).