patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Karmarkar Suyash <skarmarkar@sonusnet.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dpdk stable <stable@dpdk.org>, Robert Sanford <rsanford@akamai.com>
Subject: Re: [dpdk-stable] patch 'timer: fix lag delay' has been queued to stable release 16.07.1
Date: Wed, 12 Oct 2016 12:08:47 +0000	[thread overview]
Message-ID: <BN3PR03MB14316025590A7E32F1A5DC2EB3DD0@BN3PR03MB1431.namprd03.prod.outlook.com> (raw)
In-Reply-To: <57fddbc8.lh/X0x8fuZyYebgP%yuanhan.liu@linux.intel.com>

All good from my side. Please go ahead.

-----Original Message-----
From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] 
Sent: Wednesday, October 12, 2016 2:44 AM
To: Karmarkar Suyash <skarmarkar@sonusnet.com>
Cc: dpdk stable <stable@dpdk.org>; Robert Sanford <rsanford@akamai.com>
Subject: patch 'timer: fix lag delay' has been queued to stable release 16.07.1

Hi,

FYI, your patch has been queued to stable release 16.07.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable
yet. It will be pushed if I get no objections before this Friday.
So please shutout if anyone has objections.

Thanks.

	--yliu

---
>From 449bd723843c6bb21a08be09db9821ee91169731 Mon Sep 17 00:00:00 2001
From: Karmarkar Suyash <skarmarkar@sonusnet.com>
Date: Wed, 21 Sep 2016 16:54:27 -0400
Subject: [PATCH] timer: fix lag delay

[ upstream commit 0778cfe8642a08934724cf34a4bb2f1fba91cc88 ]

For periodic timers, if the lag gets introduced, the current code added additional delay when the next peridoc timer was initialized by not taking into account the delay added, with this fix the code would start the next occurrence of timer keeping in account the lag added. Corrected the behavior.

Fixes: 9b15ba89 ("timer: use a skip list")

Signed-off-by: Karmarkar Suyash <skarmarkar@sonusnet.com>
Acked-by: Robert Sanford <rsanford@akamai.com>
---
 lib/librte_timer/rte_timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c index 43da836..18782fa 100644
--- a/lib/librte_timer/rte_timer.c
+++ b/lib/librte_timer/rte_timer.c
@@ -613,7 +613,7 @@ void rte_timer_manage(void)
 			status.owner = (int16_t)lcore_id;
 			rte_wmb();
 			tim->status.u32 = status.u32;
-			__rte_timer_reset(tim, cur_time + tim->period,
+			__rte_timer_reset(tim, tim->expire + tim->period,
 				tim->period, lcore_id, tim->f, tim->arg, 1);
 			rte_spinlock_unlock(&priv_timer[lcore_id].list_lock);
 		}
--
1.9.0

      reply	other threads:[~2016-10-12 12:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-12  6:44 Yuanhan Liu
2016-10-12 12:08 ` Karmarkar Suyash [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN3PR03MB14316025590A7E32F1A5DC2EB3DD0@BN3PR03MB1431.namprd03.prod.outlook.com \
    --to=skarmarkar@sonusnet.com \
    --cc=rsanford@akamai.com \
    --cc=stable@dpdk.org \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).