From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0055.outbound.protection.outlook.com [104.47.36.55]) by dpdk.org (Postfix) with ESMTP id A0ED0374E for ; Wed, 12 Oct 2016 14:08:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SonusNetworks.onmicrosoft.com; s=selector1-sonusnet-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=q5/rRO0+/MkdKtGjGAjZYUy9VUiQdbzTUM7PgA1Rw54=; b=hB4ZqKiBBAN5FCF/D5fnjB54JFPPmJn+dhJp9JDr84qsMzDryZuW85j2UDkyHzO/UkpJELfsbAlycTt04Q6/lLXaHjASBgDNBU0xO8nE/5DMxCzzZk8eBUv8YHRMDLNVA4A/l8wZ7AM3d5PJ3nPOhW7NkwLS1JBtTGzngoThz7I= Received: from BN3PR03MB1431.namprd03.prod.outlook.com (10.163.34.26) by BN3PR03MB1431.namprd03.prod.outlook.com (10.163.34.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11; Wed, 12 Oct 2016 12:08:47 +0000 Received: from BN3PR03MB1431.namprd03.prod.outlook.com ([10.163.34.26]) by BN3PR03MB1431.namprd03.prod.outlook.com ([10.163.34.26]) with mapi id 15.01.0659.020; Wed, 12 Oct 2016 12:08:47 +0000 From: Karmarkar Suyash To: Yuanhan Liu CC: dpdk stable , Robert Sanford Thread-Topic: patch 'timer: fix lag delay' has been queued to stable release 16.07.1 Thread-Index: AQHSJFQb2HQW+fGZjUO5PVt0reba8qCkuf8Q Date: Wed, 12 Oct 2016 12:08:47 +0000 Message-ID: References: <57fddbc8.lh/X0x8fuZyYebgP%yuanhan.liu@linux.intel.com> In-Reply-To: <57fddbc8.lh/X0x8fuZyYebgP%yuanhan.liu@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=skarmarkar@sonusnet.com; x-originating-ip: [208.45.178.4] x-ms-office365-filtering-correlation-id: 3c93fe3e-bc24-41d3-fa9c-08d3f2988544 x-microsoft-exchange-diagnostics: 1; BN3PR03MB1431; 6:+Jp803h7ru0cbOfk8aVr7ZRkkbsfIGyzppz3cNWPMp6w4SO3liXRgLByLxrbLlDP7/aTvx2hzDz0l8G8taooVAbfwEcraxpxrqcwyiZj6umbCi8STfVuffqzZM28NbPU0qJdT9BWPmWwJ2pSJYhwRPhputOXnBcidKWlrdGeIM7iEysQzjp8TCQ+WlfclO3huE0LT3QMJfBbllriD9CRdSJPTlBhRXsd0gfKphYEjiywHy2wo0m3rEC/Q4RWnKVxITWvsx85PpfkNpKoRyrUXiEkUr7chSEeTLrvzUl0nYa/VK3T1ZGmA68S51jyi9vf; 5:gUFFGW4zx9zrIOfmnXrvUqvDYcUY3J8ziNBSZeBBB24gfTPuougiYY6kcs9KnGTELJbE7a/GIwA/DgNVXAxjcNvN0Qu9KzxMklUptXFD/kf0IqGQZopdM8ZLEJvJJxKgXERqRs9wRgCxfUXGmosncncC2u6thMcoRpS30OieOjI=; 24:pkmk6nodfqtd73UWG288IPaDzt/IcRht8LaDN7WGX/okkXbwA99XpMOkBx17jRAv7j6oI/GvDgym8JptHzZyQZlr6juhKItCVrUuJw6R9QQ=; 7:hDNljsWyfxu31OEfOglZLQj7pPMQZm7wKtvh8IUarT92hvRSMUlmt3K4S20fw4ylkqKSpZbYR3GZ5YOOxxJCBJfTobBUfLXv5pK/kjorC9EqJcV8fFBk1kHPZlIxmjpxfD7E2NoBcVwfiD8EGV4wP8AIQbdeC4qWCuOYa9OigSWimj8oHKaG4u4MAcRbxRkHTIjKeNBnSsH61CLZz/w6MbZsXp5i6v/Psiles2uGGZm23RJAuno63Kzk/c8OKaO5/nR3cXQ+0L5vnnYui+k/Ohk4xDgmhdEIcPUGFGp1xR/3D0k3CENU5Yr2dc/OZFQm6Ii8cAZie39xcGmWEt5qusGhdaxmbssKBuVloLrMSKU= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1431; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:BN3PR03MB1431; BCL:0; PCL:0; RULEID:; SRVR:BN3PR03MB1431; x-forefront-prvs: 0093C80C01 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(377454003)(13464003)(69234005)(46034005)(199003)(189002)(28163001)(4326007)(86362001)(19580395003)(19580405001)(11100500001)(15395725005)(189998001)(10400500002)(76176999)(54356999)(66066001)(97736004)(5002640100001)(8676002)(15975445007)(81156014)(77096005)(101416001)(81166006)(1720100001)(68736007)(50986999)(92566002)(33656002)(106356001)(2900100001)(6116002)(586003)(7736002)(305945005)(7846002)(102836003)(3846002)(2950100002)(87936001)(5660300001)(110136003)(99286002)(74316002)(105586002)(3280700002)(7696004)(122556002)(8936002)(3660700001)(106116001)(9686002)(76576001)(2906002)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB1431; H:BN3PR03MB1431.namprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: sonusnet.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: sonusnet.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2016 12:08:47.2681 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1431 Subject: Re: [dpdk-stable] patch 'timer: fix lag delay' has been queued to stable release 16.07.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 12:08:50 -0000 All good from my side. Please go ahead. -----Original Message----- From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]=20 Sent: Wednesday, October 12, 2016 2:44 AM To: Karmarkar Suyash Cc: dpdk stable ; Robert Sanford Subject: patch 'timer: fix lag delay' has been queued to stable release 16.= 07.1 Hi, FYI, your patch has been queued to stable release 16.07.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before this Friday. So please shutout if anyone has objections. Thanks. --yliu --- >>From 449bd723843c6bb21a08be09db9821ee91169731 Mon Sep 17 00:00:00 2001 From: Karmarkar Suyash Date: Wed, 21 Sep 2016 16:54:27 -0400 Subject: [PATCH] timer: fix lag delay [ upstream commit 0778cfe8642a08934724cf34a4bb2f1fba91cc88 ] For periodic timers, if the lag gets introduced, the current code added add= itional delay when the next peridoc timer was initialized by not taking int= o account the delay added, with this fix the code would start the next occu= rrence of timer keeping in account the lag added. Corrected the behavior. Fixes: 9b15ba89 ("timer: use a skip list") Signed-off-by: Karmarkar Suyash Acked-by: Robert Sanford --- lib/librte_timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c in= dex 43da836..18782fa 100644 --- a/lib/librte_timer/rte_timer.c +++ b/lib/librte_timer/rte_timer.c @@ -613,7 +613,7 @@ void rte_timer_manage(void) status.owner =3D (int16_t)lcore_id; rte_wmb(); tim->status.u32 =3D status.u32; - __rte_timer_reset(tim, cur_time + tim->period, + __rte_timer_reset(tim, tim->expire + tim->period, tim->period, lcore_id, tim->f, tim->arg, 1); rte_spinlock_unlock(&priv_timer[lcore_id].list_lock); } -- 1.9.0