patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Yang, Qiming" <qiming.yang@intel.com>
To: "Jiang, JunyuX" <junyux.jiang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Xing, Beilei" <beilei.xing@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/iavf: fix mismatch command
Date: Thu, 3 Sep 2020 01:50:50 +0000	[thread overview]
Message-ID: <BN6PR11MB0017AEADD5DEAABF787610ACE52C0@BN6PR11MB0017.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200901081436.34963-1-junyux.jiang@intel.com>



> -----Original Message-----
> From: Jiang, JunyuX <junyux.jiang@intel.com>
> Sent: 2020年9月1日 16:15
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> Yang, Qiming <qiming.yang@intel.com>; Jiang, JunyuX
> <junyux.jiang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/iavf: fix mismatch command
> 
> The "command mismatch" warning shouldn't be triggered by
> VIRTCHNL_OP_EVENT opcode, because the VIRTCHNL_OP_EVENT opcode is
> used by PF notifies status change events to VF.
> This patch fixed the issue.
> 
> Fixes: 837c2ed86e4c ("net/iavf: return error if opcode is mismatched")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
> ---
>  drivers/net/iavf/iavf_vchnl.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index
> 33acea54a..331018f14 100644
> --- a/drivers/net/iavf/iavf_vchnl.c
> +++ b/drivers/net/iavf/iavf_vchnl.c
> @@ -53,8 +53,11 @@ iavf_read_msg_from_pf(struct iavf_adapter *adapter,
> uint16_t buf_len,
>  		    opcode, vf->cmd_retval);
> 
>  	if (opcode != vf->pend_cmd) {
> -		PMD_DRV_LOG(WARNING, "command mismatch, expect %u,
> get %u",
> -			    vf->pend_cmd, opcode);
> +		if (opcode != VIRTCHNL_OP_EVENT) {
> +			PMD_DRV_LOG(WARNING,
> +				    "command mismatch, expect %u, get %u",
> +				    vf->pend_cmd, opcode);
> +		}
>  		return IAVF_ERR_OPCODE_MISMATCH;
>  	}
> 
> --
> 2.17.1
Reviewed-by: Qiming Yang <qiming.yang@intel.com>

  reply	other threads:[~2020-09-03  1:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01  8:14 Junyu Jiang
2020-09-03  1:50 ` Yang, Qiming [this message]
2020-09-03 14:17   ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN6PR11MB0017AEADD5DEAABF787610ACE52C0@BN6PR11MB0017.namprd11.prod.outlook.com \
    --to=qiming.yang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=junyux.jiang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).