patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Yang, Qiming" <qiming.yang@intel.com>
To: "Wang, ShougangX" <shougangx.wang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/ice: fix incorrect firmware version
Date: Thu, 6 Aug 2020 09:15:53 +0000	[thread overview]
Message-ID: <BN6PR11MB0017B10DAB5047735C72EF27E5480@BN6PR11MB0017.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200806082519.71727-1-shougangx.wang@intel.com>



> -----Original Message-----
> From: Wang, ShougangX <shougangx.wang@intel.com>
> Sent: Thursday, August 6, 2020 16:25
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wang, ShougangX <shougangx.wang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] net/ice: fix incorrect firmware version
> 
> Kernel driver shows firmware version as hex but ice PMD shows as decimal.
> This patch fixes the issue to make consistent with kernel driver.
> 
> Fixes: ac882a0eda69 ("net/ice/base: store NVM version in extracted format")

Fix line not correct, should be the code you fixed

> Cc: stable@dpdk.org
> 
> Signed-off-by: Shougang Wang <shougangx.wang@intel.com>
> ---
>  drivers/net/ice/ice_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index 8d435e889..88b8428b9 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -4388,7 +4388,7 @@ ice_fw_version_get(struct rte_eth_dev *dev, char
> *fw_version, size_t fw_size)
>  	build = hw->nvm.orom.build;
> 
>  	ret = snprintf(fw_version, fw_size,
> -			"%d.%d 0x%08x %d.%d.%d",
> +			"%x.%02x 0x%08x %d.%d.%d",
>  			hw->nvm.major_ver,
>  			hw->nvm.minor_ver,
>  			hw->nvm.eetrack,
> --
> 2.17.1


  reply	other threads:[~2020-08-06  9:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-06  8:25 Shougang Wang
2020-08-06  9:15 ` Yang, Qiming [this message]
2020-08-06 10:37   ` Wang, ShougangX
2020-08-06 10:28 ` [dpdk-stable] [PATCH v2] " Shougang Wang
2020-08-07  1:45   ` Yang, Qiming
2020-09-11  2:40 ` [dpdk-stable] [PATCH v3] " Shougang Wang
2020-09-11  3:37   ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN6PR11MB0017B10DAB5047735C72EF27E5480@BN6PR11MB0017.namprd11.prod.outlook.com \
    --to=qiming.yang@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=shougangx.wang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).