patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	"Trybula, ArturX" <arturx.trybula@intel.com>,
	"Mcnamara, John" <john.mcnamara@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"shallyv@marvell.com" <shallyv@marvell.com>,
	"Dybkowski, AdamX" <adamx.dybkowski@intel.com>,
	"Danilewicz, MarcinX" <marcinx.danilewicz@intel.com>,
	Akhil Goyal <akhil.goyal@nxp.com>,
	"Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-stable] [PATCH] test/compress: replace test vector
Date: Mon, 20 Jan 2020 15:00:28 +0000	[thread overview]
Message-ID: <BN6PR11MB179609DE97AD9099CF6F703BE4320@BN6PR11MB1796.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1850623.NnIJQXNAa5@xps>

Hi Thomas

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, January 20, 2020 2:33 PM
> To: Trahe, Fiona <fiona.trahe@intel.com>; Trybula, ArturX <arturx.trybula@intel.com>; Mcnamara,
> John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; shallyv@marvell.com; Dybkowski, AdamX
> <adamx.dybkowski@intel.com>; Danilewicz, MarcinX <marcinx.danilewicz@intel.com>; Akhil Goyal
> <akhil.goyal@nxp.com>
> Subject: Re: [dpdk-stable] [PATCH] test/compress: replace test vector
> 
> 20/01/2020 14:54, Mcnamara, John:
> > From: stable <stable-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> > > 15/01/2020 16:54, Akhil Goyal:
> > > > > >
> > > > > > This patch replaces existing test vector with a new one containing
> > > > > > C code to fix license issue.
> > > > > >
> > > > > > Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> > > > > Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> > > > Applied to dpdk-next-crypto
> > >
> > > This is a terrible idea.
> > > Adding C code in a C project as text, and worst, its own code, will make
> > > grep matching on fake text.
> >
> > Hi,
> >
> > I don't think this is a valid criticism. The patch replace code in Pascal with some code in C as a
> compression test. The grep part isn't really relevant, it should be clear to anyone who finds a match.
> >
> > If you have a strong objection we will replace it with some more public domain text.
> 
> Yes please, it will be less confusing.
> 
> > > Why do you need so much text to compress?
> 
> Please why do we need some code at all?
[Fiona] compression engines are usually tested with different types of data to represent various use-cases.
So include for example ASCII text, binary chunks, excel files, etc. Compression of code is a typical compression workload - and
as code has lots of patterns may be quite compressible, at different ratios to standard English language text.
That said, it's not so important in DPDK to cover all data types as our focus is not on verifying the compression
engines, but just the path through the API and PMD to them. So we can replace this text if it's less confusing.

> 
> > > Why not just opening our own code files as text?
> >
> > That probably isn't worth the effort.
> >
> > > Why stable@dpdk.org is Cc'ed in this email?
> >
> > Ok. We'll do that.
> 
> I say Why? You say Ok :-)
[Fiona] Simple mistake - sorry 😊
> 
> > > What is the license issue?
> >
> > The issue is that the Pascal code from the Calgary Corpus (a standard body of compression test
> input) doesn't have a license or explicitly say that it is in the public domain so it isn't clear if we can
> relicense  it as BSD-3. We are being overly cautious here but we didn't want to run into any potential
> license issues.
> 
> OK
> Please explain in the commit log.
> 
[Fiona] ok

  reply	other threads:[~2020-01-20 15:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 11:56 Artur Trybula
2020-01-14 12:33 ` Trahe, Fiona
2020-01-15 15:54   ` Akhil Goyal
2020-01-17 21:51     ` Thomas Monjalon
2020-01-20 13:54       ` Mcnamara, John
2020-01-20 14:33         ` Thomas Monjalon
2020-01-20 15:00           ` Trahe, Fiona [this message]
2020-01-20 18:00           ` Mcnamara, John
2020-01-27 10:59             ` [dpdk-stable] [dpdk-dev] " Mcnamara, John
2020-02-06  9:37 ` [dpdk-stable] [PATCH v2] " Artur Trybula
2020-02-12 13:25   ` Akhil Goyal
2020-02-12 13:31     ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2020-02-12 14:12       ` Akhil Goyal
2020-02-12 14:56         ` Trybula, ArturX
2020-02-13  9:30           ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN6PR11MB179609DE97AD9099CF6F703BE4320@BN6PR11MB1796.namprd11.prod.outlook.com \
    --to=fiona.trahe@intel.com \
    --cc=adamx.dybkowski@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=arturx.trybula@intel.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=marcinx.danilewicz@intel.com \
    --cc=shallyv@marvell.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).