From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBA77A00C3 for ; Mon, 9 May 2022 12:01:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE0D042822; Mon, 9 May 2022 12:01:51 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id D489C4068F; Mon, 9 May 2022 12:01:48 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 248No5Y8009185; Mon, 9 May 2022 03:01:47 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2047.outbound.protection.outlook.com [104.47.66.47]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3fwp4pwv13-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 09 May 2022 03:01:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mRrD1XzvJEROJk5LfDfuhvOns6c8KwQkBd0io2T5PBUWEJkaUizDLdOnhXHa+gGnEgZFPgspFq0rSjDeoctKfQRd1IrQQbXN7sd1FaRKheHnV6qLV4HaS1YsymXE80XtS7ZN0oOlZ2fyuvY21iTI/EkFZI4zk1u7GMCadBG2tT1UR3w8gZ/v5i7jZdWkKO/Xo7pnySfGGbIl4n/rxEsIJUEPYP6hdee3X3jr41txXCphVAVuZVfPJs1Ma1evaXSI1gR3DizXDyww2Ol/Y+cGy9j+J0lUWTqWtZn5lHGMnUgxsY9/adarzHSFtlKk6KxD+ykI0ygbDLQi3D/lwv76WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bR9hKFxhrxack//eIyd8PiEMfVjSDCvsKOonrQyQFeU=; b=oRfibRjGFLkREVDYdpsiBllKhuS+q4fUk/VAhPdjLjjsw7PBnS9z5EpfZsLB0R37my2DwJnIK1GYO0QzpksgBpy0+HdgBVyz5WbTH2OPoxfYSr22EwpFTNa7NYJ4aLnVJlG0TIMiiUS0Z1jF37acoeHsYMQ+6usdHgsZc/mu3PRg3uf7TPWdM5JIniNsMQfTX8lk8SRdW1PdhPCqabYKTndZDUUhzU0EMiVIeK41293X5LYdwKGh+CuWgrLST+JjLicfSYXL7AfEzHPZokqowRNN62kWhkVHkpFB2fp3KFySJryAYRZHTH8Kz2Gzco32Ta27lyllTMFbEbfrGycMNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bR9hKFxhrxack//eIyd8PiEMfVjSDCvsKOonrQyQFeU=; b=pFzdedBUCfuDFqWds+T/pqTeJxBPNs34dfhfjQO/bh9y6i8ABIgFpak62xfgjm0lB7KByZOjKZIZpG51sDd+cnvcB19wxr0JugzPBzHHh4BZ30fu4QZlhXAf3sn5RdTTg334kdNhcZLAp7VG6gKM5BAkBd7RhtWLPuxB0kNxQ/I= Received: from BN8PR18MB2482.namprd18.prod.outlook.com (2603:10b6:408:9b::23) by BN6PR18MB1347.namprd18.prod.outlook.com (2603:10b6:404:12c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Mon, 9 May 2022 10:01:44 +0000 Received: from BN8PR18MB2482.namprd18.prod.outlook.com ([fe80::d409:66d2:1a81:ee6d]) by BN8PR18MB2482.namprd18.prod.outlook.com ([fe80::d409:66d2:1a81:ee6d%7]) with mapi id 15.20.5227.023; Mon, 9 May 2022 10:01:44 +0000 From: Rakesh Kudurumalla To: Thomas Monjalon , Jerin Jacob Kollanukkaran CC: "stable@dpdk.org" , "dev@dpdk.org" , "david.marchand@redhat.com" , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , "ajit.khaparde@broadcom.com" Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails Thread-Topic: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails Thread-Index: AQHXfYd7L4dTcIZ+J0yRnIum/STvbqwAdsEAgA94qwCAABO0AIAK+z4ggAAJdACAFc2x4IAsMZVQgCJoOxCAABTHgIAUPxbwgIRYgvA= Date: Mon, 9 May 2022 10:01:44 +0000 Message-ID: References: <20210720124713.603674-1-rkudurumalla@marvell.com> <3120644.AJdgDx1Vlc@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3e1ae219-40a1-41b5-e57b-08da31a2ec3b x-ms-traffictypediagnostic: BN6PR18MB1347:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QL+e99jC70YHdntHP1T6qG/JR8mrmpm+V03j7QrshzeB9Bfo3px0PRZyPnFx6t4QfUQDswDJjtputwcOcOVDzPTKn22LO+fVx4DDt/FeO09K3U7R4KOl04jKn3g22SVjr2RvHpSlGrhUxFe8mBTRCBLQliCV3tvUoXbIkAwc5Umzfa57+jlpF3ST61UsZoneziCMiW3LzHpc5WXgLob8AFL1ZPytJSmvIhq+un4/FiQZj712PJ5kmh+9VFE7Dp/aOHdvC5HdUiyR4/HTEbz/ZHutygAZM4kPNEMsgHu/ZNuMXrNxseRez7gaJn2dLVhJ0e2D8WCNe0hj5iYOIO4In52Y/Q0qBcKZJcrQgS2ksKfgIFQEeredbF1j0K1O/f4sBuGB+L0o2fmD5uS6OxihW7wkNOYevkGB6i/X+H2O8KHHDaToxPbLHHw+zB60bru9KnIzZEQ//0KPo2/G17Dzm98Mg1GHP2z8akKzGkFI2jdqW3n3met9Z/HKMn1mGo7Qvqtz+rC1MJDyecCuW9djEeOmBFt9ikNYaaiHlHfMC58tM5H5YgxMMbHVMGSV1Gpeq/xOFm/oSj6a9Z4vOTaxLABFryTp/TZVS046QuT1viyw/DvsYQVYtejsH2XlfvQAFGI7I7t4YgF8kvdOiahyKF1/DJqr3Wi453i6z7oIH1xq3414lo3z5gSMUXsavyfbSVW+Bac1J0zXxE9O1BTSqw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR18MB2482.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(52536014)(2906002)(122000001)(38070700005)(38100700002)(8936002)(5660300002)(508600001)(55016003)(83380400001)(186003)(4326008)(33656002)(66556008)(8676002)(66446008)(66946007)(64756008)(66476007)(76116006)(54906003)(316002)(53546011)(6506007)(110136005)(6636002)(7696005)(71200400001)(9686003)(26005)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?D+DMziLre5zotsaTAFsXEF8nRFnx8DQSrWNnUbfWwyuTRL9L6L6sF+e2W4gy?= =?us-ascii?Q?kqhncq0in399EFZWDzhACBwNu11T3/WnQCuh08g02XWH7SGAT0S9Oub4ocjM?= =?us-ascii?Q?stoAlb/Y2zLrvBwVmy3JAcNIkgmU1EtvcF4igunCmOn217WGnJEy6T7PvsYF?= =?us-ascii?Q?I71SohTZPG0I+S7365SrOXYC7bgcRTdgnvk+6xBfXKn90mxFQL+V0S0Kzfmp?= =?us-ascii?Q?hANWYLnVUvZHajEcOdVYUskGMDRmfpnHzbDRbWaFhBFRGAihpeQBsR1q1PCz?= =?us-ascii?Q?lzXTOEY4cybA7tBp/K7vhJDHV3kHZmxahLHEgDIa2yjNJAMlxHHRHdmoTd7P?= =?us-ascii?Q?i6KnSxl9LbJ87oPbkZxq+ojEvgNxYKI604uucbg0TmJEpRJdBMkafPSO/2Cc?= =?us-ascii?Q?iLkkrtC7fA0ALz3RFKbUGWAWYm2ymt9OGzsC1V8YsQR0tC0AQCjX9EnVp5Qz?= =?us-ascii?Q?mEULIE9EsIvyE0Glzw0VC9zNCdZf+faNGEW2gW3EdA5K4R3IByVkHCtEK1Pc?= =?us-ascii?Q?gNR9M0Z/MhCo0aAxI3jnmzxcyhoG8SqqV+XUeGWEOG9YIQ5/g7sY5iJBZKyl?= =?us-ascii?Q?vmMMfzpQOlVadhCLToZ7uBZLA992ooWJBbStSSU6nmrFDM8Du9kY+8axANyV?= =?us-ascii?Q?FRDzSZiUi88EXMiCcObJelFRuAmV5NkA8qDuJZ1CPVpGAk6i+bw5AYaELDpS?= =?us-ascii?Q?aAyA8J2k08+zVItDmdJHhsfTL5dTnDBv/yRvyIeEm8bDfk2HjKL212gWd3QV?= =?us-ascii?Q?oDuhyQrqwEQj6TdNq68dYh+K1ilJyHChZnCEjV6IhKyziS13KBZaQqFtF1rM?= =?us-ascii?Q?On2+oFtYizL+4vFvFaasQwxJXsLshJGhA4p694oS1FYBoPXj2tGss4WJ7dIs?= =?us-ascii?Q?MRV468XHDKIOSzOpyqgKtvr+6WzoaHLWClJ35XD7BV0mPjRk9BBIMOE1TIeW?= =?us-ascii?Q?VPBmfm+epM+MUK6egagQQ52UCWMy6dy+zYs1iQEUVI5RRNtdgUvLOHy1ef2E?= =?us-ascii?Q?xV75oWfBhl3oDjCjjjTDupRKT9ETTrBtWJMklhk3T7HEH67Oe3gQWthjIBN4?= =?us-ascii?Q?/I63WEvR56/pixiwZqAV0p10a758N408ndPqfzthsx/zDV0DbR5f3DebjhOq?= =?us-ascii?Q?rwmYcIHXBBKTVnrk7I+kh7zrnVDqMx59xi4N6sNB7oUHa/NgjTAU/hoMttlA?= =?us-ascii?Q?gkx73IKfbqER3OFkJuq3CxnHwuSnsVWOjHrrI6N6dPEIvn4JyhYW60yQbyqz?= =?us-ascii?Q?ZI7tOR7tvtasYDEdsezTpT8PRoz1wLWHgW+c+NTawMNGA1Aer6AHeB/9XLay?= =?us-ascii?Q?d9/zzG176shYhADXOpoGuPQeZiN8Qo7VNnv1bqx82htW0PdJGLdbwp4dJkmJ?= =?us-ascii?Q?pe7fx1XoW0aKmD+MbsCxtOg2Fe5s/E6a1fz89zZOojxrQ9GdvvJrxJqzEI6o?= =?us-ascii?Q?GrPCCEDWxCkIuLCWunHZJS3ivqwCgZ217FZlZkGedX7u1L55a9uKNHemBQr/?= =?us-ascii?Q?n7roEIPtBvu2ly1NX5f4RkLfyF6dOLyQSzgIudMDE78/GFonuA0F9RZFoPcG?= =?us-ascii?Q?IKnrdJiSP551W9qcXNjPbEh1nJz9w/r/DGqLJhAWWbuMgDJlG+/7nBtCeJsU?= =?us-ascii?Q?j77X5i8oWqo8uYb4kvU1o3iClFZAGpoo+gvbAZDgg2zWBoks6Ik9e+h4gqrD?= =?us-ascii?Q?wALIW1Ll6dI95myq6LcpODjCNr6asmOcnxfuRNVDGD9IdPOaB4GzD3mLN6nv?= =?us-ascii?Q?bvavXDbdmg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR18MB2482.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e1ae219-40a1-41b5-e57b-08da31a2ec3b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2022 10:01:44.3845 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ltzbtKzL4ZNjFEiWGkjGdtNmqC5c6RkqTloxhBo6vePdLAhcxSXwtps5Z1E7dOH0OdeCTngU+OYf9yoJbTXQju390lf52J0hIFy3Sj7R36M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR18MB1347 X-Proofpoint-ORIG-GUID: 5wK6L9IbjqlHR9F2n6E4ukJ8SXKY_B61 X-Proofpoint-GUID: 5wK6L9IbjqlHR9F2n6E4ukJ8SXKY_B61 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-09_03,2022-05-09_01,2022-02-23_01 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Thomas Monjalon, Same behavior is observed in cnxk driver as well. Can we please get this patch merged ? Regards, Rakesh=20 > -----Original Message----- > From: Rakesh Kudurumalla > Sent: Monday, February 14, 2022 10:27 AM > To: Thomas Monjalon ; Jerin Jacob Kollanukkaran > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com; > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > ajit.khaparde@broadcom.com > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queue= s are > full and Tx fails >=20 >=20 >=20 > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Tuesday, February 1, 2022 1:15 PM > > To: Jerin Jacob Kollanukkaran ; Rakesh Kudurumalla > > > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com; > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > > ajit.khaparde@broadcom.com > > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if > > queues are full and Tx fails > > > > octeontx2 driver is removed > > Can we close this patch? > Same behavior is observed with cnxk driver, so we need this patch > > > > > > 01/02/2022 07:30, Rakesh Kudurumalla: > > > ping > > > > > > > -----Original Message----- > > > > From: Rakesh Kudurumalla > > > > Sent: Monday, January 10, 2022 2:35 PM > > > > To: Thomas Monjalon ; Jerin Jacob > > Kollanukkaran > > > > > > > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com; > > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > > > > ajit.khaparde@broadcom.com > > > > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang > > > > if queues are full and Tx fails > > > > > > > > ping > > > > > > > > > -----Original Message----- > > > > > From: Rakesh Kudurumalla > > > > > Sent: Monday, December 13, 2021 12:10 PM > > > > > To: Thomas Monjalon ; Jerin Jacob > > > > > Kollanukkaran > > > > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com; > > > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > > > > > ajit.khaparde@broadcom.com > > > > > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang > > > > > if queues are full and Tx fails > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Thomas Monjalon > > > > > > Sent: Monday, November 29, 2021 2:44 PM > > > > > > To: Rakesh Kudurumalla ; Jerin Jacob > > > > > > Kollanukkaran > > > > > > Cc: stable@dpdk.org; dev@dpdk.org; > david.marchand@redhat.com; > > > > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > > > > > > ajit.khaparde@broadcom.com > > > > > > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid > > > > > > hang if queues are full and Tx fails > > > > > > > > > > > > 29/11/2021 09:52, Rakesh Kudurumalla: > > > > > > > From: Thomas Monjalon > > > > > > > > 22/11/2021 08:59, Rakesh Kudurumalla: > > > > > > > > > From: Thomas Monjalon > > > > > > > > > > 20/07/2021 18:50, Rakesh Kudurumalla: > > > > > > > > > > > Current pmd_perf_autotest() in continuous mode tries > > > > > > > > > > > to enqueue MAX_TRAFFIC_BURST completely before > > > > > > > > > > > starting the > > > > test. > > > > > > > > > > > Some drivers cannot accept complete > > > > > > > > > > > MAX_TRAFFIC_BURST even though > > > > > > > > rx+tx > > > > > > > > > > > desc > > > > > > > > > > count > > > > > > > > > > > can fit it. > > > > > > > > > > > > > > > > > > > > Which driver is failing to do so? > > > > > > > > > > Why it cannot enqueue 32 packets? > > > > > > > > > > > > > > > > > > Octeontx2 driver is failing to enqueue because hardware > > > > > > > > > buffers are full > > > > > > > > before test. > > > > > > > > > > > > Aren't you stopping the support of octeontx2? > > > > > > Why do you care now? > > > > > > yes we are not supporting octeontx2,but this issue is > > > > > > observed in cnxk driver ,current patch fixes the same > > > > > > > > > > > > > > > > Why hardware buffers are full? > > > > > > > Hardware buffers are full because number of number of > > > > > > > descriptors in continuous mode Is less than > > > > > > > MAX_TRAFFIC_BURST, so if enque fails , there is no way hardwa= re > can drop the Packets . > > > > > > > pmd_per_autotest application evaluates performance after > > > > > > > enqueueing > > > > packets Initially. > > > > > > > > > > > > > > > > > pmd_perf_autotest() in continuous mode tries to enqueue > > > > > > > > > MAX_TRAFFIC_BURST (2048) before starting the test. > > > > > > > > > > > > > > > > > > > > This patch changes behaviour to stop enqueuing after > > > > > > > > > > > few > > > > retries. > > > > > > > > > > > > > > > > > > > > If there is a real limitation, there will be issues in > > > > > > > > > > more places than this test program. > > > > > > > > > > I feel it should be addressed either in the driver or > > > > > > > > > > at ethdev > > level. > > > > > > > > > > > > > > > > > > > > [...] > > > > > > > > > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void > > *args) > > > > > > > > > > > nb_tx =3D RTE_MIN(MAX_PKT_BURST, > > num); > > > > > > > > > > > nb_tx =3D rte_eth_tx_burst(portid, 0, > > > > > > > > > > > > > &tx_burst[idx], > > > > > > nb_tx); > > > > > > > > > > > + if (nb_tx =3D=3D 0) > > > > > > > > > > > + retry_cnt++; > > > > > > > > > > > num -=3D nb_tx; > > > > > > > > > > > idx +=3D nb_tx; > > > > > > > > > > > + if (retry_cnt =3D=3D MAX_RETRY_COUNT) > > { > > > > > > > > > > > + retry_cnt =3D 0; > > > > > > > > > > > + break; > > > > > > > > > > > + } > > > > > > > > > > > > > > > > > > > > > > > > > >