From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8FBBA0C52 for ; Mon, 22 Nov 2021 08:59:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1CE641155; Mon, 22 Nov 2021 08:59:35 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 3720B4014E; Mon, 22 Nov 2021 08:59:33 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1AM642M9030706; Sun, 21 Nov 2021 23:59:31 -0800 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2100.outbound.protection.outlook.com [104.47.58.100]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3cg5m18at5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 21 Nov 2021 23:59:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hYWQGPoFDxUNB+3pRsj3uuzbdqQ/UZid5zONCSkeSg61irGYG1HEqs8sz4YF83T2WBX5rrkxRD81JX2HnPlsXHTKEX9BW6NrXcgVklk3RjP0XPo1+i06tY7p5a1U6cYdYY6cpx9pBKXCzuVlUsRGjxU6oQDWU++I9BsBywsmRB/rhqPL8/AKHfIexSu1/r/vBhidcuCMnrheKKCOpF/VtCtHy3DStoGFWsimExJZUwIA42VAXLo5HCvtiS363kofjFR9Ddtys9qpbARnKxn5NmMqrCqCIl9pmoSwQ54L/1brvy2YDW0mDwNddkkoT2PYLqX6mnSnVLzZ7aoZ0kQauQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=73jKPXz/WJ915DsIMP431tPMu/WgPaABNMB+oUuS5hY=; b=Ou19/PVQarjcUm3PoJKDhAXeenl6hAaEbYw+8QwjmjBECP19zj5rxmjgYgWBsT+bCuzOWXkqLZ9lDZz1T6kNzWPjUVo34YnDIw1qBIyKDPxp0mMBmayWo4CV3HzB/aoJ2Cim45yn1okqcrPN1DO8Askt/6cCc4I6tlpvCi7Mx0XuNZixSQsCi1dytjqbT/eKz7IMt5wnTrf7F72CYbkxcTFjmXkjPLQN0vvG0w9DxNv31zIwXUcaruqV9+6ReWExeAkXp2O03BAHngAGhXbEZfw2afacawELefGHFh+TuvozIQllkDOgH8Y2Eb72qjP9OlNzm1wRyZLCafeAxmWImw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=73jKPXz/WJ915DsIMP431tPMu/WgPaABNMB+oUuS5hY=; b=el53BdaSrb9/4cPLb6/zCyISm4TfNTZiMCjpx6gk1P9wMsxAPH/aylyyjLtKyQa7L83hpq+b/44oAno2uVkOx9hmC1nG5JjIGPqNV0b+R6eYjwU4Oe+ioYwWQALhvI/ewPRfFi1kTKhyPA1XGk9greEc7VFFPdjnYkKSt8N8c7I= Received: from BN8PR18MB2482.namprd18.prod.outlook.com (2603:10b6:408:9b::23) by BN6PR1801MB2065.namprd18.prod.outlook.com (2603:10b6:405:6c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.21; Mon, 22 Nov 2021 07:59:26 +0000 Received: from BN8PR18MB2482.namprd18.prod.outlook.com ([fe80::bd01:a119:9bbd:1940]) by BN8PR18MB2482.namprd18.prod.outlook.com ([fe80::bd01:a119:9bbd:1940%5]) with mapi id 15.20.4713.025; Mon, 22 Nov 2021 07:59:26 +0000 From: Rakesh Kudurumalla To: Thomas Monjalon CC: "stable@dpdk.org" , "dev@dpdk.org" , "david.marchand@redhat.com" , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , "ajit.khaparde@broadcom.com" , Jerin Jacob Kollanukkaran Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails Thread-Topic: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails Thread-Index: AQHXfYd7L4dTcIZ+J0yRnIum/STvbqwAdsEAgA94qwA= Date: Mon, 22 Nov 2021 07:59:26 +0000 Message-ID: References: <20210720124713.603674-1-rkudurumalla@marvell.com> <20210720165052.606038-1-rkudurumalla@marvell.com> <2935187.TuyvbHr83s@thomas> In-Reply-To: <2935187.TuyvbHr83s@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f755aaa5-9817-48d3-d5de-08d9ad8e0142 x-ms-traffictypediagnostic: BN6PR1801MB2065: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lInm0SnW/gw5UE1lrjxZx7zRVHCwef9FDeZJhKouYqj4oCER2VNyNDTvn3MjmjPYQyKJLFXDbXFdF/7J+uXRdldP2VdCHbI5YcBNlE7XkoP0Xxdsd5PmN2DRkrC4cLwHVDur0xyLBEjigSZljl6iL9LmjDJkko3yBKVqlYYPF0ZsWvWprxMR7II5vptj5ZMbFhlq7zeFgN+/c1wiIced9ZfRwWaYHhxOtVnZTVGY5kkHTSins3uoBQkVF4UwCa0+jiu/ysUtPC1dM5J/yqr0rfiuTC0dU3+FITe3R/a773AJO9FM0ixYyh+1CTYWOpeqvUwDB8ka0ZMtxzpiIaHy+Zy/no+SP6nOpHpOHSRWZHoyld4IKoGGfZToeGJ+LvOmx562VoNyVv7NiL4/qE2h1E+cspdHTxTJAQPJY291rbposAOjrs8MVnb9koGCMXE7yvMoYRIJcMZ/dRfA3d17xPxw/M6JuxPPTURw4CrIe2v+YME7hQZFP85q/RtSLKq1hazeA0fWEqhS3JFLdb5Yt+PAFUk5dNKT13JwYtVxA5V2Wvl711KP+RqCe6fGYPLvnYQIci60K8QeR4s1M4hYy8OAysRT1C51kW2dqn+dtG8B1cph7P8/ZTyzYHZB5dc/EteuZ/rDzxt4DZsHzO+ecV6jHR/J9Zw10J7Md/2qWTW3lHoKa8fxcPE28txqtvA9lXq9cOUsox7WAiR7sGprgA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR18MB2482.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(71200400001)(52536014)(316002)(5660300002)(8936002)(122000001)(38100700002)(54906003)(6916009)(66446008)(64756008)(66556008)(8676002)(66476007)(66946007)(55236004)(76116006)(33656002)(9686003)(55016002)(38070700005)(4326008)(26005)(107886003)(7696005)(83380400001)(53546011)(6506007)(186003)(86362001)(508600001)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TkLELVNxkM+MlNDz5CqAEHeQxg1MHo7YBTd04nmaQ86Ry0M7keh72T2KMgYB?= =?us-ascii?Q?JcDO9sKK6rEGP8IybMaQk2PtkJD/89/iY8VnUTVVNP5EpMK6RVEP+lENm2HE?= =?us-ascii?Q?6OwiZfzBLmgTe4u7ghcyKUT16ec5Ncvmj0QHYw0InJTxrHG/ZQXd7XBXTIF5?= =?us-ascii?Q?dwGRhFm/qjllrWLjVA7mo2rCBBEru7RmNjYg6OkgEpPAozDzQDDSIiFOBlVy?= =?us-ascii?Q?tRdydYxARh/2KE86hqoSfPZZLwozvBgl8J5AFDmMazvuCVtmLv+W1ax8H9Jk?= =?us-ascii?Q?EdqNyk2GoNMgD8eetyyVPN//Lk9oXWSP33JVcxedxrz2e3czgjta2mO/LV1W?= =?us-ascii?Q?dqmwNWzMdVPE8czeX7En+UY4GJy2GXoUWVis4g09mc//h+A8kZPwCqT1fYge?= =?us-ascii?Q?kRa0zC3JiuGqhZ3Hu4O5Q4n1GeKckfr6VhgBGW/J95r5K9hIwLea2+mDL1KP?= =?us-ascii?Q?uT8tbM/o3+E/8StOwuk7BOy+t64u1vtp0T6iSPL8kf/tO7pXnLggUNtpYK33?= =?us-ascii?Q?7KwCCSIukuNMypQEOKpnNgSjmWpn5lu8yfK0Rv+RUYCWPZkNZrwdwP9eP4V5?= =?us-ascii?Q?XXd7S1jApbo4hC2eETq0uyiqmGKkw9upYypiZa8tznURYGlYNebFGFB6er18?= =?us-ascii?Q?Y+y7eamuf79Vw2eLfIAYkyAWpRzks7XW1U4Npe1VxVWc5nxsKwU5kOrk9wZg?= =?us-ascii?Q?O7YDpLEquATzbYgwLkkSPppH5Z8TURtCWoVo4e8AOXtTzrswoiUNKlSXdmqo?= =?us-ascii?Q?0eTN+9tsDEyPI7KMET7Qotyju/20kHAqLujYTRuN6twibg1ogHBubFr6WOT/?= =?us-ascii?Q?76PY3n2Qo/v+0t2QIpTEUlIIjY4NN/E+F0XgFifZSfQimbqgWaBPLkb6PRwL?= =?us-ascii?Q?TTuo/xLPuGVrpCRGBe03JH56oCMSazn6NAV3Vsg11lp1r1Tz1KcU2r0qYO4c?= =?us-ascii?Q?ergjzBHQOMMDECozgWWniJdCjNgS+wfCoWDt9wYefNg5WoOqZp0Xvt6bfpdU?= =?us-ascii?Q?YzR67YsFBJiG4UAKmaRbascBC5G4fkWsfh7/JGJ5UCwEQe6vz91quGjp6Fb8?= =?us-ascii?Q?M9eLDQda7FaivdQ0JeD2UF6o/32sNpxDxU40clUixZQT9ihdxI1zxaSXvrkd?= =?us-ascii?Q?BUwsWhSwHTjx3lXAVguSpiYTyQRsG6F0TINTrfjiY59dPOsZw6tz4sffWU9G?= =?us-ascii?Q?YPeBt5nqeWCwt7dWmv2/xBuyzOOJ+uFg9k3NtbckkT+TT6y8zZkB11q3+WyX?= =?us-ascii?Q?gxfTty/RmfdyaLNKzGGmJIExWFuKH0twOp8YpwxZVEe6vq4bH2n6MfYFQaiK?= =?us-ascii?Q?KEl7L5JiiodlYF2ogfBC70kCjSww29FBW0M42LbqHOwMETjsGPQLwQyjlRhU?= =?us-ascii?Q?7fVLX4UoLfn3V1uJL/avfAjvxRDOiPHCRbsPhiAp1ovqfz7A1O2AC9pznl4D?= =?us-ascii?Q?15bS/KWr3cDsliFQ7nBfbOxxnHDK6YHNSRrwctapN8YU7UU6E6dY/iAebB1C?= =?us-ascii?Q?K8h8x3Ps2Iy3L1FGvrKOnh1LhOLnAeQG3srPMFPlqOVuAwgrhvIf5XSu2M3Z?= =?us-ascii?Q?1ALryf78u8PTsgw8tP+p/700rpLn3GWUFE9Hau6W7u0zNSxpdS+hy3O/0Icr?= =?us-ascii?Q?eQ8c9ALt+3xS4O5NlCKTl5C51CR+eXJ0LVAkTUqh9T+6EGggtwzBsD6wkKnY?= =?us-ascii?Q?KL+BYw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR18MB2482.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f755aaa5-9817-48d3-d5de-08d9ad8e0142 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2021 07:59:26.6645 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gucOWrkSgF21wD8HLiIMYsyi3sFo7SKytVJIvVjr/7z0G2ymCKt4LVvZTp5FgOYT6zVOveWSuU9T7IIb7RcTuUhiE3aMHJLtWA5OgQjuRQg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1801MB2065 X-Proofpoint-GUID: gZlWoNBfh41STorKudcZ5EzBEZYEWoEj X-Proofpoint-ORIG-GUID: gZlWoNBfh41STorKudcZ5EzBEZYEWoEj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-22_03,2021-11-22_01,2020-04-07_01 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Octeontx2 driver is failing to enqueue because hardware buffers are full be= fore test. pmd_perf_autotest() in continuous mode tries to enqueue MAX_TRAFFIC_BURST (= 2048) before starting the test. > -----Original Message----- > From: Thomas Monjalon > Sent: Friday, November 12, 2021 5:02 PM > To: Rakesh Kudurumalla > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com; > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > ajit.khaparde@broadcom.com; Jerin Jacob Kollanukkaran > > Subject: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues ar= e full > and Tx fails >=20 > External Email >=20 > ---------------------------------------------------------------------- > 20/07/2021 18:50, Rakesh Kudurumalla: > > Current pmd_perf_autotest() in continuous mode tries to enqueue > > MAX_TRAFFIC_BURST completely before starting the test. Some drivers > > cannot accept complete MAX_TRAFFIC_BURST even though rx+tx desc > count > > can fit it. >=20 > Which driver is failing to do so? > Why it cannot enqueue 32 packets? >=20 > > This patch changes behaviour to stop enqueuing after few retries. >=20 > If there is a real limitation, there will be issues in more places than t= his test > program. > I feel it should be addressed either in the driver or at ethdev level. >=20 > [...] > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args) > > nb_tx =3D RTE_MIN(MAX_PKT_BURST, num); > > nb_tx =3D rte_eth_tx_burst(portid, 0, > > &tx_burst[idx], nb_tx); > > + if (nb_tx =3D=3D 0) > > + retry_cnt++; > > num -=3D nb_tx; > > idx +=3D nb_tx; > > + if (retry_cnt =3D=3D MAX_RETRY_COUNT) { > > + retry_cnt =3D 0; > > + break; > > + } >=20 >=20