From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 46910A034D
for <public@inbox.dpdk.org>; Tue, 1 Feb 2022 07:30:51 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 35329411DF;
Tue, 1 Feb 2022 07:30:51 +0100 (CET)
Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com
[67.231.148.174])
by mails.dpdk.org (Postfix) with ESMTP id 1E2C040685;
Tue, 1 Feb 2022 07:30:48 +0100 (CET)
Received: from pps.filterd (m0045849.ppops.net [127.0.0.1])
by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2114uaYF015203;
Mon, 31 Jan 2022 22:30:46 -0800
Received: from nam02-dm3-obe.outbound.protection.outlook.com
(mail-dm3nam07lp2042.outbound.protection.outlook.com [104.47.56.42])
by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3dxna1sy76-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
Mon, 31 Jan 2022 22:30:46 -0800
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=X3d0P9lkoDXHCjGUoWXc7oI7Lqg68J7//uiXH03GymHLADsV536gQk1eMEEoyXkq7tSStKZDB2BA3KBByvRtXdyXWYkooP7VF+GLqhTRTYH5hc6PCKzu5nb61zW3JTjdIQRhkUuIGtFjTCJG19JOjDwuDaofVW8nO0+gFdaGMPFk0JdIDGCfic8B4tayDzO+FApymwk6OHhyCn92DHMf7j+ZWlsQ5Uey4+UP81ihWF7gavgN/4pf3RXYAD7dsKsIa/BRo/pMk0p+evjRuit4bwRcPgchwY84QbN198vluVFj9DRV8YEDtTCNB6BvYAQkCcMnQD7jcbtCD8r/6/1mCw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=ZV40E5hLQAPx+hDx1rbW3zZ0ch4hgWxsS5dbcsG62C8=;
b=gmv9EuC6uaht7XaEJFT+gLQ0dx5fc7pCN+jLW1aq/CrzAPuDXOuSWH4TeAZOorNqENvZ5Gpjey126zGOsctpUb4EpcueJQK0Uvsmo3N87fnNGw6osy/v3TAf/GsahfADNJ/tY0O8jEX9p/iqwn14dUwt68ETaM2VrxpITUQxb7POPMLjwQbXGhyhdglxIXXqO5MEUjjGcRLJow62vFLQI7iSxWMHxXBdKKTCgGl38yOkjZ2A8E1rAOU4c+yzs+iUDGqziSj1S2uk2vUSTWF0cAp/Dj/MnnsmXx13jHv6d2wP5h3k9jjwAnhF38sDCUGA/vL2Gzzal3RNfn+/pOkTTA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=ZV40E5hLQAPx+hDx1rbW3zZ0ch4hgWxsS5dbcsG62C8=;
b=rbcoJZFWFe0RpaqkqOyjToaawQHvFGcGVbxxfSA8OwljcscQD/DuB+3yEarTm4JXEK/9U4nMXQjbXkMtUrBzApdrYC7FjEFxnZuQW1XABbYQqfYNBHTQ9p3OXOUlq+tZKzydhX75d1s5cIEHeLeTSzdbHrXW7HGR2NKCKtGZRl4=
Received: from BN8PR18MB2482.namprd18.prod.outlook.com (2603:10b6:408:9b::23)
by BL1PR18MB4199.namprd18.prod.outlook.com (2603:10b6:208:31b::8)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Tue, 1 Feb
2022 06:30:45 +0000
Received: from BN8PR18MB2482.namprd18.prod.outlook.com
([fe80::8daf:8841:22b7:2d9f]) by BN8PR18MB2482.namprd18.prod.outlook.com
([fe80::8daf:8841:22b7:2d9f%6]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022
06:30:44 +0000
From: Rakesh Kudurumalla <rkudurumalla@marvell.com>
To: Thomas Monjalon <thomas@monjalon.net>, Jerin Jacob Kollanukkaran
<jerinj@marvell.com>
CC: "stable@dpdk.org" <stable@dpdk.org>, "dev@dpdk.org" <dev@dpdk.org>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
"ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>
Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are
full and Tx fails
Thread-Topic: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues
are full and Tx fails
Thread-Index: AQHXfYd7L4dTcIZ+J0yRnIum/STvbqwAdsEAgA94qwCAABO0AIAK+z4ggAAJdACAFc2x4IAsMZVQgCJoOxA=
Date: Tue, 1 Feb 2022 06:30:44 +0000
Message-ID: <BN8PR18MB248252B7B98FFEB2FDE77C13CF269@BN8PR18MB2482.namprd18.prod.outlook.com>
References: <20210720124713.603674-1-rkudurumalla@marvell.com>
<2704266.42xP9hQJsM@thomas>
<BN8PR18MB2482B2E239B0CB7215B2D84ACF669@BN8PR18MB2482.namprd18.prod.outlook.com>
<4821372.GXAFRqVoOG@thomas>
<BN8PR18MB24825EC5998D3F9CBD55973ECF749@BN8PR18MB2482.namprd18.prod.outlook.com>
<BN8PR18MB2482AD9B6C4FEA0BAFB95635CF509@BN8PR18MB2482.namprd18.prod.outlook.com>
In-Reply-To: <BN8PR18MB2482AD9B6C4FEA0BAFB95635CF509@BN8PR18MB2482.namprd18.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 81eb6069-cb71-42be-8da6-08d9e54c605e
x-ms-traffictypediagnostic: BL1PR18MB4199:EE_
x-microsoft-antispam-prvs: <BL1PR18MB4199380FAC67CE052C873E83CF269@BL1PR18MB4199.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 1h/77bVakm6ThaHYdBNqR8VhLgOT3gZbPnIOpZ+0urSpnpdsrN6Uz7wkYdFOMXpEBpySbk+n/iziTVeCwB6Rr3ifCCnIH/enaaYAmq7L59mCOpHuCsJDrO3zPIe24chywKpw9hI7dHvYpxG40MCZwnY34Zbo8J3wHGDlEftbVjTztwZMEnf04IZZf0T5d2pP3IHDNwD765e+gsrCa/47QTL3KdxszK44BzV4jE6ddZTApywfeXerQglbTPvCRHlEx/jUTuyUEf35CVRLFVaDDrb6zpAkSC6DLEQov2ZFRbJZS2kNe/I2Uw7ltUgbdOc1ZU7/OsNc6l8W/aYeTmVMWhEb3IfdhVxzM3XO5VzJOiChot1G10wVy4fqhXQ8zU9phe8TeXk/IBmG9UjTrHSaJl1r/Ohg9u+jdxKgdjNiFLo2+jiQkm6YPdAE7R3EOTlx0yO9vZfrp01Ui8/olCuHWdUQPEDWyeA7bqHujunKtJ6VsNkRwH9jQozz4FDX+nQwUWbXRYGH+1zmCFZr+CMTVPSAhRES336gguqUq1K+ASU8wM6TSMlrjI0N/dkOebt7+97aTHZKW1iWGlH5r0EWpcVGE31gsYFQLfcFR8S5XUaED0kvJ4rlg5uQ/SAk1Pri0ibusiIoGuvrJALVjvCqoQsDkjpjj729wjbqZ/8EMvwJDLcvJkCe8xrruhXjcHdWPf9wuNe36cx7MRf9No+h3A==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:BN8PR18MB2482.namprd18.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230001)(4636009)(366004)(5660300002)(83380400001)(2906002)(110136005)(54906003)(6636002)(52536014)(86362001)(38070700005)(53546011)(71200400001)(4326008)(26005)(66556008)(76116006)(8936002)(66446008)(66476007)(186003)(8676002)(66946007)(122000001)(64756008)(316002)(38100700002)(9686003)(55016003)(33656002)(6506007)(7696005)(508600001)(20210929001);
DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ILIQGmmERpHtigkSkWBFTiRAeNDO8jJN8P9S7jy7zAz09o2U0t/tWkEyFupB?=
=?us-ascii?Q?J1eq3glAV/ukrgiVY8CUFA7Yqm1FepQNrAr3kk3WwVElvi6nh3zojv8Eu5iv?=
=?us-ascii?Q?WpxXC3NGbOWkMSXyAFGpENyIUJteLnliqVhJbYKA4uvM+Q/j4dM96X7VM9y9?=
=?us-ascii?Q?a0TfEcz1B60jO1CrXf6qFZmAEWye8AuHf/z1abI1xb+epqQDbwLxt6Lm0YvU?=
=?us-ascii?Q?FgulzShJd95Ik78F4lcxeYRg9IMkIoP4Mwpos9D/LfJ+dWvv28UvQbxU3//W?=
=?us-ascii?Q?ZkOaWBHGpEVXxmP19phpFDX4YwF7tvzsG+bO45mgaJYWbgcqW1xHTkfPQea5?=
=?us-ascii?Q?ofkrhjVp5FD7+C8J5boOz4cJ6yBZ/k0L5byxPoYs03akDYY4u5ovnnkFjRvd?=
=?us-ascii?Q?yWwPzxTQyaKOMotAOYv9pMdxkWmcCQGcS5QRibsvAQqp6KbQsJjvvs11cb8S?=
=?us-ascii?Q?eI2qvnYeuJSPvpP1spU7dZxIksZX+pzAmWh6TyG8IaCr0Dj9J3eltCCuMmO1?=
=?us-ascii?Q?/gurneERZqRJghuFCWjtF6l28oHmppch3Q6dzz8BYzU686WGVCAcWTV3MUDt?=
=?us-ascii?Q?ey0+81OTCdi7zo1R+fASn5QwEsSHC7Kfuy65QJQIh0ODEXDXMKSaGFGKgPlv?=
=?us-ascii?Q?DWwk1uxVaJ/+hjqQE+2oxsRPPLdPUleTlPJx59AQlsZ5MpsO50bw17nV0KpJ?=
=?us-ascii?Q?yyFeyWR4gS3JOmnAiUpxG8qxqsG4OpGnZUlJTZNVudYzJryxJ+kC5um1qSoN?=
=?us-ascii?Q?oQvunWCuoga+pZVCenuB0JbvlrhuTKUtF+Qex2h/xrA1JH0y7vunJexBy0Ee?=
=?us-ascii?Q?tw9EJchwg0R9XZYxHkj99A16mgs3Xiq64gFUyvXG+MJgy25dgHXnJcuIKhd2?=
=?us-ascii?Q?kcJzECjGDTmtGL/x6UFD9UXKxub+FvwEVbWWX3+B7uYirkCu3OghhcTzfbjC?=
=?us-ascii?Q?tMCqBdtATkg5+8SEk2q6sr9UXzk/ROWLjgmAT9CTC2e1A2vPSB03yujVZXME?=
=?us-ascii?Q?IXdma7v6Q+O5rsic+Tn02vtzRatKt8JIwDBHAd0rFAsZxez0XZHTWsf3iExx?=
=?us-ascii?Q?9qWpSClU8OooJp6c7liwSnabTAPnkNCI8+EEpxnaMyc8z54iHYrU8lAr2Z8k?=
=?us-ascii?Q?L6bXwT/JMQcZbPs3FupMTBg9LVSnP8cJsGYwCz9Es4CDx9XhbpM5DoX/eAxJ?=
=?us-ascii?Q?7d6b6DalDmby9Ol1hhbGTaz/SAsTkbVJtnnI88mhKc0c4VSIkLymcaZU+lEc?=
=?us-ascii?Q?TttX885x0gcD0KXnzV2eAqvq2kE0XipuztLT5z9woJ5jrKqIKJfTMC3ZaA9k?=
=?us-ascii?Q?zHu1lcqWHw9tGB+Q3f4uIHnc0IDaIfjVbXM8+N2k/cqfuzyGWvSpN0AFSbmi?=
=?us-ascii?Q?1GrVVjI2zHmnt/jPsS4YGsAjfXEFPbwVoELU8sdrPOQt6DuZ4TITz1S5GWV8?=
=?us-ascii?Q?MH0xn1CYPQER1hqiJtTRNvPBgda+ZYhjhVOc8bww0zRw5qgqonK3a5U/diNb?=
=?us-ascii?Q?atQNpzggKhsyKMATrJbzmlmAqPi5QVnnC9vNVrrqfbaPV+xolNi+2749xk5D?=
=?us-ascii?Q?PNN5/IjImT8kTk+goiVUTMv1Aq5B6DaV2WvGBF7pxKWXmIu4WQ+oc5wk7nck?=
=?us-ascii?Q?PqVrSA90NsO7sVTs2//k5J2Ckyv6GzKmpMbb4SgY0Dersv95EIh5pCwpaQXT?=
=?us-ascii?Q?+Gv3Dg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN8PR18MB2482.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 81eb6069-cb71-42be-8da6-08d9e54c605e
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2022 06:30:44.3908 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4FfH5uFqeDmbXJqrxkhX1FAo8Qdl7txqFT3LNvDa4Y9z0s/7XDDCV86SxLveix3/vF3O3UbvgBi3YuWT/Ae49U9dFoI+xzxXoBR8ggWWgQY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR18MB4199
X-Proofpoint-ORIG-GUID: x3bpiqN4OJWDbYp1VEKGi9en9dj040Gm
X-Proofpoint-GUID: x3bpiqN4OJWDbYp1VEKGi9en9dj040Gm
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
definitions=2022-02-01_02,2022-01-31_01,2021-12-02_01
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
ping
> -----Original Message-----
> From: Rakesh Kudurumalla
> Sent: Monday, January 10, 2022 2:35 PM
> To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>
> Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> ajit.khaparde@broadcom.com
> Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queue=
s are
> full and Tx fails
>=20
> ping
>=20
> > -----Original Message-----
> > From: Rakesh Kudurumalla
> > Sent: Monday, December 13, 2021 12:10 PM
> > To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob Kollanukkaran
> > <jerinj@marvell.com>
> > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > ajit.khaparde@broadcom.com
> > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if
> > queues are full and Tx fails
> >
> >
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > Sent: Monday, November 29, 2021 2:44 PM
> > > To: Rakesh Kudurumalla <rkudurumalla@marvell.com>; Jerin Jacob
> > > Kollanukkaran <jerinj@marvell.com>
> > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > ajit.khaparde@broadcom.com
> > > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if
> > > queues are full and Tx fails
> > >
> > > 29/11/2021 09:52, Rakesh Kudurumalla:
> > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > 22/11/2021 08:59, Rakesh Kudurumalla:
> > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > 20/07/2021 18:50, Rakesh Kudurumalla:
> > > > > > > > Current pmd_perf_autotest() in continuous mode tries to
> > > > > > > > enqueue MAX_TRAFFIC_BURST completely before starting the
> test.
> > > > > > > > Some drivers cannot accept complete MAX_TRAFFIC_BURST even
> > > > > > > > though
> > > > > rx+tx
> > > > > > > > desc
> > > > > > > count
> > > > > > > > can fit it.
> > > > > > >
> > > > > > > Which driver is failing to do so?
> > > > > > > Why it cannot enqueue 32 packets?
> > > > > >
> > > > > > Octeontx2 driver is failing to enqueue because hardware
> > > > > > buffers are full
> > > > > before test.
> > >
> > > Aren't you stopping the support of octeontx2?
> > > Why do you care now?
> > > yes we are not supporting octeontx2,but this issue is observed in
> > > cnxk driver ,current patch fixes the same
> > > > >
> > > > > Why hardware buffers are full?
> > > > Hardware buffers are full because number of number of descriptors
> > > > in continuous mode Is less than MAX_TRAFFIC_BURST, so if enque
> > > > fails , there is no way hardware can drop the Packets .
> > > > pmd_per_autotest application evaluates performance after enqueueing
> packets Initially.
> > > > >
> > > > > > pmd_perf_autotest() in continuous mode tries to enqueue
> > > > > > MAX_TRAFFIC_BURST (2048) before starting the test.
> > > > > >
> > > > > > > > This patch changes behaviour to stop enqueuing after few
> retries.
> > > > > > >
> > > > > > > If there is a real limitation, there will be issues in more
> > > > > > > places than this test program.
> > > > > > > I feel it should be addressed either in the driver or at ethd=
ev level.
> > > > > > >
> > > > > > > [...]
> > > > > > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args)
> > > > > > > > nb_tx =3D RTE_MIN(MAX_PKT_BURST, num);
> > > > > > > > nb_tx =3D rte_eth_tx_burst(portid, 0,
> > > > > > > > &tx_burst[idx],
> > > nb_tx);
> > > > > > > > + if (nb_tx =3D=3D 0)
> > > > > > > > + retry_cnt++;
> > > > > > > > num -=3D nb_tx;
> > > > > > > > idx +=3D nb_tx;
> > > > > > > > + if (retry_cnt =3D=3D MAX_RETRY_COUNT) {
> > > > > > > > + retry_cnt =3D 0;
> > > > > > > > + break;
> > > > > > > > + }
> > >
> > >