From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF033A0032 for ; Mon, 13 Dec 2021 07:40:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8309240042; Mon, 13 Dec 2021 07:40:20 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id C172940042; Mon, 13 Dec 2021 07:40:19 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BCLuUr9004108; Sun, 12 Dec 2021 22:40:18 -0800 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2175.outbound.protection.outlook.com [104.47.55.175]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3cwc2ju28h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 12 Dec 2021 22:40:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GxWnoySj9TCBsO9VHEVad2hmiirn0WFhLVJyez8gkzQysC/OsAONT6LA7yUvqxcg3VW82gLyyQ8Y4C7bU3qrITC5IcxE1ykJsksDxr4P+5KRfGaou3W/Emhc5U3Trx8pCTWnX8vPPQl2eCIcaoA4wjDJ0TT5rvIi6igUwcxemE4dhbXxh+ZYPFPNPaiX8xOa6YGxkQnQBDastEqTt0o9lHB2GL1EwhShFs0ZGRmYsGQUkgmmPeGj0Kw99Y6i2vJO5g0QxgfmhliHoOcdG9FkA/3NHWYt0PNg6McWehQcB2MBcx+/MDlrD9BxTWaUOFoeerqj6WKJmQwEgnWBA3cI1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eoTkvqV6sj59K0qWrNbxCcG/i1tcv6NdlhC798mv00E=; b=edHYTULOmvi9hUOH7J+zRb9ObhFf/VH6Sbzm4rodpH2bovF1re0fodcePxqqO+/WOjw0Get23H8/fonSOmaHUxpt2fhLRQUqj/KVPH1ZWJpNXZKhkPajUzDqiq4f4dLe+r8FstHECYkWjuyJFitXdrvecznX/KbqvnBoLZST08D/AVRcpZ4nBnzHmAhhvNdw2KAuH8diSCZuqU/lIo0juPxuZVGlI+Vr7DcQgtcfOwbXTConfrZVVbH+i3LY8ugFnw4sT2pQkz0nnL9XCzQdGYwOWkcb3uH7QsdbEaeWAWDqNjAUkxDcMMYeCUr2aDoHcaOqFGbr35klln90Ov3/wA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eoTkvqV6sj59K0qWrNbxCcG/i1tcv6NdlhC798mv00E=; b=EkQjMvf7lkq5HXT/PpuNWtQi2OJgt4wG5ERYL0JuZOgmqb+RHWWU8+pMFRPBCvqUcHG5ddTY7wnXvxQ7EWrhtHZSBn++CD+5NOlc7Es6vPa7Oqr9aLDo7ZkZLmCdzc9JnVGRYtfWPH0EDTFINll/XtwnWe8AXZHHzeKKN/k06xw= Received: from BN8PR18MB2482.namprd18.prod.outlook.com (2603:10b6:408:9b::23) by BN8PR18MB3058.namprd18.prod.outlook.com (2603:10b6:408:71::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Mon, 13 Dec 2021 06:40:15 +0000 Received: from BN8PR18MB2482.namprd18.prod.outlook.com ([fe80::b893:2c9a:7b86:4103]) by BN8PR18MB2482.namprd18.prod.outlook.com ([fe80::b893:2c9a:7b86:4103%6]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021 06:40:15 +0000 From: Rakesh Kudurumalla To: Thomas Monjalon , Jerin Jacob Kollanukkaran CC: "stable@dpdk.org" , "dev@dpdk.org" , "david.marchand@redhat.com" , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , "ajit.khaparde@broadcom.com" Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails Thread-Topic: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails Thread-Index: AQHXfYd7L4dTcIZ+J0yRnIum/STvbqwAdsEAgA94qwCAABO0AIAK+z4ggAAJdACAFc2x4A== Date: Mon, 13 Dec 2021 06:40:14 +0000 Message-ID: References: <20210720124713.603674-1-rkudurumalla@marvell.com> <2704266.42xP9hQJsM@thomas> <4821372.GXAFRqVoOG@thomas> In-Reply-To: <4821372.GXAFRqVoOG@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 15059e11-4a3c-41d0-183b-08d9be036bad x-ms-traffictypediagnostic: BN8PR18MB3058:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6C9vCWVBBhgs+i5F7jUFMJlVxx37jEb34wwMTci7Yjd5s+ncqokvWKmIwyWdcc2q1sG3rMWF9tcWoXj4QpleOGCvlWhdJX2wQRw7TVWkERLlJJYK7hmVmnMbHx/cGnzODyXqV3hkaOenHPIDUdFXjFeeCzYZZ9co7eZsfsYW/zziL3XG9BVFmhCOmVcp7WHi2wlQkV1I2wLatDdHkR2LgSNOa0T+VcJ0TxrfPSj5sRk6PjRgO/ALdAFY3GTJKySPHTu6GtpWqnhNKoaW8RHc/p51/wtOUhlWmrSQAX4ZTlOpKEBnuTqvVU9t3mFTJRBvWK729DtGc96lxJkhxkElG3/xRSdYnBh7FAJW5SAK+cGelReNaPr1uwyGXjl2yorFO490f0cRr1hXB74be9cpMDZDLL7Y+8HDmfS2dCHSMeldk4VWsKQJ6LmDugPXTbBUg+SfUmwsGZ8uoNEVKjCzGS1ldVvAqS6EmnkKjyeIpPVFTQDqsM/PwAnA5nkKVberAKlRiMzN+c6HkSbHyGjPn7IflHehZRenDxVPmBHsbFkBGQAis0azFiKmRcJB+closOmpYLg+D/XzVhXKBAL9vITgKucB9Z5mhRxLjlbUb+DuTtnhxiAKEZ5rofpbWk6yv4AsUSGyQd/MvD86TkMncEk8ZotdWsnO9P5SBdiP9ZzUmmuGI3hlyuYTiFBHEY39P+vAUbjCfgn3FhPt39pCBg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR18MB2482.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6506007)(66556008)(7696005)(52536014)(86362001)(83380400001)(316002)(2906002)(53546011)(110136005)(66946007)(8936002)(66446008)(66476007)(186003)(76116006)(508600001)(54906003)(55016003)(26005)(122000001)(6636002)(71200400001)(64756008)(5660300002)(33656002)(8676002)(9686003)(38100700002)(4326008)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cocfAf0wQjWKEqLVpZvdeEc1IS8Ka0ZCuojTPnFympidmoKczbYYTB5fQ2aw?= =?us-ascii?Q?QkyxJpL9Fz4oTB/Zjtc2mbth2rOIMmV2gBuGF8Z5qo2v8aDvOT92QNzAYLEG?= =?us-ascii?Q?yZEpiVQ2jK9mCydiy3a9J6yGngVoTFJp+1OrX5nrJCyX0VTjwSJLXZn9HoQg?= =?us-ascii?Q?JrF8d7D6Oexpiad/+z3Nwajcq2val5oDTqE1n2xTdLsYwJgABqSD137KEs+F?= =?us-ascii?Q?jhidkYR/L9s1dkISEbTrNZ5er8GoMBCwwvqq8L5vvcUXuSJYZwh429ex97iW?= =?us-ascii?Q?ztoXO5doPiAGegRZN8wN5QHd2TtKX7Rib+OtB6B5UqWjbZ6WLDehAywn1T6p?= =?us-ascii?Q?t23Y2E2D+9JIi/COn9CIxroiH9Vjs1A0ZCAKVlwx9Ih6bWxdNOMuOJgcSudV?= =?us-ascii?Q?E4PU2AH8FvfJYrN0LiW91yzzXK1sx0HnVXZCZ0bQpr+JJ+rOy+37SNYx/Z7I?= =?us-ascii?Q?lRCEO+ZEWwi1bjB9PAsTiFuxJ0Lxt8mKFtjjqx1FFpfgPI888XAjl5OWrHaz?= =?us-ascii?Q?iOeFbhwSP3as5s30wb7ePCvw982awj2lVeqWsgVcmpkI9IlfMrnXwlgRDsbR?= =?us-ascii?Q?MuowrYdJqi1xYwPBiLKdH3pMu4qJ7i0QJ0m3XTebG9O0O9S/ozhSLEJ+EDRC?= =?us-ascii?Q?6OaGEwb+pS44130bPRZykH8YbfqPAuRYbY1oxjSVjYILpFhxDl8oZCUoZ8+R?= =?us-ascii?Q?emSGWQwC129HQMu7GiBJo4fZOla/OQ1sDPUaYgJZ+XJemEFqhD2p97fpzr2q?= =?us-ascii?Q?sxd17nUZVHwY5agIlRUqHRG2nU/drweOcpjBi+jYrpkF65ntlFQ5t0drSR6p?= =?us-ascii?Q?STnVLS9a9shyu0XEmYiHH4SHvWx4a0p0On2s3VHVlhT7eJcTUD+js/xJ1KuY?= =?us-ascii?Q?zxl8RiIZOblIvTQGsBvvV7euuetgr5FzJBM26naUZ4G1Rs9cs2wY8k4dnskx?= =?us-ascii?Q?RkYH87JwPYrh8hDwFpqXET0i+dIqmVdpbpYtaVN8fGKcl52vUbqiNy55b3OX?= =?us-ascii?Q?rMGitkfeiXTbSn9geWZEzE/dmPsAoWpD0AnYwED5ZDlV8TjELsxc8IibBYkj?= =?us-ascii?Q?MrgF6e3EBSjD/UhtcYVrEU2G2VPGYSHWEDYFuBd9mjQVFdijHXyCiOKb+3mz?= =?us-ascii?Q?MOTg+Pk4kIaP2CC+NCv8KBcSNBqn2mq3IJN1KvPwOl6BO0m4Giy8eP9lG1S3?= =?us-ascii?Q?n3Bn9DWY1V2EPAi9J5KecHBALwqYmlgNBzNIZVxkjSeUxYfZmEm6Q/jzkADI?= =?us-ascii?Q?9e7ztXRBhkVZBFBGMTg4J6xiFwMDCl/Ekog6ntRr0bqS/On3+CxzAggMuOyG?= =?us-ascii?Q?5QVvhvxrCcK/5NQk0PPfzKusNSV1t390ciokA0yPg0xo8uePCmSSJ5Jn5NBw?= =?us-ascii?Q?7pI0AA2h0YYmvwfa63VDh6ocLVi83hWb4KzIqxsnJvRo5o5Kc4sH+Hb/r4k6?= =?us-ascii?Q?9+LuFM1/DbBC2HxSC/mpmZtCaHaV8XF6HDYkuwewCtaO/JsFvgicfGosZbu2?= =?us-ascii?Q?Smp5Eo1nTRv6UPYc62+7OXEdbyt8UpJqhwSVu3Lbn0+h/XSq5RHUo8KtNliQ?= =?us-ascii?Q?Dgg5+rO/knZNJnGnxcPKV5P4iHNoCfeQwRq55mUsIrcvThxrrH4XvnxtCJon?= =?us-ascii?Q?6zaknLCdhIeZyViDs7XGhVDYQ4Ce06+2E4LKOIU+5QUFX4V7ccBT5ZNF7d4p?= =?us-ascii?Q?TYybHQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR18MB2482.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15059e11-4a3c-41d0-183b-08d9be036bad X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2021 06:40:14.9696 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nqAPWmZCRphH4NiO9R6lGZjXTGXsJ0AEAsrddXgoHg6Rj0ci+AoJqWsdCodBazPFx2/eF/J9QmHAz/ltpfgGX7NPoxKQ3k9hRrZLJUFNQFI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB3058 X-Proofpoint-GUID: 1t9fqBj58qvKz81CFKIgQoUqYknSpwal X-Proofpoint-ORIG-GUID: 1t9fqBj58qvKz81CFKIgQoUqYknSpwal X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2021-12-13_02,2021-12-10_01,2021-12-02_01 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, November 29, 2021 2:44 PM > To: Rakesh Kudurumalla ; Jerin Jacob > Kollanukkaran > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com; > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > ajit.khaparde@broadcom.com > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queue= s are > full and Tx fails >=20 > 29/11/2021 09:52, Rakesh Kudurumalla: > > From: Thomas Monjalon > > > 22/11/2021 08:59, Rakesh Kudurumalla: > > > > From: Thomas Monjalon > > > > > 20/07/2021 18:50, Rakesh Kudurumalla: > > > > > > Current pmd_perf_autotest() in continuous mode tries to > > > > > > enqueue MAX_TRAFFIC_BURST completely before starting the test. > > > > > > Some drivers cannot accept complete MAX_TRAFFIC_BURST even > > > > > > though > > > rx+tx > > > > > > desc > > > > > count > > > > > > can fit it. > > > > > > > > > > Which driver is failing to do so? > > > > > Why it cannot enqueue 32 packets? > > > > > > > > Octeontx2 driver is failing to enqueue because hardware buffers > > > > are full > > > before test. >=20 > Aren't you stopping the support of octeontx2? > Why do you care now? > yes we are not supporting octeontx2,but this issue is observed in cnxk = driver ,current patch fixes the same > > > > > > Why hardware buffers are full? > > Hardware buffers are full because number of number of descriptors in > > continuous mode Is less than MAX_TRAFFIC_BURST, so if enque fails , > > there is no way hardware can drop the Packets . pmd_per_autotest > > application evaluates performance after enqueueing packets Initially. > > > > > > > pmd_perf_autotest() in continuous mode tries to enqueue > > > > MAX_TRAFFIC_BURST (2048) before starting the test. > > > > > > > > > > This patch changes behaviour to stop enqueuing after few retrie= s. > > > > > > > > > > If there is a real limitation, there will be issues in more > > > > > places than this test program. > > > > > I feel it should be addressed either in the driver or at ethdev l= evel. > > > > > > > > > > [...] > > > > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args) > > > > > > nb_tx =3D RTE_MIN(MAX_PKT_BURST, num); > > > > > > nb_tx =3D rte_eth_tx_burst(portid, 0, > > > > > > &tx_burst[idx], > nb_tx); > > > > > > + if (nb_tx =3D=3D 0) > > > > > > + retry_cnt++; > > > > > > num -=3D nb_tx; > > > > > > idx +=3D nb_tx; > > > > > > + if (retry_cnt =3D=3D MAX_RETRY_COUNT) { > > > > > > + retry_cnt =3D 0; > > > > > > + break; > > > > > > + } >=20 >=20