From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 613F6A04A7 for ; Mon, 10 Jan 2022 10:04:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50FF841C25; Mon, 10 Jan 2022 10:04:52 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id BDD564013F; Mon, 10 Jan 2022 10:04:50 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 209NGlOa022855; Mon, 10 Jan 2022 01:04:49 -0800 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3dfy8nj6v0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Jan 2022 01:04:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YmBPoqRhT0+Q4nAVMGp1BWYEEBtKDHeEbc9eJugllfYfEVSUgQezKYbPlHIBsT0XxgnRvp2JpUniN1W5tdZv+hULpQBjy3ykMQWpBB2khYolMbDFT73HPYpD98vryF/rfdLzU6PY0SeEZwjD5Ce7PfQQMbhOzb6Gby69bWDE7Dh5vCR5kB9bOCya6xa0Kb1nUwr9g+LD4xcpsKA7nTUMuH7w4nGwmq3dteaXjktQHgPIqDGUNb6VICTpTSmmfSoHoRf6s5Us5XUrtZlSglOKHQxxIu2tiIkCVym+oVg8dKkTmSLgJKhxKCS18QfoZTWTasoXpi/JPXx3pIQlNM2mYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mp5f221oCqbq8YUxBLnQRiazS2eDZcibg4AWMNpExjo=; b=ZOVzl0/3EgcuMs+nbRA6+3n2Ydqpz2gM/WmNQVKtk8NdJl8J0DRvwlfy3cjB+VLruXmlT+sIAnEKNVB0zgdZ9WUcSt+97dqF64NVr1i9hxdWxVlQM2NxtNlmppW09kpbZGghT+7nLvmNC7pFAzUHKWn1TuYVb3DL8mGHDYa9pTmVRP2M5MO6JfC7gJ8EBgy18WMAIF7SWph5VUsyRfzOhWG7zYDCYTZNau2EzLQbe5wjVYWFnR7LhbBrxBdwcq1xXfkBgcuyVbqrDhOyg5pB1f13bXCNbRfhKwkXZX0xqxqMzH1ovbZoHVV+YfvH7wQ0xaUT1L3neLhwF2fRok21hQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mp5f221oCqbq8YUxBLnQRiazS2eDZcibg4AWMNpExjo=; b=biqRJU5OW1VxiTJb9hz6fI4eShMMpcfiwgXHN6b4me0/C1V5QLTb/yTjVYUlSoTzgmK5YfEoPuBenUuZY48UFiizMye5cQndJI01PnozZkKDcQHYsscIzbN4Emo/syjjDUogLqW2ST1j2B77SWk8VeK0ESxR+USJagiUeX6kHUc= Received: from BN8PR18MB2482.namprd18.prod.outlook.com (2603:10b6:408:9b::23) by BN8PR18MB3012.namprd18.prod.outlook.com (2603:10b6:408:9b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.11; Mon, 10 Jan 2022 09:04:44 +0000 Received: from BN8PR18MB2482.namprd18.prod.outlook.com ([fe80::b893:2c9a:7b86:4103]) by BN8PR18MB2482.namprd18.prod.outlook.com ([fe80::b893:2c9a:7b86:4103%7]) with mapi id 15.20.4867.012; Mon, 10 Jan 2022 09:04:43 +0000 From: Rakesh Kudurumalla To: Thomas Monjalon , Jerin Jacob Kollanukkaran CC: "stable@dpdk.org" , "dev@dpdk.org" , "david.marchand@redhat.com" , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , "ajit.khaparde@broadcom.com" Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails Thread-Topic: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails Thread-Index: AQHXfYd7L4dTcIZ+J0yRnIum/STvbqwAdsEAgA94qwCAABO0AIAK+z4ggAAJdACAFc2x4IAsMZVQ Date: Mon, 10 Jan 2022 09:04:43 +0000 Message-ID: References: <20210720124713.603674-1-rkudurumalla@marvell.com> <2704266.42xP9hQJsM@thomas> <4821372.GXAFRqVoOG@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0476eb89-79b6-41a3-f3ef-08d9d4183e1c x-ms-traffictypediagnostic: BN8PR18MB3012:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6QdAgpqOyBgnpX6ixid77uQ/l8OZUZgl32eRdDRwCni62ojBEjNEee2D6PHZ3FLLSlTKy+zB95oI0dsDMDGMekoz+QM12ZG0436a/qaVC7v6pRU3I5r2FPKhhPv9PcLhocCSLenXKYbpFlA2fIcOXg8Bj/lD+e+/SRln70ZtTftS/JGQWFnJkvP9vuhMy9BYDfAoOTP1kybwIRCrnRTva3AtMGB8cyZTo4UrORG0qqa+9MZZIIzmVGERLAObSokLaOymvty+z6whGCGYwzuOCb7jrXHuqoH/abrtzqvbUuZbB/Xd33Xj19AKWtoYrpCok6JJLIy8fTMgAkRIbEKv16z+t+eMKO0i4RFXXlzLposJmatI+Xu8TgOkALP0hACwt8R74fkwox2PH1Z5KSWdm3jQlRGvK/lMfqSMpfQ9BVzh4OZ9oCGlUXvWDhNQCoPCIVfMvMGt/Pb0tpZ/vGPYQg/etyQc9ztLIamIytRcmbsp+Kbzt6EqB7WkyIex9WPB4aekg8W0oIq1T6MqdmBBc5WXe1E+B79URi644/Hg1bsVmhrjjXlcuBqWnv4RtRd+l34VDIZ6Y0NGvm+tEy7yNebRiKmWfkWKTeOnoPwGA/h7cD1CtX8avY444Qm45B3+YniL4P0RCuStxrw4uxhonu0T7pVYsYlLkpCO66dG6SahHt4IcBtYPs+oedbVfXXhuPjsj6jrOYU/GGzDwVnk/g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR18MB2482.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(53546011)(76116006)(316002)(110136005)(55016003)(8936002)(4326008)(8676002)(52536014)(5660300002)(38070700005)(83380400001)(66446008)(71200400001)(64756008)(66556008)(86362001)(6636002)(33656002)(66946007)(6506007)(26005)(122000001)(54906003)(186003)(508600001)(2906002)(7696005)(9686003)(38100700002)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Bjz2l30YtlGMA1OcBDs02zk39euM8ZAwc+EQG4JgEu+s3T4COCKAC5/atVVD?= =?us-ascii?Q?me45+DMrPFuePseh91jEHq+z6HFGrBr+i1pXiEx7S0wDxCwlm+J0Y+qjtG+I?= =?us-ascii?Q?qRjNZ+ZYuQc5mF3LFnGT7g4hHPuAmVdn3uy2o91zCq88Fbx/SPTJsJcKW4z2?= =?us-ascii?Q?GFaXzudhw4L6l/wIqyS2HY1kk2d0/qIIrVfAO/b54aRQBLAabifOIoeG8RJU?= =?us-ascii?Q?hk4eL2bcx5ZP1nQAUrWLcd6sh3kOdcUTUjDBQDXE/hkY8EkdyugHZjq+xuPJ?= =?us-ascii?Q?vsyqr/LVVsAYKVx7mgmD7LY0UKj3JO2F+pKkQbIEp6vmVej0duKYmmFm3Slx?= =?us-ascii?Q?+btEDBvUlQsBO6cTJ/ud9dJQB3Up8as/o+Pae9xJjW44oktJ0tqVRrirpJP9?= =?us-ascii?Q?EvVLoD6mwoZXGTxe5gGljIjZJVqzuoG4ohFgApkO5eSEQyZ/6Ms+CfI+sWbs?= =?us-ascii?Q?MuAYg2Sof2YJxubmWmLdDGrfTjKinLs/upI5YLWJXrL8GSCctfw8/EiBnjFP?= =?us-ascii?Q?Fm7tstY7s1ToYjP0O3sPSG4eAyw/Gu3/gjfbk0rqTLToXtExVahpSSHRhHnX?= =?us-ascii?Q?Wf1dzYmgA3WcS39J3BttUqDLGDKlKgAXRlpUPBuEM8aZaydfSV//WNwHNhNi?= =?us-ascii?Q?zQuEq1tXQdRJuHL0Yw6xAegkkWJ2KycQWKIGqrAVuhuCPA+HaV1t74PkO4ZA?= =?us-ascii?Q?THSy0akaG9ko9mj2jnKlyfnFqDMidP4mPSIShwTJhJCIT356HnebB+zPanMR?= =?us-ascii?Q?yw40qMZDUWZDliQbCQaPU36ftdTsZPTiPuqyfbQuKFy+JgMfV7dYbwoq/X60?= =?us-ascii?Q?SUoC4ay8gYcsd53jfXE513XUQGXpDSfF4k9DbSg/rcvcz841Uvip+3Oe8ZSf?= =?us-ascii?Q?mTdQTxfAPM7rhlXIhERerqjNPx4GtppvGoA/ndW7J+KdT3v9ZlsmD4GggKN2?= =?us-ascii?Q?VmKfZtJxtxYJR2njojyNypJwuW+9SdBxHRT+fxe/SNB5yog0UCQIONxYSrE9?= =?us-ascii?Q?JPE0TWddTGJTZ9jS9z3So9DVSSbJQCNkAG3bu2IVxlhOaiDWEl19QR/FoSLO?= =?us-ascii?Q?7S2FYH9RZqAaJoCNBK3TSo96GGuU0I1/LfSE48HAI8HwnxfBXnpzgeVC3ZVQ?= =?us-ascii?Q?aU4wBhGnLS/QQ0K6Gsa8o2I97Rr1UzcUA07mxlo+Lrh5uKONzKIwIbYjSdiu?= =?us-ascii?Q?usq4FZfxGMkLB9pFuHnqYXZ7VBzir9I2/cz8mYYtEwBTzK/RdzkbLZhoxIfD?= =?us-ascii?Q?E+/PkZPYBuXiUUyfN2LLtoo4c8zhKvWGhDUM3rrPANzvNGTitvba9z4bRBtr?= =?us-ascii?Q?MKX9mH2ntmS6gGwzy8qFoz3byDcsCjLCftr4EDzw2Ft4Z6PvB1P/OBqVCm+I?= =?us-ascii?Q?wh+FzIWJhoGiGQdO5ktzBGSsFKlxdUHety5Sx+5YhGVkk3Kat+Jez0mMoPoe?= =?us-ascii?Q?Wv8hubzDPYizK7KY/SGkjjMrNxYUBBPQn7NcZ66WDcXALnTYN1pxiuN9VT1g?= =?us-ascii?Q?bUhr5V4oeV0WYQdnbwhAV4spjR2Qti0HMNPDgKFfjArp+rV+GpI86aBzKZir?= =?us-ascii?Q?22CLUctzlNxJqHiLC8nOSrM2A6CptRcxHqBbEek1X3tUsBWTNzZVkLapySZk?= =?us-ascii?Q?uFtU5U4VRXh++147YQSDI7xDU4IX40hmXF3t+1mm7g+Q/Ju0Azh/q3vfp8ae?= =?us-ascii?Q?XB4oog=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR18MB2482.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0476eb89-79b6-41a3-f3ef-08d9d4183e1c X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2022 09:04:43.5243 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TIFUn/U7hUH1rStEtHreuQEojirBqcUy8jLlrdN1dNJgut8ki6S2C2vN85TVgW5qhfYIJ1lI4eremnVquEITt9umWl+jvB6P1zn8KX7lZP4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB3012 X-Proofpoint-GUID: pzxrAdLPjJl1vHrNlb-Ty_yl7Jts3BfK X-Proofpoint-ORIG-GUID: pzxrAdLPjJl1vHrNlb-Ty_yl7Jts3BfK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-10_03,2022-01-07_01,2021-12-02_01 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org ping > -----Original Message----- > From: Rakesh Kudurumalla > Sent: Monday, December 13, 2021 12:10 PM > To: Thomas Monjalon ; Jerin Jacob Kollanukkaran > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com; > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > ajit.khaparde@broadcom.com > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queue= s are > full and Tx fails >=20 >=20 >=20 > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Monday, November 29, 2021 2:44 PM > > To: Rakesh Kudurumalla ; Jerin Jacob > > Kollanukkaran > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com; > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > > ajit.khaparde@broadcom.com > > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if > > queues are full and Tx fails > > > > 29/11/2021 09:52, Rakesh Kudurumalla: > > > From: Thomas Monjalon > > > > 22/11/2021 08:59, Rakesh Kudurumalla: > > > > > From: Thomas Monjalon > > > > > > 20/07/2021 18:50, Rakesh Kudurumalla: > > > > > > > Current pmd_perf_autotest() in continuous mode tries to > > > > > > > enqueue MAX_TRAFFIC_BURST completely before starting the test= . > > > > > > > Some drivers cannot accept complete MAX_TRAFFIC_BURST even > > > > > > > though > > > > rx+tx > > > > > > > desc > > > > > > count > > > > > > > can fit it. > > > > > > > > > > > > Which driver is failing to do so? > > > > > > Why it cannot enqueue 32 packets? > > > > > > > > > > Octeontx2 driver is failing to enqueue because hardware buffers > > > > > are full > > > > before test. > > > > Aren't you stopping the support of octeontx2? > > Why do you care now? > > yes we are not supporting octeontx2,but this issue is observed in > > cnxk driver ,current patch fixes the same > > > > > > > > Why hardware buffers are full? > > > Hardware buffers are full because number of number of descriptors in > > > continuous mode Is less than MAX_TRAFFIC_BURST, so if enque fails , > > > there is no way hardware can drop the Packets . pmd_per_autotest > > > application evaluates performance after enqueueing packets Initially. > > > > > > > > > pmd_perf_autotest() in continuous mode tries to enqueue > > > > > MAX_TRAFFIC_BURST (2048) before starting the test. > > > > > > > > > > > > This patch changes behaviour to stop enqueuing after few retr= ies. > > > > > > > > > > > > If there is a real limitation, there will be issues in more > > > > > > places than this test program. > > > > > > I feel it should be addressed either in the driver or at ethdev= level. > > > > > > > > > > > > [...] > > > > > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args) > > > > > > > nb_tx =3D RTE_MIN(MAX_PKT_BURST, num); > > > > > > > nb_tx =3D rte_eth_tx_burst(portid, 0, > > > > > > > &tx_burst[idx], > > nb_tx); > > > > > > > + if (nb_tx =3D=3D 0) > > > > > > > + retry_cnt++; > > > > > > > num -=3D nb_tx; > > > > > > > idx +=3D nb_tx; > > > > > > > + if (retry_cnt =3D=3D MAX_RETRY_COUNT) { > > > > > > > + retry_cnt =3D 0; > > > > > > > + break; > > > > > > > + } > > > >