patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Rakesh Kudurumalla <rkudurumalla@marvell.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
	"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
	"ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails
Date: Mon, 29 Nov 2021 08:52:34 +0000
Message-ID: <BN8PR18MB2482B2E239B0CB7215B2D84ACF669@BN8PR18MB2482.namprd18.prod.outlook.com> (raw)
In-Reply-To: <2704266.42xP9hQJsM@thomas>



> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, November 22, 2021 2:28 PM
> To: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> ajit.khaparde@broadcom.com; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>
> Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are
> full and Tx fails
> 
> 22/11/2021 08:59, Rakesh Kudurumalla:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 20/07/2021 18:50, Rakesh Kudurumalla:
> > > > Current pmd_perf_autotest() in continuous mode tries to enqueue
> > > > MAX_TRAFFIC_BURST completely before starting the test. Some
> > > > drivers cannot accept complete MAX_TRAFFIC_BURST even though
> rx+tx
> > > > desc
> > > count
> > > > can fit it.
> > >
> > > Which driver is failing to do so?
> > > Why it cannot enqueue 32 packets?
> >
> > Octeontx2 driver is failing to enqueue because hardware buffers are full
> before test.
> 
> Why hardware buffers are full?
Hardware buffers are full because number of number of descriptors in continuous mode 
Is less than MAX_TRAFFIC_BURST, so if enque fails , there is no way hardware can drop the
Packets . pmd_per_autotest application evaluates performance after enqueueing packets
Initially.
> 
> > pmd_perf_autotest() in continuous mode tries to enqueue
> > MAX_TRAFFIC_BURST (2048) before starting the test.
> >
> > > > This patch changes behaviour to stop enqueuing after few retries.
> > >
> > > If there is a real limitation, there will be issues in more places
> > > than this test program.
> > > I feel it should be addressed either in the driver or at ethdev level.
> > >
> > > [...]
> > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args)
> > > >  			nb_tx = RTE_MIN(MAX_PKT_BURST, num);
> > > >  			nb_tx = rte_eth_tx_burst(portid, 0,
> > > >  						&tx_burst[idx], nb_tx);
> > > > +			if (nb_tx == 0)
> > > > +				retry_cnt++;
> > > >  			num -= nb_tx;
> > > >  			idx += nb_tx;
> > > > +			if (retry_cnt == MAX_RETRY_COUNT) {
> > > > +				retry_cnt = 0;
> > > > +				break;
> > > > +			}
> 
> 


  reply	other threads:[~2021-11-29  8:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20 12:47 [dpdk-stable] [PATCH] " Rakesh Kudurumalla
2021-07-20 16:50 ` [dpdk-stable] [PATCH v2] " Rakesh Kudurumalla
2021-10-19 10:19   ` Rakesh Kudurumalla
2021-10-29  7:18     ` Rakesh Kudurumalla
2021-11-12 11:32   ` Thomas Monjalon
2021-11-22  7:59     ` [EXT] " Rakesh Kudurumalla
2021-11-22  8:58       ` Thomas Monjalon
2021-11-29  8:52         ` Rakesh Kudurumalla [this message]
2021-11-29  9:13           ` Thomas Monjalon
2021-12-13  6:40             ` Rakesh Kudurumalla
2022-01-10  9:04               ` Rakesh Kudurumalla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN8PR18MB2482B2E239B0CB7215B2D84ACF669@BN8PR18MB2482.namprd18.prod.outlook.com \
    --to=rkudurumalla@marvell.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinj@marvell.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git