From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7281CA0C58 for ; Mon, 29 Nov 2021 09:52:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 06C0C40FDF; Mon, 29 Nov 2021 09:52:41 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id D333D40689; Mon, 29 Nov 2021 09:52:37 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1AT7Z3HQ008059; Mon, 29 Nov 2021 00:52:36 -0800 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2174.outbound.protection.outlook.com [104.47.57.174]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3cmtkpg78j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Nov 2021 00:52:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mkWvFU8VaCnRq8+C8Ct43vOylVpGsGiuxuzIw85xwULhPImfn4GEhCsOThS8rI8CgXbWJhJpyNFXn7tNsbHHU9sHAgB3br9K9wht4/g58Z1Og5qKPV+iEsbOsMIYhcFq/QthBZYVA8Ua2Qqo/IVLeORR1FwWoXoc/s5oodlWaMZLcsa1Kmi6vPCbkXDm+OBiq48rYGDfaASvPn/IgXSXC6emdpqpHAKVhCU+lCiV2BZ+hyGhQhGw5J5Rh5DHZi2B1J1wtL9YYpWv2WDRlxlftRsG5+vxdi5l9BlNY8BUW0Ka+amLo9VfDEUT7cNSNHWHDPcNl4f79fc3gfnQGR3vcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LsSVQynWw8tC+xva669I8Ud2wlBj/A2voupKW8FPvUs=; b=ju2e8A4z3GtJ7UfMOwIkAeE6JSknp9a5lg4sc2fAwDN4cxj56dlRye0I04d1+cY+n1JSkeUWHGB4QQwCecdmcpLpPuiSQL/dLaOSLxPBfRw2QHXI/Cqb8r1d2F713WSDCh6ktSxrlwFFOgpvoxpjjZf/oApHFMAq8pbbel1kfPBsTl2U5fSwKTnVwhXBf1wi79nVliEbe4GGhST84xSW9OU+9yQDVgGfFj2iJNN7ZEjnHqqnCCDZrpzgp1lHiXy2cMa9Q8Li3n/5jGvaGxVv2z2IT4CU2D7dO+XTFypGkSc2/6/HvePITHtGoyIwCuxpFqYWC80gMGv1tdVppKzo/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LsSVQynWw8tC+xva669I8Ud2wlBj/A2voupKW8FPvUs=; b=DU6kCLrTdSBI6ojeOa8AYcSBjZDQvsRdzwOfVGwnLimt8s6j1jGjHUSccD9gF5ai6Ap1hBU3GPWDvEYCkwEuYzujhp4Sq1JyMbzI9eWTnFtskmFj/51iDo/RU0WQ0SON5wXPfd/mpvsjzoLNI/Z+Ltvij61n7/7/g8odIiJ3ApE= Received: from BN8PR18MB2482.namprd18.prod.outlook.com (2603:10b6:408:9b::23) by BN8PR18MB2931.namprd18.prod.outlook.com (2603:10b6:408:a6::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Mon, 29 Nov 2021 08:52:35 +0000 Received: from BN8PR18MB2482.namprd18.prod.outlook.com ([fe80::bd01:a119:9bbd:1940]) by BN8PR18MB2482.namprd18.prod.outlook.com ([fe80::bd01:a119:9bbd:1940%5]) with mapi id 15.20.4734.024; Mon, 29 Nov 2021 08:52:35 +0000 From: Rakesh Kudurumalla To: Thomas Monjalon CC: "stable@dpdk.org" , "dev@dpdk.org" , "david.marchand@redhat.com" , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , "ajit.khaparde@broadcom.com" , Jerin Jacob Kollanukkaran Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails Thread-Topic: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails Thread-Index: AQHXfYd7L4dTcIZ+J0yRnIum/STvbqwAdsEAgA94qwCAABO0AIAK+z4g Date: Mon, 29 Nov 2021 08:52:34 +0000 Message-ID: References: <20210720124713.603674-1-rkudurumalla@marvell.com> <2935187.TuyvbHr83s@thomas> <2704266.42xP9hQJsM@thomas> In-Reply-To: <2704266.42xP9hQJsM@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a1851d15-cc16-4dfe-b5d7-08d9b3159689 x-ms-traffictypediagnostic: BN8PR18MB2931: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NztzSC1H9E2l8eHHFizFCqDZantCCKQayX8IJCFS4VDbhi43zUSOwmip4ugAh8moagoK0vkwVWvRxXZYk3k+4LtZDd6qaMhdzuK6Mi3FWl8CL5bPJ+uHornLZc44Le/5GgYZGzvoD5tLN5kGwoLsXrGQmfXdaXBiN2goybn/5WT1MtLsCuRWkZXVO3AoAH2rmc/MIJulgfwUzgiKFhFkyXAq5Ej+EJT3FMvvYA4raW48KinVFn3p4dXKk8d7ccJssWgVNYEs8WzMk8G63slbeWPSIvTISbT5oQ30vl4nMC07Yx9CEeH2OtXLw2UEIx2wN/w1CgKSLfEkeWKll/c6VmwZ98iBVQalqdmrWOoTSkcDxN1lmgzVO3QsOXJfqol9R/fpsId3gqM7CMFTUqEmLFeSo9FBdB9DZSVgw1PbO7SPLdLGnjFuepfPwEQezVHvOOmcMfYxqgt4GfAOeIf2UaMeptbdVrfoQV4DApNfBAVRyMPPOXle0O3rHAwb45qmWPuhgAn2f0v0JbMz/Btw33Y4FHwFY5WWQZPWdHZaPigV+f27wRQptzvAI2Y6pZg+LRg2clujEWe4NADEdilE7ou8PtNr8t8D5pqNkKQbbwB6Myk8p8Q8aFP14HXkvm4lPHEwYhccxfcZcJy1zXkSx3mzRsmXM/vv6vuqCEeYOVFQfkQqA1HNgoiDFbJkqA4G8f98dyxASVoofZlu6o6Z9A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR18MB2482.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(7696005)(6506007)(55016003)(4326008)(107886003)(66446008)(76116006)(53546011)(508600001)(52536014)(6916009)(66556008)(64756008)(66946007)(66476007)(86362001)(9686003)(83380400001)(2906002)(5660300002)(33656002)(186003)(71200400001)(38100700002)(8676002)(8936002)(26005)(38070700005)(55236004)(316002)(122000001)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vmVaRd9ICGYJUgK+TAso/30k05QazK5VhTNB16pKbJTTi4mOf5F5tjiFsXYN?= =?us-ascii?Q?ZObP52dPw/jHpxcxVthMZbr0KPi4GcyKzmbrc/7jwvyB37Tv7BVVgL8Q5rxG?= =?us-ascii?Q?gLEKA0/OrQ8hQyyrF6Nb9CjTyQIb325DG5gbvxhgL2mBEopjW9Vgs8MBoBvz?= =?us-ascii?Q?afm4Ckwbr6y40qGARyrXKJhy5v1LAMLHGK2CFLhHHR8KqTwzGunBlIym235n?= =?us-ascii?Q?NX9K0wdTlrUoQZfN+uEqnO53bZc4rPn4WcVy7Kgtbln4wF6CDd5EHKbAlCJj?= =?us-ascii?Q?wfPsR9XD2tuDWxgwnskhvK7hNCq2NGiSHxk3ka/R1B8g7jeahDsEOoQc6GiK?= =?us-ascii?Q?SsUkwgqp/DaUyZAvjLxc3Zi7slB0CbiL78cWI3nywOLu9Vx/9RZPe6Y7axPS?= =?us-ascii?Q?d1eAKr9dor+0fyfIjmq60o6xYD9u8bG/y17zcGERrbAOiJS2E8JCg2wZ0AdZ?= =?us-ascii?Q?QU/bA/JCuQyDJXJUu7EUnc4uwvZj0vs37QrCig62biCLJaU8Lva/KlWBOyJC?= =?us-ascii?Q?mtmltvT6Ht3oltwrvpuCkPS6XWG4o0OK3SYHI7jBjLOmFaoON7lqOVrn7wxA?= =?us-ascii?Q?XgSOHf3wegGp1UnGFHf4prPNST9RPEmP/jBb/79QlbwSLG1dBpQVcxYWe2O6?= =?us-ascii?Q?FLz/vg1L5H1Ci08VVDhTJ8uMIrLqqZylBIaOlKiG2pVsCS8lYIiCMIghIcDG?= =?us-ascii?Q?t546DWogDeFAxZ9+La5YevnCNVuOrZsl5Rb3fZjkjPGOYhNDRuxzL4PPAM3Q?= =?us-ascii?Q?SR1+kC+a1PpmcUeBTj9wSo+5mFb/1mDsCBJOpcY6pf8ZIRPwk2Vbe1MfX/I+?= =?us-ascii?Q?czoIjjHcW0NRVBwACuqL4adFSut8DhYwzTGGG1qweaAOf94D5M/+N3A3lLq9?= =?us-ascii?Q?DethIUdyGuUSaye/giJI06Nws/42/Fcbd2e7217aVqso05Kl0grBMoP9Q5qL?= =?us-ascii?Q?ARFk5hc+vvmyDWn3NG79T6WvtNSEszYJS1hPTfsTrw9g5+5Cqk/wSqZEgozh?= =?us-ascii?Q?ZPJDhrQyC87gb/FpN4LB84Y4N6X2YsYY2E0ncYfBF7fKlNnw8kpdiCvesQQX?= =?us-ascii?Q?FpQ3R5lzDnFyCQp8ezMcTf6P7ABjk1ScI/7xl9RgX3GBH7LAHVK9Xx9yJt65?= =?us-ascii?Q?3bOsoaGYE9rerJv3zlEjbVHqScoOk0iOuVuFHj9uhALajFvXggJhGVUHAzKz?= =?us-ascii?Q?UnSRHFSjNtSkJRPXpUoDmN8ObVVxWfR/HWShXb+T7EuVoeG3MmuLdiD7oBvP?= =?us-ascii?Q?NR5IO/ppkZSQgcV9+O+OIAbDnF6sODpxx04X3d8xs6+u4iFNJQ/3TCNv+9s9?= =?us-ascii?Q?SpJj24TdkowLN8QjBpXlw3ipgUSkMnOp5/sK9FVQ5KuZNc2PqEI+51AjkBrg?= =?us-ascii?Q?MXkdoShFbSNJwz1z8/s2kq1/XhmnB2cjw0iP70Ptdej0T/F4yyJ//Su+offV?= =?us-ascii?Q?pc4iX2V1V9zrc9hdFO38QaneiM4S4jZR6BAv3NSpV0oPEbqXZacYr48BIjcz?= =?us-ascii?Q?qqjV49RN/fhLxuiCfdLehP87/mK7dIW983rHF0bct5g3E3o7mCnUbQ0yOAJ9?= =?us-ascii?Q?B7v3g7+PXd92jMopvM95XfyOHzeCUksOpVLSzOvRaamjxj/aOXpKTnNZnP+E?= =?us-ascii?Q?w3Sy7kOf43+L8FS9Wvvf8VSVW4i5HN+Ndy7CI38lxih+4R3qvWmjJhFC4XAw?= =?us-ascii?Q?gsBLRg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR18MB2482.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1851d15-cc16-4dfe-b5d7-08d9b3159689 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2021 08:52:34.9219 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: P2nNjhqmAbubK2mlfpth6Rsw4smtNigRZsvyqZ8hITJjPmogqTNGMrtBFr8hUKUpABD3Vnjk1cNVOxBnXYZ5nRZi6kZjn+iicpzmjcoJkgM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB2931 X-Proofpoint-GUID: gdH3YfgFE8kMdC-dcW2wlJHpdmejkZd1 X-Proofpoint-ORIG-GUID: gdH3YfgFE8kMdC-dcW2wlJHpdmejkZd1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-29_05,2021-11-28_01,2020-04-07_01 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, November 22, 2021 2:28 PM > To: Rakesh Kudurumalla > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com; > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > ajit.khaparde@broadcom.com; Jerin Jacob Kollanukkaran > > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queue= s are > full and Tx fails >=20 > 22/11/2021 08:59, Rakesh Kudurumalla: > > From: Thomas Monjalon > > > 20/07/2021 18:50, Rakesh Kudurumalla: > > > > Current pmd_perf_autotest() in continuous mode tries to enqueue > > > > MAX_TRAFFIC_BURST completely before starting the test. Some > > > > drivers cannot accept complete MAX_TRAFFIC_BURST even though > rx+tx > > > > desc > > > count > > > > can fit it. > > > > > > Which driver is failing to do so? > > > Why it cannot enqueue 32 packets? > > > > Octeontx2 driver is failing to enqueue because hardware buffers are ful= l > before test. >=20 > Why hardware buffers are full? Hardware buffers are full because number of number of descriptors in contin= uous mode=20 Is less than MAX_TRAFFIC_BURST, so if enque fails , there is no way hardwar= e can drop the Packets . pmd_per_autotest application evaluates performance after enqueuei= ng packets Initially. >=20 > > pmd_perf_autotest() in continuous mode tries to enqueue > > MAX_TRAFFIC_BURST (2048) before starting the test. > > > > > > This patch changes behaviour to stop enqueuing after few retries. > > > > > > If there is a real limitation, there will be issues in more places > > > than this test program. > > > I feel it should be addressed either in the driver or at ethdev level= . > > > > > > [...] > > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void *args) > > > > nb_tx =3D RTE_MIN(MAX_PKT_BURST, num); > > > > nb_tx =3D rte_eth_tx_burst(portid, 0, > > > > &tx_burst[idx], nb_tx); > > > > + if (nb_tx =3D=3D 0) > > > > + retry_cnt++; > > > > num -=3D nb_tx; > > > > idx +=3D nb_tx; > > > > + if (retry_cnt =3D=3D MAX_RETRY_COUNT) { > > > > + retry_cnt =3D 0; > > > > + break; > > > > + } >=20 >=20