From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF7E0A00C5 for ; Mon, 14 Feb 2022 05:56:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B5A094113F; Mon, 14 Feb 2022 05:56:58 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 8C7884067E; Mon, 14 Feb 2022 05:56:56 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21E1L1tl006262; Sun, 13 Feb 2022 20:56:55 -0800 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2101.outbound.protection.outlook.com [104.47.70.101]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3e7dbc0j7h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 13 Feb 2022 20:56:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GgWoeGjlFE/1DfDk+GXdqIMAw5tkdQHkBnYtoj+RJED0JsgAHzVAKtlDUAdr+EslpM+sRr+O0MefKyq6sJ6nthgkHMDBvnxuTXnwrNLVJ3VdSE+mdWvqMQ85INIguaEuFOd0EX8qtRP1UqkTnd4NezCm2gb15M+ukyxJaw5Axdmh2BLTdH9/sXYpOJkB/BEJEBi5afi/qE7IAwIJ+wwE/J6zOHQMzVWL3YG8qEIsvapcqHu4Gxuf4sgfXnkqf5IBW5HdSBpMA0+jjdq9/cZn3uQrKulLQU8TZ8O2+dY32RFm2WxD7myyafCvJQl6JEAvMInrDBVE/5NKMdCmHkB8ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TDND/OCnEmpMtABCCxCIzH/Px65Z2OiwmaB7q1VN+Aw=; b=DdMxYyvIw7XB0/YxLe34Yjd+UkGrwQvJc1XqGDW9IO4fNTNdegKpvDB+fUrD4lR+JGBQeLPNSg8oKX6QlF5e7e8BkB1MhnV90XKzTABrzb7bzM1bNudyV0/kTHpetbjHMxC8TsfbkJBdx5qLxvgsMG0VF4fJ69I88PdWFzkA9A0vfKhVjERihgfDnSbNbaR0fEFQxuWSfIG9pZejJPuXLHVNFVBTDgLx5gG98OCKPgJTLAMHMtj0NRqsuHQ6HUrcYn1+ZaqJ21oJmQiaq5el+KPXXQ12b1orprmWyuqOIOs+6tPPRck8GwSh7/JS/MXJesRSnsNp1F1dBulPYyQ6IQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TDND/OCnEmpMtABCCxCIzH/Px65Z2OiwmaB7q1VN+Aw=; b=tDoDN+CA4eEJs08JYPh6owq15Izh4kB5sKYDLagk5RAihcfn8m2NR2GWvecv1lllbQZlnP11TW5pZkJ+xnjHzQNdbG1UytdJ9Zf2g9vBC9WafwqBqqqvTeqvNjn9I58EkzjWnbOk7fRn1dbTJ4DJ/boxNT3y8/P7Q5AY/JN7WJw= Received: from BN8PR18MB2482.namprd18.prod.outlook.com (2603:10b6:408:9b::23) by MN2PR18MB3263.namprd18.prod.outlook.com (2603:10b6:208:16b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb 2022 04:56:51 +0000 Received: from BN8PR18MB2482.namprd18.prod.outlook.com ([fe80::f171:bd95:abf9:75c9]) by BN8PR18MB2482.namprd18.prod.outlook.com ([fe80::f171:bd95:abf9:75c9%3]) with mapi id 15.20.4975.017; Mon, 14 Feb 2022 04:56:51 +0000 From: Rakesh Kudurumalla To: Thomas Monjalon , Jerin Jacob Kollanukkaran CC: "stable@dpdk.org" , "dev@dpdk.org" , "david.marchand@redhat.com" , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , "ajit.khaparde@broadcom.com" Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails Thread-Topic: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails Thread-Index: AQHXfYd7L4dTcIZ+J0yRnIum/STvbqwAdsEAgA94qwCAABO0AIAK+z4ggAAJdACAFc2x4IAsMZVQgCJoOxCAABTHgIAUPxbw Date: Mon, 14 Feb 2022 04:56:50 +0000 Message-ID: References: <20210720124713.603674-1-rkudurumalla@marvell.com> <3120644.AJdgDx1Vlc@thomas> In-Reply-To: <3120644.AJdgDx1Vlc@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 23b993bc-b2d0-4edb-3688-08d9ef7669d9 x-ms-traffictypediagnostic: MN2PR18MB3263:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QLZyuPNzlNQ0/RDTWI8v1yzFjkFENcY1XHzJrRaLJ8W4Urrt07FSlO5osAjZxKGkU1R+F+4VLoAPM/j/N3xMW5ZkFUq+vF8qRvy9WbcRCXbFoXWiGTZXCRy5PavKjcJmcVBO0INKT2v/jqSa3b81ua2pccc0yQpmVguEtXkAmA8s7iRpkWcQSHmz5EV4ax+TgtgUHm+AENUgG2l/NpVjyghvczMEsv/cohKvHgjzEiCLQxF4FZumGXuVdqsKkzhRCCUs1qnicATfyqj1eBUjdUPk1mECbJK1gzzNUekJd4Rrg80ScXW2N2F1uhA7avD/CUwomUqTXCZfZpiOX7+WDMfDIaDeYnomf8XpnsoKBi6mWsrc6u3ujjOxocsqDfG2SvASKl1LqzQs/7LELdvOpdFxCVTB7UOPHZwijnPUVJtKh/X/++zbPRy9VQ/7pO8LJTL166bsI37ZV9LUVUqGW3aTLlvgQSEFXIjTIrtipjMg8EkdYq9QQmZbJg0XyJKfMfHdmPkh8TZh49xgEbwed7APWs77coWfHTUZddeR913v8vmofAnasAK0OXf2plgm9VKmEcoF15CbliCwnf1byxu8SLn63eJV6vhkafmwDkPyckUhpxD9iJ1+mO257YAoqtc2aNfcNnGsyqh1it2X6rbHKjdtBbiIjA+NSsjCSPCpwcjRD87N26B3rhnPJf/cULhKXeQCiRdv6CjOs+Gtag== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR18MB2482.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(508600001)(83380400001)(33656002)(55016003)(53546011)(71200400001)(7696005)(6506007)(55236004)(66946007)(38070700005)(5660300002)(8936002)(52536014)(86362001)(76116006)(186003)(110136005)(26005)(54906003)(38100700002)(122000001)(9686003)(64756008)(6636002)(316002)(4326008)(8676002)(2906002)(66476007)(66446008)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6A2Wb9KCY7aM8UXa46HejxubKLlIIfxXWHgJmzEGGRuo9fqf0fm0yiuNbsQ4?= =?us-ascii?Q?AyHIe8iNaQCMiAANNeTdiasRG9szDl5Qr5LwLeUl7bgQRqoVSWcrc1uKmRB8?= =?us-ascii?Q?PYTgyNqvMvgnEFyDP6XxMX8eB6jgyMC3FSapAGIC5HQncmbhxfSU7v2rezrT?= =?us-ascii?Q?W6HLH1ASl+PPb4br0OicK254Im9E/fjKDI5wsUZNYk0QbzYKSU53547eKbno?= =?us-ascii?Q?TDQ5KC1l/p9FwDEUubFWdePXLoMA0B18wSHyc/5fNZm8MbtpQ5ixSgKZXdC/?= =?us-ascii?Q?iXC4Tci2d/asmeYbhNZHA131Q9jCFEm8jF2QMhxOIRNQVBilZwRtkrrnl/Uf?= =?us-ascii?Q?Pw3UMmfB7vq8Ep4siRR6St0uipZGeAsNidG50/cfkZRfW9CkEF5RMnouGyUs?= =?us-ascii?Q?FycktBPOzxCqAp9aA0u4IiVUXZhko/okFRvEoKB1RNXAiSBiJIQuv3R00o4f?= =?us-ascii?Q?T/Kgkkk+vgdbhuzFpCfQlKB8sNsfMk6wgyY57egTuAiS3QC9nZ8cHBPMtILV?= =?us-ascii?Q?neJqPdX/PKAqjBp1EAkwnFOmtHM9O3hbWf02kIe4TccYPmSd++mdGQESDrn/?= =?us-ascii?Q?b+FTxgprykrLadY1Jxjb0FXg6naJwDnCcjEzAXU9M0aRrOeXK9Sz3VnBOAx6?= =?us-ascii?Q?OgcQc7giEPjjtxWnIetqmrPLqCpKxaDjACTuY5kJ1mbhlmIIOlAPIqUuGmao?= =?us-ascii?Q?w54ndPFl9gh+fPwuql5GEnfn3tjtwB2VFrijXHAd3X1vskThd4jYhBwokLkY?= =?us-ascii?Q?9QQvDZXmzg8TH/hpW4gZvs2N9n2XzU1YoMRe9/0u+Ft//cxw4/D0jcYiOiJY?= =?us-ascii?Q?2Q9j7721//HXWeHNqlSh6jBqFT7SKgAfcUM0dUnVywcAePxCwZ5KfGMjjxOB?= =?us-ascii?Q?/hndyyVO4CuYkNdhBB/Jxm8y1RtaYu8OQfWp13AeUv6NTzFHoTI7tNX6uRp1?= =?us-ascii?Q?sT5qlBV8NLED5nqjI7lDoJhoPzPF6bvc7zaF2uLUVJxCpUiK7bcpt/r4t8rK?= =?us-ascii?Q?cGWPVYagwccTKepHUku752exMuoaVqGAJB90x3+Nf6StHQ30k1ePzBkRQ1Kz?= =?us-ascii?Q?8p4DL0VowW7xYxUqmg2OPxhC271mP8tfqE6pnjftEqmFw8px899roZqlp+/Z?= =?us-ascii?Q?EDnlU3Ux7EY3YrLpApKP0HmwTfhCxHI7YNaQ2SxYYRERoLRRIHWERUMLqSJI?= =?us-ascii?Q?1NZt0NYeRRgUlhwBoVLwkJmA6d5OIH386CLeCcAkzXr/wgtDmIMOS9vaERMU?= =?us-ascii?Q?89nWskexpNFzUqAGIWngJLkXk9QugtsFxkwMU9utvaxpftGYe0ZM1A6EVErK?= =?us-ascii?Q?ZAvDOu8F39uBkFTH6xAONWTAew8gOqn+r7hisW/YUt/2OjF5M7a/PFrWS2M9?= =?us-ascii?Q?s/i0vpwd3bvdoWTVl7BcA1UeTJUOqpaI8vV0ab8cpxvfCxeJ08CkdHVSOcjq?= =?us-ascii?Q?nZ7H8wVoLJNbZvO5o5NCfbmxbViLM3J3JaHsmZ9aHRLDNJWLUv3MaQzKTc2a?= =?us-ascii?Q?C1QKMNFwdgQ5KcucikSRPHKYx2j/mCvBbLPxiEzcBE9hmBj5Qte2o+6dvIUb?= =?us-ascii?Q?9I+IbomGZKclPx7nqFxPGAkQZDJW6gTCs01WtM4jZbBjdgMwAuxG/yervP9k?= =?us-ascii?Q?hgFuttumOr15IhchlMxTnqUVEIEJ7q32+iC9PZqNmxjym4iMHM4KGCi6Xgvw?= =?us-ascii?Q?JbvrWQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR18MB2482.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23b993bc-b2d0-4edb-3688-08d9ef7669d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 04:56:50.9408 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aReLFNLCMt9NQGAK4+6MGrx96HwLiRZCM/KcYvyJmQMr+sLLYSVaQ4AOOvHO3EBj0XvXkn2xpGCk22Zuh0Qslzlsc3gVUJZmW2xofnoRGpw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3263 X-Proofpoint-GUID: z0Ak17qZ-EpYjTC4Xg6IO3V0w0InhJwI X-Proofpoint-ORIG-GUID: z0Ak17qZ-EpYjTC4Xg6IO3V0w0InhJwI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-14_01,2022-02-11_01,2021-12-02_01 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, February 1, 2022 1:15 PM > To: Jerin Jacob Kollanukkaran ; Rakesh Kudurumalla > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com; > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > ajit.khaparde@broadcom.com > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queue= s are > full and Tx fails >=20 > octeontx2 driver is removed > Can we close this patch? Same behavior is observed with cnxk driver, so we need this patch=20 >=20 >=20 > 01/02/2022 07:30, Rakesh Kudurumalla: > > ping > > > > > -----Original Message----- > > > From: Rakesh Kudurumalla > > > Sent: Monday, January 10, 2022 2:35 PM > > > To: Thomas Monjalon ; Jerin Jacob > Kollanukkaran > > > > > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com; > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > > > ajit.khaparde@broadcom.com > > > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if > > > queues are full and Tx fails > > > > > > ping > > > > > > > -----Original Message----- > > > > From: Rakesh Kudurumalla > > > > Sent: Monday, December 13, 2021 12:10 PM > > > > To: Thomas Monjalon ; Jerin Jacob > > > > Kollanukkaran > > > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com; > > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > > > > ajit.khaparde@broadcom.com > > > > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang > > > > if queues are full and Tx fails > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Thomas Monjalon > > > > > Sent: Monday, November 29, 2021 2:44 PM > > > > > To: Rakesh Kudurumalla ; Jerin Jacob > > > > > Kollanukkaran > > > > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com; > > > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; > > > > > ajit.khaparde@broadcom.com > > > > > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang > > > > > if queues are full and Tx fails > > > > > > > > > > 29/11/2021 09:52, Rakesh Kudurumalla: > > > > > > From: Thomas Monjalon > > > > > > > 22/11/2021 08:59, Rakesh Kudurumalla: > > > > > > > > From: Thomas Monjalon > > > > > > > > > 20/07/2021 18:50, Rakesh Kudurumalla: > > > > > > > > > > Current pmd_perf_autotest() in continuous mode tries > > > > > > > > > > to enqueue MAX_TRAFFIC_BURST completely before > > > > > > > > > > starting the > > > test. > > > > > > > > > > Some drivers cannot accept complete MAX_TRAFFIC_BURST > > > > > > > > > > even though > > > > > > > rx+tx > > > > > > > > > > desc > > > > > > > > > count > > > > > > > > > > can fit it. > > > > > > > > > > > > > > > > > > Which driver is failing to do so? > > > > > > > > > Why it cannot enqueue 32 packets? > > > > > > > > > > > > > > > > Octeontx2 driver is failing to enqueue because hardware > > > > > > > > buffers are full > > > > > > > before test. > > > > > > > > > > Aren't you stopping the support of octeontx2? > > > > > Why do you care now? > > > > > yes we are not supporting octeontx2,but this issue is observed > > > > > in cnxk driver ,current patch fixes the same > > > > > > > > > > > > > > Why hardware buffers are full? > > > > > > Hardware buffers are full because number of number of > > > > > > descriptors in continuous mode Is less than MAX_TRAFFIC_BURST, > > > > > > so if enque fails , there is no way hardware can drop the Packe= ts . > > > > > > pmd_per_autotest application evaluates performance after > > > > > > enqueueing > > > packets Initially. > > > > > > > > > > > > > > > pmd_perf_autotest() in continuous mode tries to enqueue > > > > > > > > MAX_TRAFFIC_BURST (2048) before starting the test. > > > > > > > > > > > > > > > > > > This patch changes behaviour to stop enqueuing after > > > > > > > > > > few > > > retries. > > > > > > > > > > > > > > > > > > If there is a real limitation, there will be issues in > > > > > > > > > more places than this test program. > > > > > > > > > I feel it should be addressed either in the driver or at = ethdev > level. > > > > > > > > > > > > > > > > > > [...] > > > > > > > > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void > *args) > > > > > > > > > > nb_tx =3D RTE_MIN(MAX_PKT_BURST, > num); > > > > > > > > > > nb_tx =3D rte_eth_tx_burst(portid, 0, > > > > > > > > > > > &tx_burst[idx], > > > > > nb_tx); > > > > > > > > > > + if (nb_tx =3D=3D 0) > > > > > > > > > > + retry_cnt++; > > > > > > > > > > num -=3D nb_tx; > > > > > > > > > > idx +=3D nb_tx; > > > > > > > > > > + if (retry_cnt =3D=3D MAX_RETRY_COUNT) > { > > > > > > > > > > + retry_cnt =3D 0; > > > > > > > > > > + break; > > > > > > > > > > + } > > > > > > > > > > > > > > >=20 >=20 >=20 >=20