From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92899A0547 for ; Wed, 14 Jul 2021 13:17:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A6474069F; Wed, 14 Jul 2021 13:17:48 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 2A9854069F; Wed, 14 Jul 2021 13:17:46 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10044"; a="208512031" X-IronPort-AV: E=Sophos;i="5.84,239,1620716400"; d="scan'208";a="208512031" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2021 04:17:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,239,1620716400"; d="scan'208";a="413259019" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 14 Jul 2021 04:17:39 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 14 Jul 2021 04:17:39 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 14 Jul 2021 04:17:39 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Wed, 14 Jul 2021 04:17:39 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.46) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 14 Jul 2021 04:17:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A6sOEn1Lz4BcTrsftVMxL88zHwflvZPGs8EdyxFwsYqLz2DcyA/89EuypfxkqZkLDo0hXwaP/0R2x2r7MOBvAa6/1yIZZx7TIVlte48GSO4kFnsazpNxqlffUysV48+qZOpjm26Mwiq4wjxh0+1yLUKdOsSATFkoDzk42A1SRjTNuXP+O2HCLZ4oEGO/yyvUL9D6A0LxBBLT1xIwuLYmkedW5YniqfPIoyAm2ovcy15zV/uhksgh8vaYeiLK6b5si0b5zX5RSy2pXW8Zxl9xlgfCVX9QEVB8DN/4budRLodczXXjE686b+XDZelqn8twL8hy8e4CnwOcuF/YNeBRqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A8H8jXAEbpP+Hf7cC1PViwhxCDsPuxiDJ8jMMQlOgeY=; b=R7K2v7xAnb8zcNowyt1xfdIsjeCnVz0HMHHTTi+v8H7/ddGe1jTDKAQyeo4MYRJ4RMmtMigjDfswHFp1FMxSTIWzH/MyIy7OXkxKrvlaA5/yo7a8ngyAWQ6qnPZIw7lQO8A407bd4I0sYTL/XNVGMGF8kO/5r3f9CVotAshVRDgqkqWA316TGuwnIr6/2hUjLHhEjFNboACNLFvZnV5gyvCgsPp4T0sEcGvQanUE7Ng3kh+80ZgJ7V9lqkjpDC81QhbmXZb0cG8k6Em5ksnSUYcymWVCHB83dAnUN6W/T+L2LeQ/C/86vOSqIA7NMkh+UyxId7jDpYSNSh7VK34jlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A8H8jXAEbpP+Hf7cC1PViwhxCDsPuxiDJ8jMMQlOgeY=; b=aEIS9pAl/JIYGBRw5Y89nrJNnw4Ee4s8ofOV/2tjVa5JQrqU/CEy1UDj/nlGcHJWis8iP9SH46Y5/XkOEYbqUecYoRFh+bu/0DGKc5mUAoKfUP2xO3GEbP+/J8CQ0Cy/IDIIvoE1N6bu6ArQfxGG8kIWsF9VoCHQ/gwHNpgKXS4= Received: from BN9PR11MB5258.namprd11.prod.outlook.com (2603:10b6:408:133::13) by BN0PR11MB5695.namprd11.prod.outlook.com (2603:10b6:408:14a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21; Wed, 14 Jul 2021 11:17:37 +0000 Received: from BN9PR11MB5258.namprd11.prod.outlook.com ([fe80::c73:8099:7af4:1f09]) by BN9PR11MB5258.namprd11.prod.outlook.com ([fe80::c73:8099:7af4:1f09%8]) with mapi id 15.20.4331.022; Wed, 14 Jul 2021 11:17:37 +0000 From: "Singh, Jasvinder" To: "Yu, DapengX" , "Dumitrescu, Cristian" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/softnic: fix memory leak as profile is freed Thread-Index: AQHXd8Dz7hzxbw22nEiws54awnQO9KtCVAiA Date: Wed, 14 Jul 2021 11:17:37 +0000 Message-ID: References: <20210713082709.465481-1-dapengx.yu@intel.com> In-Reply-To: <20210713082709.465481-1-dapengx.yu@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 56c0a768-c360-42c8-fd62-08d946b8fc79 x-ms-traffictypediagnostic: BN0PR11MB5695: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1728; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dAoKJUXznUCKChSLAjKVkIVbKdEJEJilBZsyaSZ73/pw2lK1rw4z1bvC9aTSV8ho2icpBV2tE7QWIW6h3LoUvCc0hBocTieAyf+Jj0WcJHJXKn8wUuP9ppo4E6NtA5TAD3E5BaJpcDCfGtC9PzLc0c2gAzxctYbCyrhXgp6rCd1GNYlrZfUwYIsW/iGmHxx/YZULc3VwulvmtrFaju9zG5JlFmCtMaYS80chU2h5mJlOzVzaUSCQokQAfXVSKGhdSCBDHAeCuAeOarLYgOnp2BnIh9V76cJRoaQPcJInR9BM0gfO4EpjgYgwnZ2UwKzNqsnO8ShsifoRUeC7c6p2ffrZDPz6wRJLGdNeAP/37FoGxt8WyfbmTAa9/jQtRXL6ekJHWFOzkX8JqzPyYu+dgMY4Ef2Pumkll2ZAYUEe7SV/mrYW9ORsr2r22nX/RHX4WM8M0RU8S0PRnTd035fj4/F9FYdxNZVloH8Gjc6vruKSQV5404G51eBdzaVMbZoHjAiz0MAekWmFCjfy6yLZoBmR8ZmYqpJIWkJBU/31tnwoHIJzCV9rubCeWQU9BmiL4uiQeIs7H6+p8KBTKn07bbiVabFxOtQ8Gah53qUf/8mpF1gphtH7LVNEVm0b1WlWautpeOjYqNiz08C4JB8XPkCbM/qDeQ+4/qP1emDwf9JPZSOrnlPwnXpXB61YwFyRpfNCdoKOa2XBD3JBjulIbA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5258.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(39860400002)(366004)(376002)(316002)(66946007)(2906002)(66446008)(9686003)(55016002)(66556008)(66476007)(478600001)(64756008)(76116006)(52536014)(5660300002)(71200400001)(450100002)(6636002)(110136005)(4326008)(8936002)(8676002)(86362001)(33656002)(122000001)(38100700002)(83380400001)(6506007)(53546011)(7696005)(54906003)(26005)(186003)(38070700004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?a8UX20Y8CWqnChgi+JLHU4N5tbR45mJsuwyGYOFa5Kmd711bcAey/0UBoTy8?= =?us-ascii?Q?gK6KqNTrUdoyPA2k99X8lHmP0R3kyHGnLHN2yNLwEqgyoTrScDNbCpXy1s/8?= =?us-ascii?Q?/zPs0ZZxNeyDJiNpLVSjD+Pr4sIErJPIxmYG0eMZXxCJUKReaRVq87xQRH1f?= =?us-ascii?Q?ZARnu1tdfaJZV+pItAsw1UZWACMQIhqeOECmKSnve83jJWwR41TDaNbHbROx?= =?us-ascii?Q?GypSMjYWJECQOf1PXGT9TSv0a/1POMlvy2SgHdMs1CcMnPmlcvAJnbelAkAS?= =?us-ascii?Q?bni1e1OIzVcGawNWj0zRl9oMDLZsPqANdJsgaq6iq0uC3I2VG2hKBIu8yGB3?= =?us-ascii?Q?KacYPif9v+7DgYlmoG2Rr7ZleL/teKCKMMzCyfriDYg4W+e2/SEFRDJ18P1L?= =?us-ascii?Q?CJk0OHgMpfRmDtb86xTGXZwESGMOdCOR6buBokjhtHbY9URy9CdpJibpXfIw?= =?us-ascii?Q?ppSb25PE1FPTVzkjF1W87VS4egdlJ2si7gLjGQ+U/MpYwmc+Lec1SVln/GIl?= =?us-ascii?Q?nyGhZPrh8Mim8ekmChOVrG9pW0k5QdyYBpDz8yi4wqg4tOQYCyKj8l+6J032?= =?us-ascii?Q?xTR3l2pUxdzoh1bnzT9fAzB4NeHjdy7ASiTfLc8By7dbfCRFqEobhq67IWM0?= =?us-ascii?Q?UVvk9swG/kQc8gt+P43pAFr9mBpIIW8l9tqEN8EKf4IBUVSZqU7GYaswAE0I?= =?us-ascii?Q?Sbis7K4iHRbp8NPwiMC2cZrrrzaMl34fYxplgE1iTA+I8u30zBrkC8iXt0Q6?= =?us-ascii?Q?QKYJE4KhW12TUtOqydQEBkxyqs2jv8fnSjPynwNqm5zvjmcmUfpMQCyW/CtB?= =?us-ascii?Q?tbgdLJ1DBozxqvbAHp8xjQaweClY7zoLsks0Ouv4J4+uRDQ1ydVestrsS0WQ?= =?us-ascii?Q?Y+XzwRFCKqqLU2+4TsPh7AfPnYFT4eE016LHf7wRM6sNBHukqYRM+NhRZ0P/?= =?us-ascii?Q?/rAgBg1VfOtjGgCaProVddaeF4/itMqcUri05OxamaoCve2eQsCFnXvk9iuW?= =?us-ascii?Q?tGybbhSYon6fVANklwkmO3aXceD61ZSu/raLJlEdLC0fmt77hk42fki0/nHy?= =?us-ascii?Q?v2OTq6j3FnHafbjc6m+N/EOQ04oFfC8LhV53aS+EAf0wDGrgxeBkvS/fktPM?= =?us-ascii?Q?yRx53GXdtGtfbFtnPoBwJ5wjfNKgL68haxxYmDtvifMESMASW0tT4w2g6Dck?= =?us-ascii?Q?aj08giwtv0KyFvAin7x0kWhzb2CKpKJBUucwezadguUL8R+d/445adE4k1K2?= =?us-ascii?Q?qQeQlz7+L5/oCKXgMmCb5+K4rZAHXCc5DWlS/bYxhmwMOzjJP4FMx7KacR2l?= =?us-ascii?Q?xzXI+y5Pg08MS/y0jnVo6jMt?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5258.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56c0a768-c360-42c8-fd62-08d946b8fc79 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2021 11:17:37.1862 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UZba6qI0dDz1olDsag20UMOTgSK50depO4qnuHaKmHlGLMmoqpRoHirzyV1VNqI7sBiHkSU/FV2wJqRWa7fUGHzti3Np1rO7OsX6kDt/Q4Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5695 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH] net/softnic: fix memory leak as profile is freed X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Yu, DapengX > Sent: Tuesday, July 13, 2021 9:27 AM > To: Singh, Jasvinder ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; Yu, DapengX ; stable@dpdk.org > Subject: [PATCH] net/softnic: fix memory leak as profile is freed >=20 > From: Dapeng Yu >=20 > In function softnic_table_action_profile_free(), the memory referenced by > pointer "ap" in the instance of "struct softnic_table_action_profile" > is not freed. >=20 > This patch fixes it. >=20 > Fixes: a737dd4e5863 ("net/softnic: add table action profile") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dapeng Yu > --- > drivers/net/softnic/rte_eth_softnic_action.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/softnic/rte_eth_softnic_action.c > b/drivers/net/softnic/rte_eth_softnic_action.c > index 92c744dc9a..33be9552a6 100644 > --- a/drivers/net/softnic/rte_eth_softnic_action.c > +++ b/drivers/net/softnic/rte_eth_softnic_action.c > @@ -183,6 +183,7 @@ softnic_table_action_profile_free(struct > pmd_internals *p) > break; >=20 > TAILQ_REMOVE(&p->table_action_profile_list, profile, > node); > + rte_table_action_profile_free(profile->ap); > free(profile); > } > } > -- > 2.27.0 Acked-by: Jasvinder Singh