From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6365EA0C43 for ; Tue, 19 Oct 2021 16:11:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51E5D411D7; Tue, 19 Oct 2021 16:11:39 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 1002B40150; Tue, 19 Oct 2021 16:11:35 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10141"; a="289372817" X-IronPort-AV: E=Sophos;i="5.87,164,1631602800"; d="scan'208";a="289372817" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 07:01:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,164,1631602800"; d="scan'208";a="531447222" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga008.fm.intel.com with ESMTP; 19 Oct 2021 07:01:10 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 07:01:10 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 07:01:09 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 19 Oct 2021 07:01:09 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.47) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 19 Oct 2021 07:01:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aBqAptrKKswYXgDS2LVLKmMpydknq9AKB0w02YUKJIvDchl9Yptjam5j4Ho3yho77IDTBLmFv4j+RjG3cIFo+cMn58v5Pw59FJd/TTjKJ0YyiGHz3jwG2260XQwtJWnLfPV3yBIpzCWcTDTov3Dfvq0bUqTQz1ZoyCpdnYY+1Tg+Ih7nQRoOrCbk5SClYtUWwrNDfc3hiLwVvJDiNjNswbcq0TccL/OrBeHPBVywaGWt8c/TacxEgGpiEoEQPR2BZTSRVf7KhaZfOQmyzebtfsQtmaZda6BKA1OVT8VojIUwN1cMTMv0VcnByG1WHqzFIR32tQjH/NchipK1OenagA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cz1+VBuJHjb7bl/iBVYdnoqj9REroawlyZFo6bkFg2o=; b=VifEX22cWfKd1x1xh3mfKU1YAQAtyUK2URJs7YGDfRtabVgAtnbN81Ap15an656CjTsHlITpoeK///78GYW/F6tEkooEObDacB+iYvtcLmlPTRRNm5r+jYnzIf2+NgPw1baDtLQ00JsFzK7yh+C4Nu+nZ5xPspHVOsYrwkSH0Yffp3miAcCMLNs74edGNujCFRzPUDQRqRL+/IokTII1JdaJ6ttQgnjzX5F5fzMfF6B2LdKnDEO4zci/QdnvKbJBWO9CC7F/FMnKFd0uXejeReNZLTDdzc5CbJTuFsZGhSW4J6yhnaeGZec1ndn9SDaRC+D50JHMNExN3et9ix0hyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cz1+VBuJHjb7bl/iBVYdnoqj9REroawlyZFo6bkFg2o=; b=xOtvYlsbcrfcThp6GpOD28J+sYFM5S6cTjl+gXtSQOpFdaoF+4cObmRcPrUajAzEZ0v3TjiltWnon3ALjkZgty7XZKiLqbcrflzqDZTooLiNpdi/uUetPW2f7Y88YqXjlg6X1l5iSfg8Wn2yG3o7uVI2SvQlhi3OKYizFQfWdSQ= Received: from BN9PR11MB5258.namprd11.prod.outlook.com (2603:10b6:408:133::13) by BN9PR11MB5401.namprd11.prod.outlook.com (2603:10b6:408:11a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Tue, 19 Oct 2021 14:01:02 +0000 Received: from BN9PR11MB5258.namprd11.prod.outlook.com ([fe80::1c1e:ff1e:971f:be65]) by BN9PR11MB5258.namprd11.prod.outlook.com ([fe80::1c1e:ff1e:971f:be65%8]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021 14:01:02 +0000 From: "Singh, Jasvinder" To: "Yu, DapengX" , "Dumitrescu, Cristian" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/softnic: fix memory leak of meter policy Thread-Index: AQHXwKDxuOWSp4iNREWEISFPVHyERavaYhZA Date: Tue, 19 Oct 2021 14:01:02 +0000 Message-ID: References: <20210930083444.636152-1-dapengx.yu@intel.com> <20211014021208.361162-1-dapengx.yu@intel.com> In-Reply-To: <20211014021208.361162-1-dapengx.yu@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d07718d6-0679-4faf-0e4f-08d99308e2eb x-ms-traffictypediagnostic: BN9PR11MB5401: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:813; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pcmFwFgXAyjVqLiPRCBX+3Nwgc4qWXY3lJ34g4B3rwg1/PKtv30A+6rVwolUBQ+iz7dA6xFQNjeL11Gws0u+tOqwEjYL2jrCrRul3PHMoMb1DxUfDlvSXTf4yn1u6z/tptO+4WsDD2038jvzb12yzjPHNTOSjPU00TXAoThadZezOSK1NFSaoBjH+qNPLtqLYDqx3LjKMO+iN0E12bhf/8hcNP8z7o0VL5gEjP5zah2W7Hg2zAy2oHpQP++5rQ9H2ZCiD6I63TAai5xhSI2UkfNoXqu036uSh8FeqOAozE+cNKi4W+UNE2JEZQXI8cCDHQtt32LiiRXtxn+kCJSk1/e1JwXOFPcoR4Jo0EHZFSZRS+7dxajcJ0GaPbsjlYSLFKE85GxaaqhGL21cJMiwzrVsSdX5YNvyEpitQBm3nHcAYQ8Ie8GMR8Q0rV78Ke+nVNF0JXIDdjlYFKe5y4B9rlzscOz1GFrbJXwcYaLBdcZN/baSqPSw9S76J+WFiEoRrybBh3uMjkDmnzMQBRYlr/flisowXPzKmLU97Mabp1L3IruxmC52RQZOttDnjy58zX7PHjKTB9OPEYf56nTbDLjxz80WwcshUwnm7lR31Uiw1zXMZ57rxBwREWmm3ZW7F4wSZSG5oWPhyDnAZj/UllHwgWOrd9UXefoFnEVSoQWf+l048LelpRacPpa/PNviIBczxohDmqq/BYJvej1xSQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5258.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(450100002)(316002)(38100700002)(122000001)(4326008)(6636002)(9686003)(64756008)(54906003)(55016002)(2906002)(66446008)(7696005)(33656002)(38070700005)(66946007)(53546011)(110136005)(52536014)(6506007)(186003)(76116006)(8676002)(8936002)(508600001)(66556008)(82960400001)(26005)(5660300002)(71200400001)(86362001)(66476007)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YQsqIPkCxBp02u00m9o2D2lvZdqz53gElMi31yJCJGG/2KQmYs6Qwhrd6nh6?= =?us-ascii?Q?VrjTFgufLSDUL1Gx8+mxEKkjw+DqYRL6BUWWvJpd5QroTrROXMvjESZ+buw/?= =?us-ascii?Q?SxnqEjYJItAAMp8J4Y4JnHdjkma+mugHkH0Ydvr8vB7YAvGQskSg1CJTsTJb?= =?us-ascii?Q?GtXjR0ItaaKkkWUGfM2SHSw0DWiSqIq0/dz4V03Rb5lSkOQeppE0tP4+g/ar?= =?us-ascii?Q?6QOE4EJmTSQ1DDlePWp4A0Cui7FqnWlLXSvAVjDiLUArHjx+hH/JcGLQJ7iB?= =?us-ascii?Q?gzW9oIOp2zbneo49Fcz/TnOPBtXH23m+ZGo1Y1azfCZvI/X8LJPui1aqq8pa?= =?us-ascii?Q?qau/RlIPcFhgMUH1Mm7GTMtowyDHrqjlKjtwvfH5NpTvcaQT+YbWCVSDvXQY?= =?us-ascii?Q?wdVBz2z2wprUSk8uFjtGCenf04f6Sr/fUIcZ2egbQhasTYuO8katxFcICi/H?= =?us-ascii?Q?GeSu2+l21NcNbYwlw++RjL4elMNib0MAo30x1COCojeSZMxqS9NorA2kNbjD?= =?us-ascii?Q?Q1Ay/qv5+faT9t+xw1264gHEs8CLQVc9S4hpqXAbf8bDc7kOUYBh8qQclJrV?= =?us-ascii?Q?zG2L8+jRmRnwFUJ54tiFlS2Shl9jlPukerIf2gUT4ndA2RzUM+9jWXz6vUpO?= =?us-ascii?Q?oI6tcKDUb+QGQUni+mUwNNDn/AxCb6vzMjOxucpeF5rL7LKsk9Cd/hZYW4kS?= =?us-ascii?Q?Rd02ksd4CA/SNHpye/RiIqV127yrfEj3PzP0r1Otk52ceOeBHKZhfQDdDtnu?= =?us-ascii?Q?pqVYVUvTTx8atNXYJL0posWibkkcE2GN9t8apgWRmDN70ex/kj5MXezWtY1z?= =?us-ascii?Q?sCVLXVo48PlTafavBEThcwfSon4kX999LgY4CEmD0+Tq1p5ulo/NAiaQuR1q?= =?us-ascii?Q?MdtLIjm6+jUT7ap9ziQt8WfbptQjtIs7nfwItAr8b7HfHZkX8C4kHMDFtade?= =?us-ascii?Q?sy8kWs2o+k0x/F2QVg/RGNjah7Ys84ZsBX6VOLh/NoWPfE3YImvi2lkD9FsC?= =?us-ascii?Q?7n+tFDrmrIhgYg747/CzUszvf1MCnpzhb0fUlb0QXfNU9QiV7EFZ+d1ENKFa?= =?us-ascii?Q?issskC3hzV23ROcWOAxqHqIICeenGk4fU/dyOMPGreCVhZlvnKqGfZJM6vlY?= =?us-ascii?Q?tte/xOJRjLrS6X7Z2nrhkT8wurolIdIJHmnVQgyilm4GUDryN5BAuy+1E1zK?= =?us-ascii?Q?xZRKUvMttOkVBrQs7C7qB/LfMuoBPMS41nbslUvwomE6QZx+nS58O6cRsW3x?= =?us-ascii?Q?ctMhAyPDER3JUo+LWgcFNeGZHr+QA356s7G26kT2DLCmoE+9PVEGP3vxftKU?= =?us-ascii?Q?zGMJGxoHgXFqAlTYAnCxFmoW?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5258.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d07718d6-0679-4faf-0e4f-08d99308e2eb X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2021 14:01:02.4468 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: orHaSEkyoyGIIi3CEPdrcoRFYyz159SgMajzAe/0o9OEQns+oORolTnVr13csuk4r3TggqsFdHK9CEpt6t7UHp4JSJ0Wg3372k8zjw2YVpU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5401 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v2] net/softnic: fix memory leak of meter policy X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Yu, DapengX > Sent: Thursday, October 14, 2021 3:12 AM > To: Singh, Jasvinder ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; Yu, DapengX ; stable@dpdk.org > Subject: [PATCH v2] net/softnic: fix memory leak of meter policy >=20 > From: Dapeng Yu >=20 > After the meter policies are created, they are not freed on device close. >=20 > This patch fixes it. >=20 > Fixes: 5f0d54f372f0 ("ethdev: add pre-defined meter policy API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dapeng Yu > --- > V2: > * Rebase on top of main branch > --- > drivers/net/softnic/rte_eth_softnic_meter.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/drivers/net/softnic/rte_eth_softnic_meter.c > b/drivers/net/softnic/rte_eth_softnic_meter.c > index 5831892a39..6b02f43e31 100644 > --- a/drivers/net/softnic/rte_eth_softnic_meter.c > +++ b/drivers/net/softnic/rte_eth_softnic_meter.c > @@ -52,6 +52,18 @@ softnic_mtr_free(struct pmd_internals *p) > TAILQ_REMOVE(&p->mtr.meter_profiles, mp, node); > free(mp); > } > + > + /* Remove meter policies */ > + for ( ; ; ) { > + struct softnic_mtr_meter_policy *mp; > + > + mp =3D TAILQ_FIRST(&p->mtr.meter_policies); > + if (mp =3D=3D NULL) > + break; > + > + TAILQ_REMOVE(&p->mtr.meter_policies, mp, node); > + free(mp); > + } > } >=20 > struct softnic_mtr_meter_profile * > -- > 2.27.0 Acked-by: Jasvinder Singh