RE: please help backporting some patches to stable release 19.11.11

["Ding, Xuan" <xuan.ding@intel.com>]

Hi Christian,

> -----Original Message-----
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Sent: 2021年12月6日 22:28
> To: Ding, Xuan <xuan.ding@intel.com>
> Cc: stable@dpdk.org
> Subject: Re: please help backporting some patches to stable release 19.11.11
> 
> On Mon, Dec 6, 2021 at 9:12 AM Ding, Xuan <xuan.ding@intel.com> wrote:
> >
> > Hi Christian,
> >
> > >-----Original Message-----
> > >From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > >Sent: Friday, December 3, 2021 2:27 PM
> > >To: Ding, Xuan <xuan.ding@intel.com>
> > >Cc: stable@dpdk.org
> > >Subject: Re: please help backporting some patches to stable release
> > >19.11.11
> > >
> > >On Fri, Dec 3, 2021 at 3:07 AM Ding, Xuan <xuan.ding@intel.com> wrote:
> > >>
> > >> Hi Christian,
> > >>
> > >> The two fix patches from mine aimed at DPDK version after 19.11. So
> > >> they
> > >only need to be backported in 20.11.
> > >> 04bcc80204  Xuan Ding        net/virtio: fix indirect descriptor reconnection
> > >> ad6f01945a  Xuan Ding        net/virtio: fix avail descriptor ID
> > >
> > >Thank you,
> > >they both refer to fix a patch that in turn fixes issues that existed before
> 19.11.
> > >Hence they came into the candidate list.
> > >
> > >For the second one you are right, this isn't present, but 04bcc80204
> > >refers to fix 8c1df884.
> > >And 8c1df884 is in 19.11.x as:
> > >
> > >commit 8c1df8846b15bf87beee2907dd9ecb5d5adaca1d
> > >Author: Marvin Liu <yong.liu@intel.com>
> > >Date:   Mon Sep 28 16:20:51 2020 +0800
> > >
> > >    net/virtio: fix packed ring indirect descricptors setup
> > >
> > >    [ upstream commit 381f39ebb78a35d8dcc2d4500419644c7de5400f ]
> > >
> > >
> > >So do we really not need/want it?
> >
> > Thanks for your confirmation.
> > For 04bcc80204, I will send out a patch.
> 
> Thanks in advance

The fix patch has been updated.

> 
> 
> > BTW, ad6f01945a refers to b473061b0e1d ("net/virtio: fix indirect descriptors
> in packed datapaths").
> > Why hasn't this patch been backported in 19.11?
> 
> It was identified way back in time in
> http://mails.dpdk.org/archives/stable/2020-November/026232.html
> 
> But it didn't apply and no one bothered backporting.
> Please feel free to provide backports for both b473061b0e1d + ad6f01945a if
> you want to get them into 19.11.11.
  
Packed ring feature is not popular at the moment, and it requests lots of code modifications.
I suggest not backport b473061b0e1d + ad6f01945a in 19.11.

Thanks,
Xuan

> 
> > Regards,
> > Xuan
> >
> > >
> > >> Thanks for your reminder.
> > >>
> > >> Regards,
> > >> Xuan
> > >
> > >
> > >--
> > >Christian Ehrhardt
> > >Staff Engineer, Ubuntu Server
> > >Canonical Ltd
> 
> 
> 
> --
> Christian Ehrhardt
> Staff Engineer, Ubuntu Server
> Canonical Ltd