patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] net/virtio: fix indirect descriptors reconnection
@ 2021-08-19  5:35 Xuan Ding
  2021-09-23  8:15 ` Maxime Coquelin
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Xuan Ding @ 2021-08-19  5:35 UTC (permalink / raw)
  To: maxime.coquelin, chenbo.xia
  Cc: dev, jiayu.hu, yinan.wang, Xuan Ding, stable, yong.liu

Since packed indirect descriptors are added and initialized when
initializing vring, the reconnection path also needs to be considered.

Fixes: 381f39ebb78a ("net/virtio: fix packed ring indirect descricptors setup")
Cc: stable@dpdk.org
Cc: yong.liu@intel.com

Signed-off-by: Xuan Ding <xuan.ding@intel.com>
---
 drivers/net/virtio/virtqueue.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c
index 1f9af3c31b..47229f35c4 100644
--- a/drivers/net/virtio/virtqueue.c
+++ b/drivers/net/virtio/virtqueue.c
@@ -208,6 +208,20 @@ virtqueue_txvq_reset_packed(struct virtqueue *vq)
 			rte_pktmbuf_free(dxp->cookie);
 			dxp->cookie = NULL;
 		}
+
+		struct virtio_tx_region *txr;
+		txr = txvq->virtio_net_hdr_mz->addr;
+		/* first indirect descriptor is always the tx header */
+		struct vring_packed_desc *start_dp =
+			txr[desc_idx].tx_packed_indir;
+		vring_desc_init_indirect_packed(start_dp,
+		      RTE_DIM(txr[desc_idx].tx_packed_indir));
+		start_dp->addr = txvq->virtio_net_hdr_mem
+			+ desc_idx * sizeof(*txr)
+			+ offsetof(struct virtio_tx_region,
+				   tx_hdr);
+		start_dp->len = vq->hw->vtnet_hdr_size;
+
 	}
 
 	vring_desc_init_packed(vq, size);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [PATCH] net/virtio: fix indirect descriptors reconnection
  2021-08-19  5:35 [dpdk-stable] [PATCH] net/virtio: fix indirect descriptors reconnection Xuan Ding
@ 2021-09-23  8:15 ` Maxime Coquelin
  2021-09-23  8:35   ` Ding, Xuan
  2021-10-13  0:28 ` Wang, Yinan
  2021-10-13  1:36 ` [dpdk-stable] [PATCH v2] " Xuan Ding
  2 siblings, 1 reply; 9+ messages in thread
From: Maxime Coquelin @ 2021-09-23  8:15 UTC (permalink / raw)
  To: Xuan Ding, chenbo.xia; +Cc: dev, jiayu.hu, yinan.wang, stable, yong.liu

Hi Xuan,

On 8/19/21 07:35, Xuan Ding wrote:
> Since packed indirect descriptors are added and initialized when
> initializing vring, the reconnection path also needs to be considered.
> 
> Fixes: 381f39ebb78a ("net/virtio: fix packed ring indirect descricptors setup")
> Cc: stable@dpdk.org
> Cc: yong.liu@intel.com
> 
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> ---
>   drivers/net/virtio/virtqueue.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c
> index 1f9af3c31b..47229f35c4 100644
> --- a/drivers/net/virtio/virtqueue.c
> +++ b/drivers/net/virtio/virtqueue.c
> @@ -208,6 +208,20 @@ virtqueue_txvq_reset_packed(struct virtqueue *vq)
>   			rte_pktmbuf_free(dxp->cookie);
>   			dxp->cookie = NULL;
>   		}

It makes me think we might save quite some bytes by not allocating
indirect descriptors when feature is not negotiated, but it might have
a cost in term of performance.

> +
> +		struct virtio_tx_region *txr;

Don't mix declarations within code.

> +		txr = txvq->virtio_net_hdr_mz->addr;
> +		/* first indirect descriptor is always the tx header */
> +		struct vring_packed_desc *start_dp =
> +			txr[desc_idx].tx_packed_indir;

Ditto.

> +		vring_desc_init_indirect_packed(start_dp,
> +		      RTE_DIM(txr[desc_idx].tx_packed_indir));
> +		start_dp->addr = txvq->virtio_net_hdr_mem
> +			+ desc_idx * sizeof(*txr)
> +			+ offsetof(struct virtio_tx_region,
> +				   tx_hdr);
> +		start_dp->len = vq->hw->vtnet_hdr_size;
> +
>   	}
>   
>   	vring_desc_init_packed(vq, size);
> 

Thanks,
Maxime


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [PATCH] net/virtio: fix indirect descriptors reconnection
  2021-09-23  8:15 ` Maxime Coquelin
@ 2021-09-23  8:35   ` Ding, Xuan
  2021-09-23  9:21     ` Ding, Xuan
  0 siblings, 1 reply; 9+ messages in thread
From: Ding, Xuan @ 2021-09-23  8:35 UTC (permalink / raw)
  To: Maxime Coquelin, Xia, Chenbo
  Cc: dev, Hu, Jiayu, Wang, Yinan, stable, Liu, Yong

Hi Maxime,

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Thursday, September 23, 2021 4:16 PM
> To: Ding, Xuan <xuan.ding@intel.com>; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; Wang, Yinan
> <yinan.wang@intel.com>; stable@dpdk.org; Liu, Yong <yong.liu@intel.com>
> Subject: Re: [PATCH] net/virtio: fix indirect descriptors reconnection
> 
> Hi Xuan,
> 
> On 8/19/21 07:35, Xuan Ding wrote:
> > Since packed indirect descriptors are added and initialized when
> > initializing vring, the reconnection path also needs to be considered.
> >
> > Fixes: 381f39ebb78a ("net/virtio: fix packed ring indirect descricptors setup")
> > Cc: stable@dpdk.org
> > Cc: yong.liu@intel.com
> >
> > Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> > ---
> >   drivers/net/virtio/virtqueue.c | 14 ++++++++++++++
> >   1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c
> > index 1f9af3c31b..47229f35c4 100644
> > --- a/drivers/net/virtio/virtqueue.c
> > +++ b/drivers/net/virtio/virtqueue.c
> > @@ -208,6 +208,20 @@ virtqueue_txvq_reset_packed(struct virtqueue *vq)
> >   			rte_pktmbuf_free(dxp->cookie);
> >   			dxp->cookie = NULL;
> >   		}
> 
> It makes me think we might save quite some bytes by not allocating
> indirect descriptors when feature is not negotiated, but it might have
> a cost in term of performance.

Do you mean we allocate the indirect descriptors after checking the indirect feature in virtio TX queue,
instead of allocating it at initialization?
If so, that makes sense, and hence we don't to initialize it in two places.

> 
> > +
> > +		struct virtio_tx_region *txr;
> 
> Don't mix declarations within code.
> 
> > +		txr = txvq->virtio_net_hdr_mz->addr;
> > +		/* first indirect descriptor is always the tx header */
> > +		struct vring_packed_desc *start_dp =
> > +			txr[desc_idx].tx_packed_indir;
> 
> Ditto.

Thanks, will update in next version.

Regards,
Xuan

> 
> > +		vring_desc_init_indirect_packed(start_dp,
> > +		      RTE_DIM(txr[desc_idx].tx_packed_indir));
> > +		start_dp->addr = txvq->virtio_net_hdr_mem
> > +			+ desc_idx * sizeof(*txr)
> > +			+ offsetof(struct virtio_tx_region,
> > +				   tx_hdr);
> > +		start_dp->len = vq->hw->vtnet_hdr_size;
> > +
> >   	}
> >
> >   	vring_desc_init_packed(vq, size);
> >
> 
> Thanks,
> Maxime


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [PATCH] net/virtio: fix indirect descriptors reconnection
  2021-09-23  8:35   ` Ding, Xuan
@ 2021-09-23  9:21     ` Ding, Xuan
  2021-10-12  8:48       ` Maxime Coquelin
  0 siblings, 1 reply; 9+ messages in thread
From: Ding, Xuan @ 2021-09-23  9:21 UTC (permalink / raw)
  To: Maxime Coquelin, Xia, Chenbo
  Cc: dev, Hu, Jiayu, Wang, Yinan, stable, Liu, Yong

Hi Maxime,

> -----Original Message-----
> From: Ding, Xuan
> Sent: Thursday, September 23, 2021 4:36 PM
> To: Maxime Coquelin <maxime.coquelin@redhat.com>; Xia, Chenbo
> <Chenbo.Xia@intel.com>
> Cc: dev@dpdk.org; Hu, Jiayu <Jiayu.Hu@intel.com>; Wang, Yinan
> <yinan.wang@intel.com>; stable@dpdk.org; Liu, Yong <yong.liu@intel.com>
> Subject: RE: [PATCH] net/virtio: fix indirect descriptors reconnection
> 
> Hi Maxime,
> 
> > -----Original Message-----
> > From: Maxime Coquelin <maxime.coquelin@redhat.com>
> > Sent: Thursday, September 23, 2021 4:16 PM
> > To: Ding, Xuan <xuan.ding@intel.com>; Xia, Chenbo <chenbo.xia@intel.com>
> > Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; Wang, Yinan
> > <yinan.wang@intel.com>; stable@dpdk.org; Liu, Yong <yong.liu@intel.com>
> > Subject: Re: [PATCH] net/virtio: fix indirect descriptors reconnection
> >
> > Hi Xuan,
> >
> > On 8/19/21 07:35, Xuan Ding wrote:
> > > Since packed indirect descriptors are added and initialized when
> > > initializing vring, the reconnection path also needs to be considered.
> > >
> > > Fixes: 381f39ebb78a ("net/virtio: fix packed ring indirect descricptors setup")
> > > Cc: stable@dpdk.org
> > > Cc: yong.liu@intel.com
> > >
> > > Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> > > ---
> > >   drivers/net/virtio/virtqueue.c | 14 ++++++++++++++
> > >   1 file changed, 14 insertions(+)
> > >
> > > diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c
> > > index 1f9af3c31b..47229f35c4 100644
> > > --- a/drivers/net/virtio/virtqueue.c
> > > +++ b/drivers/net/virtio/virtqueue.c
> > > @@ -208,6 +208,20 @@ virtqueue_txvq_reset_packed(struct virtqueue *vq)
> > >   			rte_pktmbuf_free(dxp->cookie);
> > >   			dxp->cookie = NULL;
> > >   		}
> >
> > It makes me think we might save quite some bytes by not allocating
> > indirect descriptors when feature is not negotiated, but it might have
> > a cost in term of performance.
> 
> Do you mean we allocate the indirect descriptors after checking the indirect
> feature in virtio TX queue,
> instead of allocating it at initialization?
> If so, that makes sense, and hence we don't to initialize it in two places.

Sorry for replying myself, as for performance, I can have a try and test the
impact on performance.

Thanks,
Xuan

> 
> >
> > > +
> > > +		struct virtio_tx_region *txr;
> >
> > Don't mix declarations within code.
> >
> > > +		txr = txvq->virtio_net_hdr_mz->addr;
> > > +		/* first indirect descriptor is always the tx header */
> > > +		struct vring_packed_desc *start_dp =
> > > +			txr[desc_idx].tx_packed_indir;
> >
> > Ditto.
> 
> Thanks, will update in next version.
> 
> Regards,
> Xuan
> 
> >
> > > +		vring_desc_init_indirect_packed(start_dp,
> > > +		      RTE_DIM(txr[desc_idx].tx_packed_indir));
> > > +		start_dp->addr = txvq->virtio_net_hdr_mem
> > > +			+ desc_idx * sizeof(*txr)
> > > +			+ offsetof(struct virtio_tx_region,
> > > +				   tx_hdr);
> > > +		start_dp->len = vq->hw->vtnet_hdr_size;
> > > +
> > >   	}
> > >
> > >   	vring_desc_init_packed(vq, size);
> > >
> >
> > Thanks,
> > Maxime


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [PATCH] net/virtio: fix indirect descriptors reconnection
  2021-09-23  9:21     ` Ding, Xuan
@ 2021-10-12  8:48       ` Maxime Coquelin
  0 siblings, 0 replies; 9+ messages in thread
From: Maxime Coquelin @ 2021-10-12  8:48 UTC (permalink / raw)
  To: Ding, Xuan, Xia, Chenbo; +Cc: dev, Hu, Jiayu, Wang, Yinan, stable, Liu, Yong



On 9/23/21 11:21, Ding, Xuan wrote:
> Hi Maxime,
> 
>> -----Original Message-----
>> From: Ding, Xuan
>> Sent: Thursday, September 23, 2021 4:36 PM
>> To: Maxime Coquelin <maxime.coquelin@redhat.com>; Xia, Chenbo
>> <Chenbo.Xia@intel.com>
>> Cc: dev@dpdk.org; Hu, Jiayu <Jiayu.Hu@intel.com>; Wang, Yinan
>> <yinan.wang@intel.com>; stable@dpdk.org; Liu, Yong <yong.liu@intel.com>
>> Subject: RE: [PATCH] net/virtio: fix indirect descriptors reconnection
>>
>> Hi Maxime,
>>
>>> -----Original Message-----
>>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>>> Sent: Thursday, September 23, 2021 4:16 PM
>>> To: Ding, Xuan <xuan.ding@intel.com>; Xia, Chenbo <chenbo.xia@intel.com>
>>> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; Wang, Yinan
>>> <yinan.wang@intel.com>; stable@dpdk.org; Liu, Yong <yong.liu@intel.com>
>>> Subject: Re: [PATCH] net/virtio: fix indirect descriptors reconnection
>>>
>>> Hi Xuan,
>>>
>>> On 8/19/21 07:35, Xuan Ding wrote:
>>>> Since packed indirect descriptors are added and initialized when
>>>> initializing vring, the reconnection path also needs to be considered.
>>>>
>>>> Fixes: 381f39ebb78a ("net/virtio: fix packed ring indirect descricptors setup")
>>>> Cc: stable@dpdk.org
>>>> Cc: yong.liu@intel.com
>>>>
>>>> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
>>>> ---
>>>>    drivers/net/virtio/virtqueue.c | 14 ++++++++++++++
>>>>    1 file changed, 14 insertions(+)
>>>>
>>>> diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c
>>>> index 1f9af3c31b..47229f35c4 100644
>>>> --- a/drivers/net/virtio/virtqueue.c
>>>> +++ b/drivers/net/virtio/virtqueue.c
>>>> @@ -208,6 +208,20 @@ virtqueue_txvq_reset_packed(struct virtqueue *vq)
>>>>    			rte_pktmbuf_free(dxp->cookie);
>>>>    			dxp->cookie = NULL;
>>>>    		}
>>>
>>> It makes me think we might save quite some bytes by not allocating
>>> indirect descriptors when feature is not negotiated, but it might have
>>> a cost in term of performance.
>>
>> Do you mean we allocate the indirect descriptors after checking the indirect
>> feature in virtio TX queue,
>> instead of allocating it at initialization?
>> If so, that makes sense, and hence we don't to initialize it in two places.
> 
> Sorry for replying myself, as for performance, I can have a try and test the
> impact on performance.

Thanks for looking at this, but maybe that could be done later, after
having the fix merged first if you don't have the bandwidth?

Maxime
> Thanks,
> Xuan
> 
>>
>>>
>>>> +
>>>> +		struct virtio_tx_region *txr;
>>>
>>> Don't mix declarations within code.
>>>
>>>> +		txr = txvq->virtio_net_hdr_mz->addr;
>>>> +		/* first indirect descriptor is always the tx header */
>>>> +		struct vring_packed_desc *start_dp =
>>>> +			txr[desc_idx].tx_packed_indir;
>>>
>>> Ditto.
>>
>> Thanks, will update in next version.
>>
>> Regards,
>> Xuan
>>
>>>
>>>> +		vring_desc_init_indirect_packed(start_dp,
>>>> +		      RTE_DIM(txr[desc_idx].tx_packed_indir));
>>>> +		start_dp->addr = txvq->virtio_net_hdr_mem
>>>> +			+ desc_idx * sizeof(*txr)
>>>> +			+ offsetof(struct virtio_tx_region,
>>>> +				   tx_hdr);
>>>> +		start_dp->len = vq->hw->vtnet_hdr_size;
>>>> +
>>>>    	}
>>>>
>>>>    	vring_desc_init_packed(vq, size);
>>>>
>>>
>>> Thanks,
>>> Maxime
> 


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [PATCH] net/virtio: fix indirect descriptors reconnection
  2021-08-19  5:35 [dpdk-stable] [PATCH] net/virtio: fix indirect descriptors reconnection Xuan Ding
  2021-09-23  8:15 ` Maxime Coquelin
@ 2021-10-13  0:28 ` Wang, Yinan
  2021-10-13  1:36 ` [dpdk-stable] [PATCH v2] " Xuan Ding
  2 siblings, 0 replies; 9+ messages in thread
From: Wang, Yinan @ 2021-10-13  0:28 UTC (permalink / raw)
  To: Ding, Xuan, maxime.coquelin, Xia, Chenbo
  Cc: dev, Hu, Jiayu, stable, Liu, Yong

Tested-by: Yinan Wang <yinan.wang@intel.com>

> -----Original Message-----
> From: Ding, Xuan <xuan.ding@intel.com>
> Sent: 2021?8?19? 13:35
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; Wang, Yinan
> <yinan.wang@intel.com>; Ding, Xuan <xuan.ding@intel.com>;
> stable@dpdk.org; Liu, Yong <yong.liu@intel.com>
> Subject: [PATCH] net/virtio: fix indirect descriptors reconnection
> 
> Since packed indirect descriptors are added and initialized when
> initializing vring, the reconnection path also needs to be considered.
> 
> Fixes: 381f39ebb78a ("net/virtio: fix packed ring indirect descricptors setup")
> Cc: stable@dpdk.org
> Cc: yong.liu@intel.com
> 
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [dpdk-stable] [PATCH v2] net/virtio: fix indirect descriptors reconnection
  2021-08-19  5:35 [dpdk-stable] [PATCH] net/virtio: fix indirect descriptors reconnection Xuan Ding
  2021-09-23  8:15 ` Maxime Coquelin
  2021-10-13  0:28 ` Wang, Yinan
@ 2021-10-13  1:36 ` Xuan Ding
  2021-10-14  7:59   ` Maxime Coquelin
  2021-10-21 12:32   ` Maxime Coquelin
  2 siblings, 2 replies; 9+ messages in thread
From: Xuan Ding @ 2021-10-13  1:36 UTC (permalink / raw)
  To: dev, maxime.coquelin, chenbo.xia
  Cc: jiayu.hu, yinan.wang, Xuan Ding, stable, yong.liu

Add initialization for packed ring indirect descriptors
in reconnection path.

Fixes: 381f39ebb78a ("net/virtio: fix packed ring indirect descricptors setup")
Cc: stable@dpdk.org
Cc: yong.liu@intel.com

Signed-off-by: Xuan Ding <xuan.ding@intel.com>
Tested-by: Yinan Wang <yinan.wang@intel.com>
---

v2:
* Fix the position of some declarations.
---
 drivers/net/virtio/virtqueue.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c
index 1f9af3c31b..65bf792eb0 100644
--- a/drivers/net/virtio/virtqueue.c
+++ b/drivers/net/virtio/virtqueue.c
@@ -186,6 +186,8 @@ virtqueue_txvq_reset_packed(struct virtqueue *vq)
 	struct vq_desc_extra *dxp;
 	struct virtnet_tx *txvq;
 	uint16_t desc_idx;
+	struct virtio_tx_region *txr;
+	struct vring_packed_desc *start_dp;
 
 	vq->vq_used_cons_idx = 0;
 	vq->vq_desc_head_idx = 0;
@@ -198,6 +200,7 @@ virtqueue_txvq_reset_packed(struct virtqueue *vq)
 	vq->vq_packed.event_flags_shadow = 0;
 
 	txvq = &vq->txq;
+	txr = txvq->virtio_net_hdr_mz->addr;
 	memset(txvq->mz->addr, 0, txvq->mz->len);
 	memset(txvq->virtio_net_hdr_mz->addr, 0,
 		txvq->virtio_net_hdr_mz->len);
@@ -208,6 +211,17 @@ virtqueue_txvq_reset_packed(struct virtqueue *vq)
 			rte_pktmbuf_free(dxp->cookie);
 			dxp->cookie = NULL;
 		}
+
+		if (virtio_with_feature(vq->hw, VIRTIO_RING_F_INDIRECT_DESC)) {
+			/* first indirect descriptor is always the tx header */
+			start_dp = txr[desc_idx].tx_packed_indir;
+			vring_desc_init_indirect_packed(start_dp,
+							RTE_DIM(txr[desc_idx].tx_packed_indir));
+			start_dp->addr = txvq->virtio_net_hdr_mem
+					 + desc_idx * sizeof(*txr)
+					 + offsetof(struct virtio_tx_region, tx_hdr);
+			start_dp->len = vq->hw->vtnet_hdr_size;
+		}
 	}
 
 	vring_desc_init_packed(vq, size);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [PATCH v2] net/virtio: fix indirect descriptors reconnection
  2021-10-13  1:36 ` [dpdk-stable] [PATCH v2] " Xuan Ding
@ 2021-10-14  7:59   ` Maxime Coquelin
  2021-10-21 12:32   ` Maxime Coquelin
  1 sibling, 0 replies; 9+ messages in thread
From: Maxime Coquelin @ 2021-10-14  7:59 UTC (permalink / raw)
  To: Xuan Ding, dev, chenbo.xia; +Cc: jiayu.hu, yinan.wang, stable, yong.liu



On 10/13/21 03:36, Xuan Ding wrote:
> Add initialization for packed ring indirect descriptors
> in reconnection path.
> 
> Fixes: 381f39ebb78a ("net/virtio: fix packed ring indirect descricptors setup")
> Cc: stable@dpdk.org
> Cc: yong.liu@intel.com
> 
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> Tested-by: Yinan Wang <yinan.wang@intel.com>
> ---
> 
> v2:
> * Fix the position of some declarations.
> ---
>   drivers/net/virtio/virtqueue.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks!
Maxime


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-stable] [PATCH v2] net/virtio: fix indirect descriptors reconnection
  2021-10-13  1:36 ` [dpdk-stable] [PATCH v2] " Xuan Ding
  2021-10-14  7:59   ` Maxime Coquelin
@ 2021-10-21 12:32   ` Maxime Coquelin
  1 sibling, 0 replies; 9+ messages in thread
From: Maxime Coquelin @ 2021-10-21 12:32 UTC (permalink / raw)
  To: Xuan Ding, dev, chenbo.xia; +Cc: jiayu.hu, yinan.wang, stable, yong.liu



On 10/13/21 03:36, Xuan Ding wrote:
> Add initialization for packed ring indirect descriptors
> in reconnection path.
> 
> Fixes: 381f39ebb78a ("net/virtio: fix packed ring indirect descricptors setup")
> Cc: stable@dpdk.org
> Cc: yong.liu@intel.com
> 
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> Tested-by: Yinan Wang <yinan.wang@intel.com>
> ---
> 
> v2:
> * Fix the position of some declarations.
> ---
>   drivers/net/virtio/virtqueue.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>

Applied to dpdk-next-virtio/main.

Thanks,
Maxime


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-10-21 12:33 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-19  5:35 [dpdk-stable] [PATCH] net/virtio: fix indirect descriptors reconnection Xuan Ding
2021-09-23  8:15 ` Maxime Coquelin
2021-09-23  8:35   ` Ding, Xuan
2021-09-23  9:21     ` Ding, Xuan
2021-10-12  8:48       ` Maxime Coquelin
2021-10-13  0:28 ` Wang, Yinan
2021-10-13  1:36 ` [dpdk-stable] [PATCH v2] " Xuan Ding
2021-10-14  7:59   ` Maxime Coquelin
2021-10-21 12:32   ` Maxime Coquelin

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git