From: Li Zhang <lizh@nvidia.com>
To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
Raslan Darawsheh <rasland@nvidia.com>
Cc: Ori Kam <orika@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>, Shun Hao <shunh@nvidia.com>,
"dev@dpdk.org" <dev@dpdk.org>, Roni Bar Yanai <roniba@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v5] doc: document a limitation for a meter with RSS action
Date: Wed, 27 Oct 2021 05:41:26 +0000 [thread overview]
Message-ID: <BN9PR12MB5307B4D45864BAD2185FDFFEBF859@BN9PR12MB5307.namprd12.prod.outlook.com> (raw)
In-Reply-To: <2167976.HXJ6VH1fBQ@thomas>
Thanks!
I will update it into patch v6 according to your comments.
Please take a look.
Regards,
Li Zhang
-----Original Message-----
From: Thomas Monjalon <thomas@monjalon.net>
Sent: Tuesday, October 26, 2021 8:28 PM
To: Li Zhang <lizh@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>
Cc: Ori Kam <orika@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>; Shun Hao <shunh@nvidia.com>; dev@dpdk.org; Roni Bar Yanai <roniba@nvidia.com>; stable@dpdk.org
Subject: Re: [PATCH v5] doc: document a limitation for a meter with RSS action
External email: Use caution opening links or attachments
The title should mention "mlx5 guide" as the scope.
26/10/2021 13:53, Li Zhang:
> A meter policy with RSS/Queue action is not supported when
> ``dv_xmeta_en`` enabled.
The quotes are RST syntax.
Raslan, while merging, you can remove the quotes from the commit log.
>
> When ``dv_xmeta_en`` enabled in legacy creating flow, it will split
> into two flows (one set_tag with jump flow and one RSS/queue action
> flow).
> For meter policy as termination table, it cannot split flow and cannot
> support when ``dv_xmeta_en`` enabled.
>
> Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
> Cc: stable@dpdk.org
>
> Signed-off-by: Li Zhang <lizh@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> doc/guides/nics/mlx5.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index
> 47709d93b3..cd28c04c1e 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -435,6 +435,7 @@ Limitations
> - yellow: QUEUE, RSS, PORT_ID, REPRESENTED_PORT, JUMP, DROP, MARK and SET_TAG.
> - RED: must be DROP.
> - Policy actions of RSS for green and yellow should have the same configuration except queues.
> + - Policy with RSS/queue action is not supported when ``dv_xmeta_en`` enabled.
> - meter profile packet mode is supported.
> - meter profiles of RFC2697, RFC2698 and RFC4115 are supported.
next prev parent reply other threads:[~2021-10-27 5:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 2:08 [dpdk-stable] [PATCH] " Li Zhang
2021-10-26 9:24 ` Li Zhang
2021-10-26 9:27 ` [dpdk-stable] [PATCH v2] " Li Zhang
2021-10-26 9:31 ` [dpdk-stable] [PATCH v3] " Li Zhang
2021-10-26 9:51 ` Thomas Monjalon
2021-10-26 10:12 ` Li Zhang
2021-10-26 10:10 ` [dpdk-stable] [PATCH v4] " Li Zhang
2021-10-26 10:15 ` Thomas Monjalon
2021-10-26 11:54 ` Li Zhang
2021-10-26 11:53 ` [dpdk-stable] [PATCH v5] " Li Zhang
2021-10-26 12:28 ` Thomas Monjalon
2021-10-27 5:41 ` Li Zhang [this message]
2021-10-27 5:39 ` [dpdk-stable] [PATCH v6] " Li Zhang
2021-10-27 9:13 ` [dpdk-stable] [PATCH v7] doc: add metering limitation in mlx5 guide Li Zhang
2021-10-31 13:28 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR12MB5307B4D45864BAD2185FDFFEBF859@BN9PR12MB5307.namprd12.prod.outlook.com \
--to=lizh@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=roniba@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=shunh@nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).