[PATCH 1/3] common/cnxk: fix build warnings on ubuntu 24.04

[PATCH 1/3] common/cnxk: fix build warnings on ubuntu 24.04

[skori]

From: Sunil Kumar Kori <skori@marvell.com>

Bugzilla ID: 1513
Fixes: 39ac394aa7a8 ("common/cnxk: fix device MSI-X greater than default value")
Cc: stable@dpdk.org

Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
 drivers/common/cnxk/roc_irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/common/cnxk/roc_irq.c b/drivers/common/cnxk/roc_irq.c
index a709c4047d..0b21b9e2d9 100644
--- a/drivers/common/cnxk/roc_irq.c
+++ b/drivers/common/cnxk/roc_irq.c
@@ -15,7 +15,7 @@
 
 #define MSIX_IRQ_SET_BUF_LEN                                                   \
 	(sizeof(struct vfio_irq_set) + sizeof(int) *			       \
-			(plt_intr_max_intr_get(intr_handle)))
+			((uint32_t)plt_intr_max_intr_get(intr_handle)))
 
 static int
 irq_get_info(struct plt_intr_handle *intr_handle)
-- 
2.43.0

[PATCH 2/3] regex/cn9k: fix build warnings on ubuntu 24.04

[skori]

From: Sunil Kumar Kori <skori@marvell.com>

Bugzilla ID: 1513
Fixes: 72c00ae9dba7 ("regex/cn9k: use cnxk infrastructure")
Cc: stable@dpdk.org

Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
 drivers/regex/cn9k/cn9k_regexdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regex/cn9k/cn9k_regexdev.c b/drivers/regex/cn9k/cn9k_regexdev.c
index aa809ab5bf..e635980183 100644
--- a/drivers/regex/cn9k/cn9k_regexdev.c
+++ b/drivers/regex/cn9k/cn9k_regexdev.c
@@ -271,7 +271,7 @@ static inline int
 ree_enqueue(struct roc_ree_qp *qp, struct rte_regex_ops *op,
 		 struct roc_ree_pending_queue *pend_q)
 {
-	union roc_ree_inst inst;
+	union roc_ree_inst inst = {0};
 	union ree_res *res;
 	uint32_t offset;
 
-- 
2.43.0

[PATCH 3/3] net/cnxk: fix build warnings on ubuntu 24.04

[skori]

From: Sunil Kumar Kori <skori@marvell.com>

Bugzilla ID: 1513
Fixes: 03b152389fb1 ("net/cnxk: add option to enable custom inbound SA")
Fixes: 7df4ead35436 ("net/cnxk: support parsing custom SA action")
Fixes: 47cca253d605 ("net/cnxk: support Rx inject")
Cc: stable@dpdk.org

Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
 drivers/net/cnxk/cnxk_ethdev_devargs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/cnxk/cnxk_ethdev_devargs.c b/drivers/net/cnxk/cnxk_ethdev_devargs.c
index 5bd50bb9a1..ecc2ea8b77 100644
--- a/drivers/net/cnxk/cnxk_ethdev_devargs.c
+++ b/drivers/net/cnxk/cnxk_ethdev_devargs.c
@@ -305,12 +305,12 @@ cnxk_ethdev_parse_devargs(struct rte_devargs *devargs, struct cnxk_eth_dev *dev)
 	uint16_t scalar_enable = 0;
 	uint16_t tx_compl_ena = 0;
 	uint16_t custom_sa_act = 0;
-	uint8_t custom_inb_sa = 0;
+	uint16_t custom_inb_sa = 0;
 	struct rte_kvargs *kvlist;
 	uint32_t meta_buf_sz = 0;
+	uint16_t lock_rx_ctx = 0;
+	uint16_t rx_inj_ena = 0;
 	uint16_t no_inl_dev = 0;
-	uint8_t lock_rx_ctx = 0;
-	uint8_t rx_inj_ena = 0;
 
 	memset(&sdp_chan, 0, sizeof(sdp_chan));
 	memset(&pre_l2_info, 0, sizeof(struct flow_pre_l2_size_info));
-- 
2.43.0

RE: [PATCH 2/3] regex/cn9k: fix build warnings on ubuntu 24.04

[Jerin Jacob]

[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]



> -----Original Message-----
> From: skori@marvell.com <skori@marvell.com>
> Sent: Thursday, November 14, 2024 1:08 PM
> To: Liron Himi <lironh@marvell.com>; Jerin Jacob <jerinj@marvell.com>
> Cc: dev@dpdk.org; alialnu@nvidia.com; Sunil Kumar Kori
> <skori@marvell.com>; stable@dpdk.org
> Subject: [PATCH 2/3] regex/cn9k: fix build warnings on ubuntu 24.04
> 
> From: Sunil Kumar Kori <skori@marvell.com>
> 
> Bugzilla ID: 1513
> Fixes: 72c00ae9dba7 ("regex/cn9k: use cnxk infrastructure")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
>  drivers/regex/cn9k/cn9k_regexdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regex/cn9k/cn9k_regexdev.c
> b/drivers/regex/cn9k/cn9k_regexdev.c
> index aa809ab5bf..e635980183 100644
> --- a/drivers/regex/cn9k/cn9k_regexdev.c
> +++ b/drivers/regex/cn9k/cn9k_regexdev.c
> @@ -271,7 +271,7 @@ static inline int
>  ree_enqueue(struct roc_ree_qp *qp, struct rte_regex_ops *op,
>  		 struct roc_ree_pending_queue *pend_q)  {
> -	union roc_ree_inst inst;
> +	union roc_ree_inst inst = {0};

This changes are in fastpath and it is costly. Please fix with other means or suppress the warning if it not relevant.
I skipped this patch for the merged and 1/3, 3/3 patches are  pplied to dpdk-next-net-mrvl/for-main. Thanks

>  	union ree_res *res;
>  	uint32_t offset;
> 
> --
> 2.43.0


[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 15131 bytes --]

RE: [PATCH 2/3] regex/cn9k: fix build warnings on ubuntu 24.04

[Sunil Kumar Kori]

> -----Original Message-----
> From: Jerin Jacob <jerinj@marvell.com>
> Sent: Monday, November 18, 2024 2:11 PM
> To: Sunil Kumar Kori <skori@marvell.com>; Liron Himi <lironh@marvell.com>
> Cc: dev@dpdk.org; alialnu@nvidia.com; Sunil Kumar Kori
> <skori@marvell.com>; stable@dpdk.org
> Subject: RE: [PATCH 2/3] regex/cn9k: fix build warnings on ubuntu 24.04
> 
> 
> 
> > -----Original Message-----
> > From: skori@marvell.com <skori@marvell.com>
> > Sent: Thursday, November 14, 2024 1:08 PM
> > To: Liron Himi <lironh@marvell.com>; Jerin Jacob <jerinj@marvell.com>
> > Cc: dev@dpdk.org; alialnu@nvidia.com; Sunil Kumar Kori
> > <skori@marvell.com>; stable@dpdk.org
> > Subject: [PATCH 2/3] regex/cn9k: fix build warnings on ubuntu 24.04
> >
> > From: Sunil Kumar Kori <skori@marvell.com>
> >
> > Bugzilla ID: 1513
> > Fixes: 72c00ae9dba7 ("regex/cn9k: use cnxk infrastructure")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> > ---
> >  drivers/regex/cn9k/cn9k_regexdev.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/regex/cn9k/cn9k_regexdev.c
> > b/drivers/regex/cn9k/cn9k_regexdev.c
> > index aa809ab5bf..e635980183 100644
> > --- a/drivers/regex/cn9k/cn9k_regexdev.c
> > +++ b/drivers/regex/cn9k/cn9k_regexdev.c
> > @@ -271,7 +271,7 @@ static inline int
> >  ree_enqueue(struct roc_ree_qp *qp, struct rte_regex_ops *op,
> >  		 struct roc_ree_pending_queue *pend_q)  {
> > -	union roc_ree_inst inst;
> > +	union roc_ree_inst inst = {0};
> 
> This changes are in fastpath and it is costly. Please fix with other means or
> suppress the warning if it not relevant.
> I skipped this patch for the merged and 1/3, 3/3 patches are  pplied to dpdk-
> next-net-mrvl/for-main. Thanks
Ack.
> 
> >  	union ree_res *res;
> >  	uint32_t offset;
> >
> > --
> > 2.43.0