From: "Chautru, Nicolas" <nicolas.chautru@intel.com>
To: Tom Rix <trix@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>,
"gakhil@marvell.com" <gakhil@marvell.com>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"Zhang, Mingshan" <mingshan.zhang@intel.com>,
"Joshi, Arun" <arun.joshi@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v1] baseband/acc100: fix 4GUL outbound size when CRC is dropped
Date: Mon, 4 Oct 2021 23:39:16 +0000 [thread overview]
Message-ID: <BY5PR11MB445107EDB01035332A34AF5FF8AE9@BY5PR11MB4451.namprd11.prod.outlook.com> (raw)
In-Reply-To: <2a661e89-aca6-4924-ff39-8d0da194093d@redhat.com>
Hi Akhil,
Can this be applied?
Thanks
Nic
> -----Original Message-----
> From: Tom Rix <trix@redhat.com>
> Sent: Saturday, September 11, 2021 12:19 PM
> To: Chautru, Nicolas <nicolas.chautru@intel.com>; dev@dpdk.org;
> gakhil@marvell.com
> Cc: thomas@monjalon.net; Zhang, Mingshan <mingshan.zhang@intel.com>;
> Joshi, Arun <arun.joshi@intel.com>; stable@dpdk.org
> Subject: Re: [PATCH v1] baseband/acc100: fix 4GUL outbound size when CRC
> is dropped
>
>
> On 9/7/21 6:39 PM, Nicolas Chautru wrote:
> > This patch fixes the issue by adjusting the outbound size after
> > turbodecoding when the appended CRC is meant to be dropped.
> >
> > Fixes: f404dfe35cc3 ("baseband/acc100: support 4G processing")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> > ---
> > drivers/baseband/acc100/rte_acc100_pmd.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c
> > b/drivers/baseband/acc100/rte_acc100_pmd.c
> > index 68ba523..b0485e7 100644
> > --- a/drivers/baseband/acc100/rte_acc100_pmd.c
> > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c
> > @@ -1744,7 +1744,8 @@
> >
> > next_triplet = acc100_dma_fill_blk_type_out(
> > desc, h_output, *h_out_offset,
> > - k >> 3, next_triplet,
> ACC100_DMA_BLKID_OUT_HARD);
> > + (k - crc24_overlap) >> 3, next_triplet,
> > + ACC100_DMA_BLKID_OUT_HARD);
> > if (unlikely(next_triplet < 0)) {
> > rte_bbdev_log(ERR,
> > "Mismatch between data to process and
> mbuf data length in
> > bbdev_op: %p",
>
> Thanks for this change, looks good.
>
> Reviewed-by: Tom Rix <trix@redhat.com>
>
next prev parent reply other threads:[~2021-10-04 23:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 1:39 Nicolas Chautru
2021-09-11 19:18 ` Tom Rix
2021-10-04 23:39 ` Chautru, Nicolas [this message]
2021-10-05 10:10 ` Akhil Goyal
2021-10-05 15:12 ` Chautru, Nicolas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR11MB445107EDB01035332A34AF5FF8AE9@BY5PR11MB4451.namprd11.prod.outlook.com \
--to=nicolas.chautru@intel.com \
--cc=arun.joshi@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=mingshan.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).