From: "Chautru, Nicolas" <nicolas.chautru@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Vargas, Hernan" <hernan.vargas@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v1 1/3] test/bbdev: explicit check for allocation failure
Date: Fri, 6 Jan 2023 15:37:19 +0000 [thread overview]
Message-ID: <BY5PR11MB4451FF0B730FC93EFDDAF039F8FB9@BY5PR11MB4451.namprd11.prod.outlook.com> (raw)
In-Reply-To: <0baf49cb-c209-7142-47e4-dc633c279b05@redhat.com>
Hi Maxime,
Yes this new commit fixes the last commit on the tree. You might want to merge these 2 commits into one or not.
I mentioned this in the cover letter I believe.
Thanks
Nic
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Friday, January 6, 2023 6:51 AM
> To: Chautru, Nicolas <nicolas.chautru@intel.com>; dev@dpdk.org
> Cc: Vargas, Hernan <hernan.vargas@intel.com>; stable@dpdk.org
> Subject: Re: [PATCH v1 1/3] test/bbdev: explicit check for allocation failure
>
> Hi Nicolas,
>
> On 12/15/22 00:33, Nicolas Chautru wrote:
> > Adding check for error on return of the rte_bbdev_*_op_alloc_bulk
> > calls in bbdev-test.
> >
> > Fixes: f714a18885a6 ("app/testbbdev: add test application for
> > bbdev")
>
> Above line should not be breaked, can be fixed while applying if no other
> comments on the series.
>
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> > ---
> > app/test-bbdev/test_bbdev_perf.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/app/test-bbdev/test_bbdev_perf.c
> > b/app/test-bbdev/test_bbdev_perf.c
> > index a922d69ada..b2096525ea 100644
> > --- a/app/test-bbdev/test_bbdev_perf.c
> > +++ b/app/test-bbdev/test_bbdev_perf.c
> > @@ -4959,7 +4959,7 @@ offload_latency_test_fft(struct rte_mempool
> *mempool, struct test_buffers *bufs,
> > burst_sz = num_to_process - dequeued;
> >
> > ret = rte_bbdev_fft_op_alloc_bulk(mempool, ops_enq,
> burst_sz);
> > - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops",
> ops_enq);
> > + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops",
> burst_sz);
> > if (test_vector.op_type != RTE_BBDEV_OP_NONE)
> > copy_reference_fft_op(ops_enq, burst_sz,
> dequeued,
> > bufs->inputs,
> > @@ -5042,7 +5042,7 @@ offload_latency_test_dec(struct rte_mempool
> *mempool, struct test_buffers *bufs,
> > burst_sz = num_to_process - dequeued;
> >
> > ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq,
> burst_sz);
> > - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops",
> ops_enq);
> > + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops",
> burst_sz);
> > if (test_vector.op_type != RTE_BBDEV_OP_NONE)
> > copy_reference_dec_op(ops_enq, burst_sz,
> dequeued,
> > bufs->inputs,
> > @@ -5128,7 +5128,7 @@ offload_latency_test_ldpc_dec(struct
> rte_mempool *mempool,
> > burst_sz = num_to_process - dequeued;
> >
> > ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq,
> burst_sz);
> > - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops",
> ops_enq);
> > + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops",
> burst_sz);
> > if (test_vector.op_type != RTE_BBDEV_OP_NONE)
> > copy_reference_ldpc_dec_op(ops_enq, burst_sz,
> dequeued,
> > bufs->inputs,
>
> The title and commit message does not seem to relate to the content of the
> patch. Is it actually fixing the patch I already merged?
>
> Thanks,
> Maxime
next prev parent reply other threads:[~2023-01-06 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221214233346.391973-1-nicolas.chautru@intel.com>
2022-12-14 23:33 ` Nicolas Chautru
2023-01-06 14:51 ` Maxime Coquelin
2023-01-06 15:37 ` Chautru, Nicolas [this message]
2023-01-10 8:32 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR11MB4451FF0B730FC93EFDDAF039F8FB9@BY5PR11MB4451.namprd11.prod.outlook.com \
--to=nicolas.chautru@intel.com \
--cc=dev@dpdk.org \
--cc=hernan.vargas@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).