From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B659BA0548 for ; Tue, 18 May 2021 06:27:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B4C54003E; Tue, 18 May 2021 06:27:04 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2089.outbound.protection.outlook.com [40.107.243.89]) by mails.dpdk.org (Postfix) with ESMTP id E9B254003E for ; Tue, 18 May 2021 06:27:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B2hTJAneQwfYe37ArFbqfsN7AsOiyytO/k6MG7JdqzihvVVFU3KZAHKPlU90BslzoL0jKac2m18hhus3YAve1ekqDbcu+7Cwms00sdUbrdk7+kt2HKV4gZ2mjP5Y40NhRWxkkWiIKBW6XvauHcybvSgHtQEE8T/vGb0rRIeYUB4AIHkUpHx9rOM0udjPPnEVcSHotVNprEdzfbH8sjqQyxcbSz7arxdT9AJZoL6X3eXP5p3CuJpbRb+jLlWOpTlvHcv+VO+eXFACBK5FqobVYZmrdjkx3Znq0fW7NVe7TvyJMVD5AQr6UBz+kNah1RggsXoQ53qV2zFJJHN5qe0q3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YG+4EVw/zJPkz/H4lJs7fIglj7/3J4Wyqw/G86CbUvU=; b=mLdoNsU2GldCILddLhFTYpFPk/6VRDmAYUDZL069sR9dBndX6IJZ6YJILeY2alzl0Ya6SplQZRpSKIpTvRe4inRzap9UBMuIAdOyyL3iSPHaE01OgeBr4m7TLobrAw/YaN13FlgXE5GjrwT/rLaj4r7FPxtB4fzBW2zcUo5HiM7UAoshIm2croE+9H1QUVUKxzoX418IHb9bqjncTuGhpfS156I4ldjFvz8+Jc6eTbkRkOswyKiEX6cMXTUVx9hv38ATvL4qp/7mrCYHA71bB2RfVxJPamI7xoFHolUivYRWzjJh5/8hu0vZboQ5q+hfgy7XW3yWqnVE6SdIw/33Tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YG+4EVw/zJPkz/H4lJs7fIglj7/3J4Wyqw/G86CbUvU=; b=MPctfpkiKbK99lmMs12xADSBZmTJVT5cMvV7qeKxg43nrZP7PVc1uu7sf3ljVscToiDGHnCZunOH2YXRGKFX0C4tyW8PBtjTmAyovWaCAhnYf+vW5hHc7ZzAGzaqpFUwRCiiFDRcmbXv9Lmcuc5btpwXHw0rcR9eildiwbA6B/LV4AICCoUGGjJjBUFI9FNqaJWLhHWhx8PuHLTlVnMBTIdNY6wVgdfDr0X1sjDmVtr06hw8WDmMFzgRFc7tm5aQb4DvnalB3mTcFMaxfSUWRX44TRxnPnX19ODfTXxlqbVDVXJUHnd1vm5dTL4lI8MAmpxPX55sxsN4PfKUgHX6Yg== Received: from BY5PR12MB4324.namprd12.prod.outlook.com (2603:10b6:a03:209::10) by BYAPR12MB4614.namprd12.prod.outlook.com (2603:10b6:a03:a6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.28; Tue, 18 May 2021 04:27:02 +0000 Received: from BY5PR12MB4324.namprd12.prod.outlook.com ([fe80::b919:53f4:6757:331c]) by BY5PR12MB4324.namprd12.prod.outlook.com ([fe80::b919:53f4:6757:331c%6]) with mapi id 15.20.4129.032; Tue, 18 May 2021 04:27:02 +0000 From: "Xueming(Steven) Li" To: "Min Hu (Connor)" , "stable@dpdk.org" CC: "ferruh.yigit@intel.com" Thread-Topic: [PATCH 20.11 3/4] net/hns3: fix timing in mailbox Thread-Index: AQHXSyOncPmAf65tFUeObO3tPQRBnqropcjQ Date: Tue, 18 May 2021 04:27:01 +0000 Message-ID: References: <1621259445-5182-1-git-send-email-humin29@huawei.com> <1621259445-5182-3-git-send-email-humin29@huawei.com> In-Reply-To: <1621259445-5182-3-git-send-email-humin29@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [180.174.128.225] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 96b81820-e294-4950-a476-08d919b52f2a x-ms-traffictypediagnostic: BYAPR12MB4614: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:376; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: e+eRQlosJEvw1UHrp3/2TCVCgF2YP6WeK9jMcZ+J015rdmJqKJU8WGSaK1OqJlOXM6PqmxXDfMYVBeCij9hzDCKwrbxSxNqnvV6+0NaBpwXva7ZVgGwaqcFfvSQ6zVxJ99b2Y+NOd85+BEhGP3QIa3figV7rv0NJpEqsu2M0vatmrWy+6RYGrvhiW6iPxOPuquN7l9eHFOLI5C/XrfduCYGkWRcMOXkkCaio9SA2N3FbTrg72tytAUYqsUDiFCbpe9NQxy/fWRUzQcESw0cK+I1uTkwzIW499l0tY9yEZ/z4JvuyT/u7cpV7+mP5flKKTAbJqkghFvZN5vk+ADtyWG06IcQpEy6Y9+/Vi5d5V1uXKkTJQg/Eb0pjUKmybHXwi44dLq2OjmOwjw069WQQcrUyKdxYwOxkf7VNZddhd8u2wlfsWSwpRw3DU2dAtBwI9MfAp4vjV2SO/p83/A+OMhVFs7U/XB9yOkD1B8gHPtgtpV489D9n6+vkifYGWgOHL2mWc5zOSWaIHW1O37qJ4zTS7sIWMvMUftDxT4qKeklTIlzgsk7Dag1xYCDVpxqh0Zk6R+aj3sbFu1LR0IgY7PGQNvel1ruWv/Iq9jaD8dU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR12MB4324.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(366004)(376002)(39860400002)(396003)(2906002)(38100700002)(66476007)(9686003)(53546011)(86362001)(186003)(6506007)(122000001)(55016002)(15650500001)(66556008)(66446008)(7696005)(478600001)(71200400001)(52536014)(66946007)(316002)(83380400001)(33656002)(76116006)(5660300002)(26005)(64756008)(8936002)(110136005)(4326008)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ZZfJkTrGUXxhXtcZuemzXQNhC7cLsjpwpByE8Got+NZeVT7XFJlPEWuWXTCz?= =?us-ascii?Q?Rov7rMeDJP/czEY0B+QrFYuCiIDt2gst3mdN7WcYoGkPNdpu0yd/6unifb4F?= =?us-ascii?Q?S0ZVcujrrqgKQA4ZaQ8MvfBZQjmyePBeVPOVBKw8H7sSymGTTs/ZH5NJ7TZC?= =?us-ascii?Q?kUx/SoaY0BE0ojZjn60lUlkQWSWVoWdPoc3Yf2R6+nB+/thyOx/PCA4QviBH?= =?us-ascii?Q?ckvywS4lsUBQA5MRRBeK2ar3Lho1+xgXlJztCgUo+1NbiZKWRJknh4DBIYcz?= =?us-ascii?Q?d8iHHeTkfCbsDZxe9o+pDaC61utM9KJHVuwyJ3bz+4FggB4HtlW+6nxN2/Ix?= =?us-ascii?Q?kBUQiNcDuAUmd/Z5h4+E9EqY2YNSLBQuQ44U1vPz9+5uDNvPSVL+rRNocdH8?= =?us-ascii?Q?nIGRLowqgZfnVDjuW22IKDODDbD2sl4GjwkgXDGU9eU8zqbuGucZxu0uksgg?= =?us-ascii?Q?QthrJ2Bo/Cvv8OD2p4argsmfJRjwr21D9FgINN2g6iciuPxjxGX3nV4FinzA?= =?us-ascii?Q?TQ+V3umqdGzifMVgIUYh2XPyuyStDvuHvkSYDxsFMFAyF5Sv1cMhK27zHnUN?= =?us-ascii?Q?q1T+ENuXKPwTqFcjifAYdUXuC+sli4zPwcfHApL8TNnLPT/jxeIUaRTXcTVt?= =?us-ascii?Q?62DLkOu8bjh71kA4UFtkjZfxU4ZrqHTJxAcwggty9U6NbeHYwyDsMKx8iey3?= =?us-ascii?Q?92wZFAd2A2KTk1sz9BJ9HAb+RTU8gZwtqJf9zF2XJ52tNdR+yp5FBwk5RgNl?= =?us-ascii?Q?K2O8Ov9PvpSm24owNknD6S0hahuuu2voNM/uAWx5yfOOASrg0qjSWQGxSiJl?= =?us-ascii?Q?QNuY+jVUuOkHwVKSFvz4EdwwCpLCezUWncScxLwTOEUn+T+xLzmfY9rDIc+j?= =?us-ascii?Q?NVCDpS0InVUI74CRHM5CGLzBVqL48ym0mK9QbiU2rKV3L9QJAQlZyCNgqBHw?= =?us-ascii?Q?3H7ejt9EzeP4rKH39+ISxo9Fd0tMpmWLc6YgucYVaGOkQrAs0ve0VeL5Z2wj?= =?us-ascii?Q?8H3pzz3qCL84ITF54v/gFI5xgRZus9qHf2TF4bg873PpQLTEt0tV+BqXuVhn?= =?us-ascii?Q?qsqAJaBK8NRfcUL2mrIQ37y0i7xPPM0gO2XzuIWAeLC75Y4uvQr1JYS7zC4t?= =?us-ascii?Q?SkyrxbZ4xdfS9SSBYQaJ96mKJj0AgjZSKeEKizzquliZoO7X0mOWHedAXnMf?= =?us-ascii?Q?2feG96opXbi/q/vhhETmd2FqeWpYw7rtk0riggbvdrP3mDJAcKwn5GX2TEVh?= =?us-ascii?Q?XCwUi8iobywicW0iN67KtUZuGfrPeSfWAdujyiLQm/+HPMqYARmWS9CIsVu0?= =?us-ascii?Q?LriPzpaV2sjMUNUYyMzzGUaW?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4324.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96b81820-e294-4950-a476-08d919b52f2a X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2021 04:27:01.8743 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YyvV6TYaOEyBB1DUNl5xRs9lN/y6cTdwzZ61PTYiy6DvN5a1X5NINwlqNxcKh3N0PxLtWmj7qZetkzSe+bdeBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB4614 Subject: Re: [dpdk-stable] [PATCH 20.11 3/4] net/hns3: fix timing in mailbox X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Thanks, merged > -----Original Message----- > From: Min Hu (Connor) > Sent: Monday, May 17, 2021 9:51 PM > To: stable@dpdk.org > Cc: ferruh.yigit@intel.com; Xueming(Steven) Li > Subject: [PATCH 20.11 3/4] net/hns3: fix timing in mailbox >=20 > From: Chengchang Tang >=20 > [ upstream commit d566bfcff0c7bfe167f6c520d4fd5b0104130af6 ] >=20 > Currently, when processing MBX messages, the system timestamp is obtained= to determine whether timeout occurs. However, the > gettimeofday function is not monotonically increasing. Therefore, this ma= y lead to incorrect judgment or difficulty exiting the loop. > And actually, in this scenario, it is not necessary to obtain the timesta= mp. >=20 > This patch deletes the call to the gettimeofday function during MBX messa= ge processing. >=20 > Fixes: 463e748964f5 ("net/hns3: support mailbox") > Cc: stable@dpdk.org >=20 > Signed-off-by: Chengchang Tang > Signed-off-by: Min Hu (Connor) > --- > drivers/net/hns3/hns3_mbx.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) >=20 > diff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c in= dex 11e5235..2a479f2 100644 > --- a/drivers/net/hns3/hns3_mbx.c > +++ b/drivers/net/hns3/hns3_mbx.c > @@ -61,13 +61,12 @@ static int > hns3_get_mbx_resp(struct hns3_hw *hw, uint16_t code, uint16_t subcode, > uint8_t *resp_data, uint16_t resp_len) { > -#define HNS3_MAX_RETRY_MS 500 > +#define HNS3_MAX_RETRY_US 500000 > #define HNS3_WAIT_RESP_US 100 > struct hns3_adapter *hns =3D HNS3_DEV_HW_TO_ADAPTER(hw); > struct hns3_mbx_resp_status *mbx_resp; > + uint32_t wait_time =3D 0; > bool received; > - uint64_t now; > - uint64_t end; >=20 > if (resp_len > HNS3_MBX_MAX_RESP_DATA_SIZE) { > hns3_err(hw, "VF mbx response len(=3D%u) exceeds maximum(=3D%d)", @@ -= 75,9 +74,7 @@ hns3_get_mbx_resp(struct > hns3_hw *hw, uint16_t code, uint16_t subcode, > return -EINVAL; > } >=20 > - now =3D get_timeofday_ms(); > - end =3D now + HNS3_MAX_RETRY_MS; > - while (now < end) { > + while (wait_time < HNS3_MAX_RETRY_US) { > if (rte_atomic16_read(&hw->reset.disable_cmd)) { > hns3_err(hw, "Don't wait for mbx respone because of " > "disable_cmd"); > @@ -103,10 +100,10 @@ hns3_get_mbx_resp(struct hns3_hw *hw, uint16_t code= , uint16_t subcode, > if (received) > break; >=20 > - now =3D get_timeofday_ms(); > + wait_time +=3D HNS3_WAIT_RESP_US; > } > hw->mbx_resp.req_msg_data =3D 0; > - if (now >=3D end) { > + if (wait_time >=3D HNS3_MAX_RETRY_US) { > hns3_mbx_proc_timeout(hw, code, subcode); > return -ETIME; > } > -- > 2.7.4