From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF131A0545 for ; Fri, 13 Nov 2020 08:41:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ABCDC56A3; Fri, 13 Nov 2020 08:41:35 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id A62E756A3; Fri, 13 Nov 2020 08:41:33 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 12 Nov 2020 23:41:36 -0800 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 13 Nov 2020 07:41:32 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 13 Nov 2020 07:41:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JlxTLKqkzQkT36Vv6d9AYPAaATDVr4MRM5x4jNDGvHrdXAhmDOhd3d9MYvW9qlTBgGVCxX27UlJ5i7KnpjKilxPJ4QpWQhECtTGmbVrGMQ2fW89tN1E9UHj8MK3S3EVs7F7dle34nHG+8d5GbftdeeKVAQ29t8kGhjeWR7bWTpJ6i+ZuKsWzhQBV0gnC1XAZS1vksdNMhXcJgowjgALJjg7XOMfSvKtkEK3vdbQQPsYpKtQ3uFVYP1lrK1C8qKs51KKyyd4jhUXyEdYLDI+ufEaE7phiYOWxGMPPz/x+7ZPyJcOfvxz/H3hkzrkXGS3QfRilI19DOIOqmN1mNle4pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=URq0LLPPvqKSXF7RY7dk/YJ56OWEooRpWABVV/LL5Jg=; b=EIWbv48GPfr1GIlJeUKQNf5QucOiLU7a49PgYqlOEMqdnUGo4a56x4zLSs35cn1aoUK2th1YNyZM6eN4lNQZqZosAbrUbMEj30dVw9gAp9KJuj+K1KCA1vdEUl8ncoHZ8MiiZWDIPrknhQlB4352mfFWTXJ+vyoWsYDPCbb7IXzyROxsC1x6Ja/+B5dgh8AfRudX6qLmruo/DdjEZxrm11CqpgdbDTt3LXac5d+EKuhVp+SFO1Me3Y+j7wIDvmIiJLpyLbaeI6fGx1TA6JWycRmnZpPt/D64kRGVoYPB4h23TqKOMq3t4xIbVrmFUJ9SyQUrwraVD3ArMuOkwzCQkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from BY5PR12MB4324.namprd12.prod.outlook.com (2603:10b6:a03:209::10) by BY5PR12MB4869.namprd12.prod.outlook.com (2603:10b6:a03:1d9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.25; Fri, 13 Nov 2020 07:41:31 +0000 Received: from BY5PR12MB4324.namprd12.prod.outlook.com ([fe80::3420:8913:2256:fa6f]) by BY5PR12MB4324.namprd12.prod.outlook.com ([fe80::3420:8913:2256:fa6f%2]) with mapi id 15.20.3541.025; Fri, 13 Nov 2020 07:41:31 +0000 From: "Xueming(Steven) Li" To: Maxime Coquelin , "dev@dpdk.org" , "xuan.ding@intel.com" , "stephen@networkplumber.org" , "NBU-Contact-Thomas Monjalon" , "stable@dpdk.org" , "chenbo.xia@intel.com" Thread-Topic: [PATCH v4 3/3] vhost: fix fd leak in kick setup Thread-Index: AQHWuRd3ttauFJGkykuf2rxuMfohfanFrocQ Date: Fri, 13 Nov 2020 07:41:31 +0000 Message-ID: References: <20201112171029.354593-1-maxime.coquelin@redhat.com> <20201112171029.354593-4-maxime.coquelin@redhat.com> In-Reply-To: <20201112171029.354593-4-maxime.coquelin@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [240e:46d:a900:5e1e:7896:40fd:fa19:79c8] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2f5ca709-d7cc-47cc-8379-08d887a789b1 x-ms-traffictypediagnostic: BY5PR12MB4869: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1169; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: t3DhyoZBacE5D8T0V7wEDgvDO6TeiDp7feRLMCOZdhm2XaumPm//gApBoglKHT7ZQtcz8bwlZyRVb/pHg3E4bda3/oqjtvGJAk2LMNk8c7KboYJ1Xx+um7mdJhmV/WDBH9sY2IXCnwCrG7QMGXmvg2y4Av3vksYL9KOufysi7weoVrEXaCkHCgbZ4A+1d+dC5gN4zr7XQSpNUOxKoeVpLwcoB6jtNwRHkgfPoE+3Jfrb+uAhI81Hao7NBUafc/0wto6yR2E3GHcf1vvZmI5k0wdZNxfw17XCq0z7PIwcXcH64f2YhExxU5aRlvoTkWh36kgPKc6OHOpVS3qRFK9FDQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR12MB4324.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(39860400002)(136003)(366004)(376002)(2906002)(33656002)(66946007)(8676002)(52536014)(86362001)(186003)(66476007)(64756008)(110136005)(76116006)(71200400001)(83380400001)(316002)(6506007)(8936002)(66446008)(66556008)(55016002)(5660300002)(7696005)(478600001)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: jfqhHbOtiOn+QX8US05GiDYZk9OiOLIV1AxwQqOrXd2hPpStwAFlGyPGw1q1dLkrzCDOfP0rhgcWr+pER7dfdHB4nYSQHFx0Jj9lp/AGhkUZdHcQPdDz5Tq0aJQTx4puyH3nN9oAAUDCb3gMe1cmjLJ42IhYNr8fmMPugAOr0SsE/H6Y5EhSJKaxowimzhLIb5XleQmO8L9iaxqXQ38XrqXIOxgxWv3fEakJxw/xdfxSrtZeboYlsN1uTX83itWJESeApnFP6HbWd2cyek+TssuEbWB5AhDNeNDmbuR48PL74jGsIAQBBMR2/WGZjpLO5EgItFBE2yg/kuZOtiDIqUII16vVBI/v74Om9XAM9xUjkNhDsj4coqrnVNpSqL5oFBa8LLsF3KgqrrGeML4WJ8bwgzwW4n0JNzwYfML1wrbvEqtwomq15oZiEoKS1kEAYMZcTYDkN1Q3Ie3f1BGT8ug1UXJxShvQM2zeSyTi1aP418e6JwNCQR9c+d4KWpBOLhY2X/s00R73hm+Di49N/CxivTNEVyVMBbSD7q/N5NXCDMEWqGs3dEXbUsrbATn11z8TL+ls2yKP+DRtPWNpncIlwZLQdIahDASv/ttG+h8cu+60z0ML0ItH6anqBtEGyp6NvVtqNSQ20jYo6U7TcR1etkJDnmx6mmYuOYN3phgKfwPU+9Vt5rqvz90fsT0oIcOH4rcPtfHw8wRYhI5Q7g== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4324.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f5ca709-d7cc-47cc-8379-08d887a789b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2020 07:41:31.1120 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kt1zCHHmjNWfttmQBzRbs8gHoPvNk0LecBHgfxSqSPxsDD8IgvUl8uxt/+n76HreLZnpfaTiqB44kPu8fNpJnw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4869 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605253296; bh=URq0LLPPvqKSXF7RY7dk/YJ56OWEooRpWABVV/LL5Jg=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=ScCi30/jrWkmGuMkyALdojtCRiSR5DzeWhS0Xq4ZX7qW77e3868X+OedLaFrgRGh3 vYVWpixLLbOOGClGzJTRVkClHRgJSkKGD+qGceR7+VVRVZxFSx1ANpxmAP4u+ksu6H jx4BEn8UjNJwg2mJMHBiSrIY6O66nxKSDrs1xErMhFUoJxKarRHMNhXw2SVpBZqgmF Fknz7sPAm/TZzJi81Csag4Amofr4kiWrYmSV03lh0LDUkQ2YLbXQmv5EdLBFOS4n3d XwqDgZzUKNlY4/1GnHNLjiPjhrVgSxxKSVBc56yBA/5ueHRvsXpOUs4zp7fHnoGBQl g7wr2EjOyQJew== Subject: Re: [dpdk-stable] [PATCH v4 3/3] vhost: fix fd leak in kick setup X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" >-----Original Message----- >From: Maxime Coquelin >Sent: Friday, November 13, 2020 1:10 AM >To: dev@dpdk.org; xuan.ding@intel.com; stephen@networkplumber.org; >NBU-Contact-Thomas Monjalon ; stable@dpdk.org; >chenbo.xia@intel.com; Xueming(Steven) Li >Cc: Maxime Coquelin >Subject: [PATCH v4 3/3] vhost: fix fd leak in kick setup > >This patch fixes a file descriptor leak which happens in the error path of >vhost_user_set_vring_kick(). > >Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application") >Cc: stable@dpdk.org > >Signed-off-by: Maxime Coquelin >Reviewed-by: Chenbo Xia >--- > lib/librte_vhost/vhost_user.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c= index >23c115f994..45c8ac09da 100644 >--- a/lib/librte_vhost/vhost_user.c >+++ b/lib/librte_vhost/vhost_user.c >@@ -1858,8 +1858,12 @@ vhost_user_set_vring_kick(struct virtio_net **pdev, >struct VhostUserMsg *msg, > > /* Interpret ring addresses only when ring is started. */ > dev =3D translate_ring_addresses(dev, file.index); >- if (!dev) >+ if (!dev) { >+ if (file.fd !=3D VIRTIO_INVALID_EVENTFD) >+ close(file.fd); >+ > return RTE_VHOST_MSG_RESULT_ERR; >+ } > > *pdev =3D dev; > >-- >2.26.2 Reviewed-by: Xueming(Steven) Li