Re: [dpdk-stable] patch 'app/testpmd: release flows left before port stop' has been queued to stable release 19.11.7

[Gregory Etelson <getelson@nvidia.com>]

Hello Christian,

> > > -----Original Message-----
> > > From: stable <stable-bounces@dpdk.org> On Behalf Of Christian
> > > Ehrhardt
> > > Sent: Thursday, February 4, 2021 1:30 PM
> > > To: Gregory Etelson <getelson@nvidia.com>
> > > Cc: Ori Kam <orika@nvidia.com>; Ajit Khaparde
> > > <ajit.khaparde@broadcom.com>; dpdk stable <stable@dpdk.org>
> > > Subject: [dpdk-stable] patch 'app/testpmd: release flows left before
> > > port stop' has been queued to stable release 19.11.7
> > >
> > > Hi,
> > >
> > > FYI, your patch has been queued to stable release 19.11.7
> > >
> > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
> > > It will be pushed if I get no objections before 02/06/21. So please
> > > shout if anyone has objections.
> > >
> > > Also note that after the patch there's a diff of the upstream commit
> > > vs the patch applied to the branch. This will indicate if there was
> > > any rebasing needed to apply to the stable branch. If there were
> > > code changes for rebasing
> > > (ie: not only metadata diffs), please double check that the rebase
> > > was correctly done.
> > >
> > > Queued patches are on a temporary branch at:
> > > https://github.com/cpaelzer/dpdk-stable-queue
> > >
> > > This queued commit can be viewed at:
> > > https://github.com/cpaelzer/dpdk-stable-
> > > queue/commit/ba53d40b4eb900d12beeb707c3cb163e421e6e85
> > >
> > > Thanks.
> > >
> > > Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > >
> > > ---
> >
> > Hi Christian,
> >
> > We would like to drop this patch from 19.11 since it's a new feature.
> Would that be possible? Should we send a patch that reverts it?
> 
> Hi,
> you don't need to send a revert, I can do that.
> Thanks for the IRC discussion btw!
> The one thing that might be worth is that you've said it is a new feature
> that should not be added, but just reading the patch description it sounds
> like just a fix. If you would not mind for some kind of trail (if we ever
> wonder) replying here with a bit more extended reasoning would be helpful.
> 

This testpmd patch is aligned with an update in RTE flows documentation described in
https://patchwork.dpdk.org/project/dpdk/patch/20200916111854.1949-1-getelson@nvidia.com/
The documentation update was introduced in dpdk-20.11. Earlier PMD releases do not function
according to proposed specification.

Regards,
Gregory 
   
> > Sorry we didn't respond ahead of time.
> >
> > Thanks,
> > Ali
> 
> 
> 
> --
> Christian Ehrhardt
> Staff Engineer, Ubuntu Server
> Canonical Ltd