From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D330A04DD for ; Thu, 5 Nov 2020 12:32:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5C210C30D; Thu, 5 Nov 2020 12:32:50 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E577DBE69; Thu, 5 Nov 2020 12:32:45 +0100 (CET) IronPort-SDR: 4FtPkQppfdG9/pO8ImYyAvenZo2eApGAzbCAsFRA1Hvr121IaYXEWS2t1liIgD/7vXeQp5GIsD ZfUe/eR541hQ== X-IronPort-AV: E=McAfee;i="6000,8403,9795"; a="233532764" X-IronPort-AV: E=Sophos;i="5.77,453,1596524400"; d="scan'208";a="233532764" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 03:32:41 -0800 IronPort-SDR: L9K9OmUVJ2UxR2/bf76cfm7vq+DYPTOuxMOOcpuuI1UZdDP6P4W+6CJL03+Kym3INFOFuPQX3a KW6Qd2H0ocNw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,453,1596524400"; d="scan'208";a="306489569" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga008.fm.intel.com with ESMTP; 05 Nov 2020 03:32:40 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 5 Nov 2020 03:32:40 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 5 Nov 2020 03:32:39 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 5 Nov 2020 03:32:39 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 5 Nov 2020 03:32:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AavROZzNZK4QOXI7cYcmahcdWsA0MYEotyBRY53PXbnK6Pt/pl0G7QoVcYG6S/JulP/TjJRTXoV3CNHdAJGvweraBE3qNhUi3/32PsPWbDZkNC+yLK6fE3B0ZLzvYzUjNc1Ik5h13JGZdlS7V2qXF+/LEosgwkRE8f59uFFs3IgJIYaRGQ5pBktNDlk9V3U4T3pCj6AHLvjzWTAc7cqroCBp7fjI1pqGI3IF4Hp6Es8mtAd4OzvVR4szrX9gN1EDDQgINlPKtqX+4seX9V5ATbVAeNGeQ1TOilpfOzleEpEMkITikdo3bcYo20BVJwqTOTToSON66w0Bo6AgPK7ILw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DF8dDqdEGOELlnHopqa3oPHh5FOR1hn0Y5jR2sGoY8c=; b=Tj+YRmK9R/BFM5QaZiuOSRLT12dAXx4P5J+r/rOlwWyHvkGDSDLrt01MNlcH2/gQMPEjRPIzp77tOtsApRamMf9qe3X0dk5X6bRAD6UZMzkP9fRpVr5zz6RoZu7uzrehMYFIsNVIwIQWCYdEJZsZax8scDbU7fVSBb26422CAlVPHts+5n41S2sYrQa1bD5rH+5F1FIW6JWgWzdhcZMdg8aa6jBv/znWU3ArjHmBi7q/St1yQ5TQHrLouvJHgIA4gkR+5bUHWpXPOdmhtBhB5iXllemuBtAlIGpKknKhfL9mg95qTmRLyN+Gi+LqRcWXsnxqy3L6hfDZMpA1Mv7a0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DF8dDqdEGOELlnHopqa3oPHh5FOR1hn0Y5jR2sGoY8c=; b=Kt/cyyyochCV7qkUNWOr5ujmbTEcQ5jjEogakJ/cxJVfun8uxoTZPtH3ea4l9XK6vxRcT+MF7PepvOn2HoIuKcKtOnTIz29+j7R8HYWHOLoFRy2FCupo1vUeWXJYe5OxFTiAY7BZx6Mx8YjPxJdA794S0cnHf5f20YFyryOtyR4= Received: from BYAPR11MB2901.namprd11.prod.outlook.com (2603:10b6:a03:91::23) by BY5PR11MB3911.namprd11.prod.outlook.com (2603:10b6:a03:18d::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.30; Thu, 5 Nov 2020 11:32:37 +0000 Received: from BYAPR11MB2901.namprd11.prod.outlook.com ([fe80::8d75:dadd:9af1:81ab]) by BYAPR11MB2901.namprd11.prod.outlook.com ([fe80::8d75:dadd:9af1:81ab%7]) with mapi id 15.20.3499.032; Thu, 5 Nov 2020 11:32:37 +0000 From: "Xu, Rosen" To: "Huang, Wei" , "dev@dpdk.org" , "Zhang, Qi Z" CC: "stable@dpdk.org" Thread-Topic: [PATCH v2 2/2] raw/ifpga/base: check pointer adapter before dereference Thread-Index: AQHWsyCZ31kZOeYsLkWU0RfnP8s4yqm5aGkw Date: Thu, 5 Nov 2020 11:32:36 +0000 Message-ID: References: <1604541940-5994-1-git-send-email-wei.huang@intel.com> <1604541940-5994-3-git-send-email-wei.huang@intel.com> In-Reply-To: <1604541940-5994-3-git-send-email-wei.huang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjFiYzg1ZWYtOWE2ZC00YTI0LWE1ODctMTdlMGI0NmY3ZGRjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidytMVklid04zQ0ZNZU5lVG5UcUc3TEQ5V3daTk5aVWxEK1kwSVV5Z2h5Zm1sU2wwOFVaU3lGQVlJY1hFbjZzbCJ9 x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3d2b2337-eaae-497d-c22b-08d8817e7f0d x-ms-traffictypediagnostic: BY5PR11MB3911: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:139; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HVC2q/6xzZH6EMknMxNXcUIbKe4LARaHkUr1UBqGmZvwTByya6DDCYFuj6yWppt8o5kPKuJ2kbAm0+Yj5b+8XmKCv22b5879T8RKLvFVhflay2dA+TdiNbGOjAmVT3QEmg0vLbpHkIxPzmN635TaX9iw/ywm3/7U9iHY+ezdyOrX0a2LAHBQLMihLvAHh9DJAyEfZXx21KazGPqV2OrPVohWUkbahg5FCxAFU7dcqJ7BuE6HLTgBZfmw3ZrB+YxvZS37w/m7Peq15+T3cq7itFfj3gXQYVuapLHc1jZLpcvNTFLJ6QnVOzj2Ey/jzastNdw0YALFu1r3jBH1Mlmamg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2901.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(366004)(346002)(39860400002)(136003)(66946007)(316002)(4326008)(26005)(53546011)(110136005)(6506007)(83380400001)(2906002)(186003)(52536014)(33656002)(478600001)(55016002)(9686003)(8936002)(71200400001)(66556008)(66476007)(450100002)(5660300002)(76116006)(7696005)(66446008)(64756008)(86362001)(8676002)(6636002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: TiNOSvEevBk5dY9uc0qUJK47mqfkv/bvIQXamt7ajSuJGZTdFNiw0ieJcFmmLW4lsOYjpirIYZ0CANruTsaAvwteXri5SFSY/gjRHMilVy5Efd7wLQgMd4VZqP6Flsm3yLjeq9MJvuAVq2LTyzwXBvoM0WIb13Pgee96XDV92VijzEKEUews7QwYdjXhlj5oZcwQrQOcI3ZuZjYgxhuZKLy1P1MGW4IsphM7yR52LZbA/7mmwQWsm37J7HeLcNMfnRqF8Wzt2vjd43DcLZG3LJ6McS1AbVy9zo6BGeAtcHfzFw8/2jWfxVyQV9CN9AqVkG6GiLdX/9+Af8CuqjUrcbwIg+SUXsfJH3XB33dy0B9L5KyTGyMSaYgDAtr4dy1eoaIDD8xDjrIOvP/QXPwseugPsxzmvwekmQ2SiqsOiFdzkEwCPWef0yCGrDEeurrzIcBIJn/21IjTyMAa7TCWQRtuLcIsY50m2RXYcd0kXS6dR/6P7RoCtfZSq93fBt9sg0lWJodNKZYXvw6dPXks2+bmZehp7LRm5qIpjccOyLqKgkFVuhOZEJTJEveSKXvoN8O0qCKqScVQqrFpWdonB7Fkpx6ezPjrUa0LsQK+0VYihqK6qoruJlOV6eL6zhxWbcGF47rDesDGXAWBYp5X/Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2901.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d2b2337-eaae-497d-c22b-08d8817e7f0d X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2020 11:32:36.9056 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: i+3nWYzE4sGv6xb/8asl3AuNpJynG3FIeo06Vxh5GAq8aiPWIlQ2I9Z0Evt8jTVRTwbWia06a0je/nEKWrFxWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3911 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v2 2/2] raw/ifpga/base: check pointer adapter before dereference X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Huang, Wei > Sent: Thursday, November 05, 2020 10:06 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: stable@dpdk.org; Huang, Wei > Subject: [PATCH v2 2/2] raw/ifpga/base: check pointer adapter before > dereference >=20 > In opae_adapter_destroy(), pointer "adapter" is not validated before pass= ing > it to opae_adapter_shm_free() and opae_adapter_mutex_close() which > dereference it. >=20 > Fixes: e41856b515ce ("raw/ifpga/base: enhance driver reliability in multi= - > process") Coverity issue: 363752 >=20 > Signed-off-by: Wei Huang > --- > v2: fix typo in commit log > --- > drivers/raw/ifpga/base/opae_hw_api.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/raw/ifpga/base/opae_hw_api.c > b/drivers/raw/ifpga/base/opae_hw_api.c > index 600afdea1..d5cd5fe60 100644 > --- a/drivers/raw/ifpga/base/opae_hw_api.c > +++ b/drivers/raw/ifpga/base/opae_hw_api.c > @@ -605,10 +605,12 @@ int opae_adapter_enumerate(struct opae_adapter > *adapter) > */ > void opae_adapter_destroy(struct opae_adapter *adapter) { > - if (adapter && adapter->ops && adapter->ops->destroy) > - adapter->ops->destroy(adapter); > - opae_adapter_shm_free(adapter); > - opae_adapter_mutex_close(adapter); > + if (adapter) { > + if (adapter->ops && adapter->ops->destroy) > + adapter->ops->destroy(adapter); > + opae_adapter_shm_free(adapter); > + opae_adapter_mutex_close(adapter); > + } > } >=20 > /** > -- > 2.29.2 Acked-by: Rosen Xu