From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07E57A09FE for ; Mon, 21 Dec 2020 10:56:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C5528CB76; Mon, 21 Dec 2020 10:56:42 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 323DECA63; Mon, 21 Dec 2020 10:56:38 +0100 (CET) IronPort-SDR: CTO9LxfaWmzUzqVCC5Sy8UwqAPuWVxb+SHnx9PykA0x9X/OdTXt9pvp1vSIsmCf8AFiabFc8LM SedlFp5B4QAA== X-IronPort-AV: E=McAfee;i="6000,8403,9841"; a="162759163" X-IronPort-AV: E=Sophos;i="5.78,436,1599548400"; d="scan'208";a="162759163" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2020 01:56:35 -0800 IronPort-SDR: oKxqmikut2DGIeCNA7owJXO1cK6fovkD3f7+lZbF0jjAH1RiqiI3qXzYDZsQOIzJG5ZwuqHSve Lld7wgP26oMQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,436,1599548400"; d="scan'208";a="391091320" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga002.fm.intel.com with ESMTP; 21 Dec 2020 01:56:35 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 21 Dec 2020 01:56:35 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 21 Dec 2020 01:56:34 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 21 Dec 2020 01:56:34 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 21 Dec 2020 01:56:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xmq01t9aQ6M4igzwxjHVrgHDXOs3JVA4JloWrOoQR11DZ5h7A0bgZ+U3/SIZESVdQhAop3wAcUNS5LSHbZU49vSj6p0xUeuZ9kLZvklNcB13I1qQn5/e7whViqf1WFWrRvGSlgNTHmsWa4//QoaEmZy12X+wsgkITfWSHd5svlU82OMJAg0qXS7u4jSe2IVMURwuMCMzUlqp0PMMPB17Daf9lUX7HXWOWcULY+x474WgPPhCUcjvWqFvnzwdSH42rbIdPAWgYfoOhqKxxIohqm24jYuSbQjZcZr+TrhR6wuEOxHo+QjRyyjfgvGaCXyXRWK2jTy1cTRgQEOYbBbr5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wg7GiCoSut+ODu2DOa9DmJHtvuBPWeh53LiN6a34kYo=; b=OxkHbXdNyg1oBy3mTbhuUSEMVOeu92YFuYwpT/IzD6qem+6E1tERx5mdyxUwOHvFYMTqik+clEkMz7tD/PfmnUo0s77W/W7bHaCNgXaNSI+ERTvksM1PXVW5Jf0XqzqCRoz3YRXYap+P9b7DuwHXK1jFnMI0bf/UKVrVGWPPWTYajYb1BlojpiK5tbz4ddct/XsEI9PpLPLlU83ms+kUP9Nf1Hm8SexTOYTceYX14Ob5tE1IeQ1RtVKcFm+6ENh0ncVImUhWkWRdaaGKW8CJhnVNt8DrPqSGqBIBT74gdHFl+MZN3pHkJnO2GNz6kFctumO7jB3ZnOkamrkOkqhz5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wg7GiCoSut+ODu2DOa9DmJHtvuBPWeh53LiN6a34kYo=; b=xbHDpIaQbmY9hd6ZdxZNbZV2QjDGM+m3u/IwWSgM2H7aUVPHFQh61GZJnh1/CF7gQcxY+DLKTl1Np00gAevp81H0mYIlWvJ/BJlzmGInwM32BIbsDD9SBMmLNwQhWMWrWWnPtFMp8WTPshZ3T9iqk9koeHm4X3Ii25aWOc2Dmr0= Received: from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32) by BYAPR11MB3592.namprd11.prod.outlook.com (2603:10b6:a03:fb::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.30; Mon, 21 Dec 2020 09:56:34 +0000 Received: from BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::31df:76d6:bf35:3843]) by BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::31df:76d6:bf35:3843%6]) with mapi id 15.20.3676.029; Mon, 21 Dec 2020 09:56:34 +0000 From: "Van Haaren, Harry" To: Feifei Wang , "Rao, Nikhil" CC: "dev@dpdk.org" , "nd@arm.com" , "pbhagavatula@marvell.com" , "stable@dpdk.org" , "jerinj@marvell.com" Thread-Topic: [PATCH] examples/eventdev: move eth stop to the end Thread-Index: AQHW11sm5qIedvO5tEOTXN+LNLsqPKoBQ0Cw Date: Mon, 21 Dec 2020 09:56:33 +0000 Message-ID: References: <20201221053454.47307-1-feifei.wang2@arm.com> In-Reply-To: <20201221053454.47307-1-feifei.wang2@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.40.59.136] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 24e220b0-532a-4bf9-ce34-08d8a596b315 x-ms-traffictypediagnostic: BYAPR11MB3592: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: f1XOAczIjP97kePqYRXAz6eb9HLKFIh1VMdtR6uLk4X37pX3n4mPabQmaH+4ltIdUjeAZkQScE38OhRXOoniptmjF10+aYygGFhIfFoCneeL8U0N18vs70aKJHuo1v4IjB9rk22VGTx7ox3O1G/a3oxadNctJLMqO+FzagOU/3NWpRa5OJ+IEaixp2KQFl3NFTQwQwn/ZaquY3KtJyNvRPVEApJx4KomhJa8ObCRknsDLxnZl7x874pk+OYHDyWVYa5Wx9SEHAAdYP4Znb440QLMt70DshVhQvJGQ/mrYhR0FgndQo58HPjejS4M0hjqa7T7LupF4ML7PI8hj2H8HWChiHsfHjaqdD2RW/eysYdXuSDlPYvRqHyh3RnT2A94CpYbC87USxtgFJ0RKfNYjg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(396003)(376002)(136003)(39860400002)(53546011)(83380400001)(7696005)(6636002)(71200400001)(54906003)(110136005)(186003)(66556008)(66946007)(66446008)(64756008)(76116006)(66476007)(5660300002)(9686003)(8936002)(52536014)(55016002)(478600001)(316002)(8676002)(33656002)(86362001)(26005)(2906002)(4326008)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?BF6aNBHPRpwyDIiGHA3RnKLV4JMivyNYPyicWx7Xs+E6EG/cTXpQEmRN64dZ?= =?us-ascii?Q?ZmxJjOWU+8Ia687LWhoBIrrEIOn+nl5Uj99SGAZjwJ1tbkmG3CSpKOoG7sLH?= =?us-ascii?Q?bB466N7YYBMxmwNQ9BrAyEml8JmLucPfMELormJmL8viAzakDSh84NpfNM8W?= =?us-ascii?Q?KAqV23qJIinxLfp7WI5UW1+LP2KOF9IVlSqTFe8xqW50YpqUNjuFkXHoOMZh?= =?us-ascii?Q?/HKEaI1bDPfoysmFKg0WVkTGSkr7f0srcpefJacZuubzoOyc5AuNLH0OaQq3?= =?us-ascii?Q?GTcnR0oP8iEvm7ilehypWH+hkY5xMJ2ELtrbQ5DxsjIsMO50xWzHVfXEBceJ?= =?us-ascii?Q?kDQ4MuSqnIOpgSBu0JBuvb1anKteVeEInBAkk9IWwsBt/S+UZXOvJImhPOq8?= =?us-ascii?Q?I6Vq9OPEhEln9rgR885nLmDCQDyH02vG0YbsdEg18H/JRTGZhFVl1YeYn6QT?= =?us-ascii?Q?pzASdkNyCec9K+/udsZ4FIwKPYLzBcce9v5H6gnsAZLzEASThYHRZh8Cx1DL?= =?us-ascii?Q?xAASrNyqEPL5BsHPBJhC/IFQe41IYn9dPd+nG2VCjsxLhC5oL+C6ulVAPkKK?= =?us-ascii?Q?dAT/5T2ex1IBrLCKLbXTYpkrMC6P+CtaAi5b/GfTUWEOp0AGdqLA4U31bIC6?= =?us-ascii?Q?fuK8zNaDkltear5EiNfH7jyXX9fKKSspvGox+Vr2//1Q74pqm4E7rC3kUCf7?= =?us-ascii?Q?EVUC44KTEWBvTGFqLK23DyGHAN376nnfqXpOI5OTKes5lmIoSXZH6WnUcfZi?= =?us-ascii?Q?dkotsGD+x/Q6d/84iao4RHalhYkrP4gf+tJZlbvyXaYobVJo52Bl69Tawbl+?= =?us-ascii?Q?ZLQ9llmOxSgaap1svVQU4RXhEQfzZuaPR2AEANy3Mo3+fxCKN+IXpwL47ph3?= =?us-ascii?Q?CXb5HJZT0pgMgLK90yZEUIwBkmyBeP8Rbd6ik143gfze2D92xN7LNpXAdwF/?= =?us-ascii?Q?M5jZK8wWF4K9cg/wGIp8MPQaj3qgbJYnCjrs1BVqCLY=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3143.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24e220b0-532a-4bf9-ce34-08d8a596b315 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2020 09:56:33.9574 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 33P1WWlwa2u3vjDnSW4qtme8j3ruXP2pBl8E7FDcP/g9hgJcSau5IO3A74aDqZzeZ49eMYLzTYYXStkxis4rqTWKCk7iiOPppKB0hjX2T5E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3592 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH] examples/eventdev: move eth stop to the end X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Feifei Wang > Sent: Monday, December 21, 2020 5:35 AM > To: Van Haaren, Harry ; Rao, Nikhil > ; Pavan Nikhilesh > Cc: dev@dpdk.org; nd@arm.com; Feifei Wang ; > pbhagavatula@marvell.com; stable@dpdk.org > Subject: [PATCH] examples/eventdev: move eth stop to the end Suggested title improvement? examples/eventdev_pipeline: refactor ethdev port stop > Move eth stop code from "signal_handler" function to the end of "main" > function. There are two reasons for this: >=20 > First, this improves code maintenance and makes code look simple and clea= r. > Based on this change, after receiving the interrupt signal, "fdata->done" > is set as 1. Then the main thread will wait all worker lcores to jump out > of the loop. Finally, the main thread will stop and then close eth dev po= rt. >=20 > Second, for older version, the main thread first stops eth dev port and t= hen > waits the end of worker lcore. This may cause errors because it may stop = the > eth dev port which worker lcores are using. This moving change can fix th= is > by waiting all worker threads to exit and then stop the eth dev port. I'm OK with the above changes, and agree that moving eth dev port close to after lcores return is a worthy change. > In the meanwhile, remove wmb in signal_handler. >=20 > This is because when the main lcore receive the stop signal, it stores 1 > into fdata->done. And then the worker lcores load "fdata->done" and jump = out > of the loop to stop running. Nothing should be stored after updating > fdata->done, so the wmb is unnecessary. > > Fixes: 085edac2ca38 ("examples/eventdev_pipeline: support Tx adapter") > Cc: pbhagavatula@marvell.com > Cc: stable@dpdk.org >=20 > Suggested-by: Ruifeng Wang > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > Reviewed-by: Honnappa Nagarahalli +Cc Jerin for Eventdev tree; -Cc Pavan's old email address Ack-ed by: Harry van Haaren