From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>, Ray Kinsella <mdr@ashroe.eu>,
"Neil Horman" <nhorman@tuxdriver.com>,
Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: Re: [dpdk-stable] [PATCH] service: clean references to removed symbol
Date: Thu, 8 Apr 2021 12:54:17 +0000 [thread overview]
Message-ID: <BYAPR11MB3143848E1C8A3A884BC6D712D7749@BYAPR11MB3143.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210407090656.29176-1-david.marchand@redhat.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, April 7, 2021 10:07 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com>; Ray
> Kinsella <mdr@ashroe.eu>; Neil Horman <nhorman@tuxdriver.com>; Pavan
> Nikhilesh <pbhagavatula@caviumnetworks.com>
> Subject: [PATCH] service: clean references to removed symbol
>
> rte_service_get_id() was removed in v17.11 but the API description
> still referenced it and a version node was still present in EAL map.
>
> Fixes: 8edc9aaaf217 ("service: use id in get by name function")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
For rte_service.h doc changes I'm all fine.
For ABI consistency, this removes a function from the DPDK_21 version map that didn't exist in
the shared object itself. I'm not sure if that's an ABI break or not... I see ABI experts on CC,
and will let them comment on that topic.
Reviewed-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
> lib/librte_eal/include/rte_service.h | 5 +----
> lib/librte_eal/version.map | 1 -
> 2 files changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/lib/librte_eal/include/rte_service.h
> b/lib/librte_eal/include/rte_service.h
> index ca9950d091..c7d037d862 100644
> --- a/lib/librte_eal/include/rte_service.h
> +++ b/lib/librte_eal/include/rte_service.h
> @@ -47,10 +47,7 @@ extern "C" {
> #define RTE_SERVICE_CAP_MT_SAFE (1 << 0)
>
> /**
> - * Return the number of services registered.
> - *
> - * The number of services registered can be passed to *rte_service_get_by_id*,
> - * enabling the application to retrieve the specification of each service.
> + * Return the number of services registered.
> *
> * @return The number of services registered.
> */
> diff --git a/lib/librte_eal/version.map b/lib/librte_eal/version.map
> index e23745ae6e..0f2a9228b3 100644
> --- a/lib/librte_eal/version.map
> +++ b/lib/librte_eal/version.map
> @@ -159,7 +159,6 @@ DPDK_21 {
> rte_service_component_unregister;
> rte_service_dump;
> rte_service_finalize;
> - rte_service_get_by_id;
> rte_service_get_by_name;
> rte_service_get_count;
> rte_service_get_name;
> --
> 2.23.0
next prev parent reply other threads:[~2021-04-08 12:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 9:06 David Marchand
2021-04-08 12:54 ` Van Haaren, Harry [this message]
2021-04-08 12:58 ` David Marchand
2021-04-08 13:06 ` Van Haaren, Harry
2021-04-08 14:04 ` David Marchand
2021-04-08 14:54 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2021-04-08 16:09 ` [dpdk-stable] " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3143848E1C8A3A884BC6D712D7749@BYAPR11MB3143.namprd11.prod.outlook.com \
--to=harry.van.haaren@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).